public inbox for [email protected]  

help / color / mirror / Atom feed

From: navnath gadakh <[email protected]>
To: Khushboo Vashi <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin4][Patch] - RM 2186 - Support external authentication sources [LDAP]
Date: Tue, 17 Mar 2020 15:36:47 +0530
Message-ID: <CAOAJCYq+4hzqtVCMTUD-CyEYwdj-NS-ZvuabUx0_AL3FUXiMKw@mail.gmail.com> (raw)
In-Reply-To: <CAFOhELeCi7Dyp_T5EeKQXWLc1H580u5o13BKQeFxAZPpjRmhTw@mail.gmail.com>
References: <CAFOhELeCi7Dyp_T5EeKQXWLc1H580u5o13BKQeFxAZPpjRmhTw@mail.gmail.com>

Hi Khushboo,
       I think there is no use of

+    if app is not None:
+        AuthSourceRegistry.load_auth_sources()
+

in get_auth_sources() function.


On Tue, Mar 17, 2020 at 2:25 PM Khushboo Vashi <
[email protected]> wrote:

> Hi,
>
> Please find the attached patch to support LDAP Authentication in Server
> mode.
> To test the patch, config_auth.py needs to be configured for LDAP
> configurations. The config settings are explained in this file in detail.
> After configuring the parameters, start the pgadmin server in Server mode
> and connect with LDAP server with the valid user via login page.
>
> I have tested this patch with ldap and ldap + ssl/tls. With the TLS, I
> have used the default config of ldap3 without certificates.
>
> @Dave, can you please review this patch, as you have a better
> understanding of LDAP and you can easily pointed out if I have missed
> anything.
>
> Note: For the document update I will create the task and assign to Nidhi
> for the same.
>
> Thanks,
> Khushboo
>


-- 
*-- Navnath*

view thread (16+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: [pgAdmin4][Patch] - RM 2186 - Support external authentication sources [LDAP]
  In-Reply-To: <CAOAJCYq+4hzqtVCMTUD-CyEYwdj-NS-ZvuabUx0_AL3FUXiMKw@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox