Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bVHMo-0005rR-NM for pgadmin-hackers@arkaria.postgresql.org; Thu, 04 Aug 2016 12:03:14 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1bVHMn-0002Hs-An for pgadmin-hackers@arkaria.postgresql.org; Thu, 04 Aug 2016 12:03:13 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bVHMY-00022u-SJ for pgadmin-hackers@postgresql.org; Thu, 04 Aug 2016 12:02:59 +0000 Received: from mail-qk0-x233.google.com ([2607:f8b0:400d:c09::233]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1bVHMQ-0003Yk-72 for pgadmin-hackers@postgresql.org; Thu, 04 Aug 2016 12:02:58 +0000 Received: by mail-qk0-x233.google.com with SMTP id x185so35893203qkc.2 for ; Thu, 04 Aug 2016 05:02:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=wh4jR3SQcU+mn59BgmvjpsMKeyHgrAClV0CjBhJX8BM=; b=r5AmleAye4C0E6cgN/7XqYeXQTA5To9qwkp23MgtwfyWcpI/H3Ttp00ktzkZMqmNdD my5Ftp1eNFf2w8zunhbk2CG/4386KtipoupEXMBAtDsW9uEAhP93HoxxyE3Ds8eGcO4w yCdVcU0aUBllxI1iLs4EhCvZKetBbyWPgZSae64Wyi33vtaeQMFOsU0e6Jpo0gqqc22U p6uG4FdwAbA64Td/2lzbrgMzHlI5UYYCSUzOW4xJTEnowzeM1u/+af1YTWxEJBWF1mHd KZCXhoeF6xwIx2uaTTJGq7jDKFmQIAd60u+0izUF9slCoeWteswg5uyfBQcXQuCs24Te QEhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=wh4jR3SQcU+mn59BgmvjpsMKeyHgrAClV0CjBhJX8BM=; b=YZJKkwm6iUSLRfITyRUFMomExp1OwBMznqZKsjV+6XJH840FhFWX8AZL5NGrsDVy8Y uMUKPDNWNQFip1QHhbU31EO/afn5cdwBPLduXDB+ZKmpT1Hqpxz7idXhqYeLlfNJsyPs KDCjVjepK6LByBCeoNQEbeWRm07wpCgfDAm2EDFezWpJHzap4EMIgww9py8CYjBJQEgX kx4koR4u8EqTvIoRT1OWndrLRsr0sv4/mKWAjy5hBNG+Shervj5C01uJ+JcJkGLJJbl6 X5L4md9tYls+1UzMXTG7Ye+K0SQKJD2SFEqpidlBft7AngWSS5+Nk2JylVqG/32e8kZ5 WeIA== X-Gm-Message-State: AEkoouuQ7n65EAKFzvy6Fj6B4tE8Ht6MVNkf0/NqNAI0hEj854rnqwO50cQ8UazcDlLluwrEEDCjHzofJWpF8b3e X-Received: by 10.55.79.4 with SMTP id d4mr5950710qkb.95.1470312168441; Thu, 04 Aug 2016 05:02:48 -0700 (PDT) MIME-Version: 1.0 Received: by 10.200.41.90 with HTTP; Thu, 4 Aug 2016 05:02:47 -0700 (PDT) In-Reply-To: References: From: Navnath Gadakh Date: Thu, 4 Aug 2016 17:32:47 +0530 Message-ID: Subject: Re: pgAdmin IV : Unittest modular patch To: Dave Page Cc: pgadmin-hackers , Kanchan Mohitey Content-Type: multipart/alternative; boundary=001a114a97d282690205393dba60 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a114a97d282690205393dba60 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hi Dave, On Thu, Aug 4, 2016 at 4:04 PM, Dave Page wrote: > Hi > > On Thu, Aug 4, 2016 at 10:27 AM, Navnath Gadakh > wrote: > > >> Oh - does the per-server config override the main config? That's > >> useful. So anything that's in test_advanced_config.py can be > >> overridden on a per-server basis in test_config.py? > > > > No. > > per-server i.e advance config(test_advanced_config.json.in) and mai= n > > config(test_config.json) both are different files. In main config we ju= st > > mention the server=E2=80=99s credentials.(We can also mention per serve= r > > credentails) and in test_advanced_config.json.in(here we say per-server > > config) > > we mention the advanced configurations i.e. test data for each node. > > OK. > > > So, let's summarize the discussion: > > - Let user specify the tablespace path in > test_advanced_config.json.in > > No - test_config.py. It should be per-server. > We don't have a file named 'test_config.py' but we have a server's credential file named 'test_config.json'. So, you are saying the tablespace path to be added in 'test_config.json'. Am I correct? > > > - If path not specified in the test_advanced_config.json.in skip th= e > > test cases for tablespace. > > Yes (but, test_config.py), for that server only. > > > - Output a notice saying the test was skipped, and note it in the > > summary. > > Yes. > > > - No need to check the address.(Unix domain socket). It seems corre= ct > > way. > > Right. > > Thanks! > > -- > Dave Page > VP, Chief Architect, Tools & Installers > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > --=20 Thanks, Navnath Gadakh Software Engineer EnterpriseDB Corporation Mobile: +91 9975389878 --001a114a97d282690205393dba60 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi Dave,

On Thu, Aug 4, 2016 at 4:04 PM, Dave Page <dave.page@ente= rprisedb.com> wrote:
Hi

On Thu, Aug 4, 2016 at 10:27 AM, Navnath Gadakh
<navnath.gadakh@enter= prisedb.com> wrote:

>> Oh - does the per-server config override the main config? That'= ;s
>> useful. So anything that's in test_advanced_config.py can be >> overridden on a per-server basis in test_config.py?
>
>=C2=A0 =C2=A0 =C2=A0No.
>=C2=A0 =C2=A0 =C2=A0per-server i.e advance config(test_advanc= ed_config.json.in) and main
> config(test_config.json) both are different files. In main config we j= ust
> mention the server=E2=80=99s credentials.(We can also mention per serv= er
> credentails) and in test_advanced_config.json.in(here we= say per-server
> config)
> we mention the advanced configurations i.e. test data for each node.
OK.

>=C2=A0 =C2=A0 =C2=A0So, let's summarize the discussion:
>=C2=A0 =C2=A0 =C2=A0- Let user specify the tablespace path in test_advanced_config.json.in

No - test_config.py. It should be per-server.
= =C2=A0 =C2=A0 =C2=A0We don't have a file named 'test_config.py'= but we have a server's credential file named 'test_config.json'= ;.
=C2=A0 =C2=A0 =C2=A0So, you are saying the tablespace=C2=A0pat= h to be added in 'test_config.json'.
=C2=A0 =C2=A0 =C2=A0= Am I correct?=C2=A0
=C2=A0 =C2=A0 =C2=A0 =C2=A0

>=C2=A0 =C2=A0 =C2=A0- If path not specified in the test_advan= ced_config.json.in skip the
> test cases for tablespace.

Yes (but, test_config.py), for that server only.

>=C2=A0 =C2=A0 =C2=A0- Output a notice saying the test was skipped, and = note it in the
> summary.

Yes.

>=C2=A0 =C2=A0 =C2=A0- No need to check the address.(Unix domain socket)= . It seems correct
> way.

Right.

Thanks!

--
Dave Page
VP, Chief Architect, Tools & Installers
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake



--
=
=
Thanks,
Navnath= =C2=A0Gadakh
Software Engineer
EnterpriseDB Corporation
<= /font>
Mobile: +91 9975389878=C2=A0

<= /font>

=
--001a114a97d282690205393dba60--