public inbox for [email protected]  

help / color / mirror / Atom feed

From: Nikhil Mohite <[email protected]>
To: pgadmin-hackers <[email protected]>
Subject: [pgAdmin][RM-6122]: There is no informative message when there is no diff found
Date: Fri, 15 Jan 2021 11:43:41 +0530
Message-ID: <CAOBg0AM06iOYtycpQ50bnuzV2i4ybghB+L4+zj0k16kODyfZ-Q@mail.gmail.com> (raw)

Hi Team,

Please find the attached patch for RM-6122
<https://redmine.postgresql.org/issues/6122;: There is no informative
message when there is no diff found.

-- 
*Thanks & Regards,*
*Nikhil Mohite*
*Software Engineer.*
*EDB Postgres* <https://www.enterprisedb.com/;
*Mob.No: +91-7798364578.*


Attachments:

  [application/octet-stream] RM_6122.patch (1.3K, 3-RM_6122.patch)
  download | inline diff:
diff --git a/web/pgadmin/tools/schema_diff/static/js/schema_diff_ui.js b/web/pgadmin/tools/schema_diff/static/js/schema_diff_ui.js
index 1808e80f..ee0a10c5 100644
--- a/web/pgadmin/tools/schema_diff/static/js/schema_diff_ui.js
+++ b/web/pgadmin/tools/schema_diff/static/js/schema_diff_ui.js
@@ -307,6 +307,16 @@ export default class SchemaDiffUI {
     return false;
   }
 
+  check_empty_diff() {
+    var self = this;
+    this.panel_obj.$container.find('#schema-diff-grid .slick-viewport .pg-panel-message').remove();
+    if(self.dataView.getFilteredItems().length == 0) {
+      let msg = gettext('No difference found');
+      this.panel_obj.$container.find('#schema-diff-grid .slick-viewport'
+      ).prepend('<div class="pg-panel-message">'+ msg +'</div>');
+    }
+  }
+
   render_grid(data) {
 
     var self = this;
@@ -315,6 +325,7 @@ export default class SchemaDiffUI {
     if (self.grid) {
       // Only render the data
       self.render_grid_data(data);
+      self.check_empty_diff();
       return;
     }
     // Checkbox Column
@@ -854,6 +865,7 @@ export default class SchemaDiffUI {
     if(!_.isUndefined(self.dataView) && !_.isNull(self.dataView)) {
       // Refresh the grid
       self.dataView.refresh();
+      self.check_empty_diff();
     }
   }
 

view thread (2+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected]
  Subject: Re: [pgAdmin][RM-6122]: There is no informative message when there is no diff found
  In-Reply-To: <CAOBg0AM06iOYtycpQ50bnuzV2i4ybghB+L4+zj0k16kODyfZ-Q@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox