public inbox for [email protected]
help / color / mirror / Atom feedFrom: Nikhil Mohite <[email protected]>
To: Akshay Joshi <[email protected]>
Cc: Dave Page <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin][RM-6143]: Shared server entries not getting deleted.
Date: Thu, 21 Jan 2021 16:03:11 +0530
Message-ID: <CAOBg0AM3ycNtnMwJ2Rk1Ty-qCW4dCsq11Zz6Eaai3bRWDb3LMg@mail.gmail.com> (raw)
In-Reply-To: <CANxoLDfN2AehHnBPDLPO1vR+yw-16T8dcRx04--UX-69UmCzqQ@mail.gmail.com>
References: <CAOBg0APfo=oZvAotP9dpDf8_CveOnP9EpwsV=zn1uYPWgqPZ-Q@mail.gmail.com>
<CANxoLDfTspipwkMcJnNrnOWvguOMeHqNestMJ1dBqLGoowTeqQ@mail.gmail.com>
<CA+OCxowLS7AuXSmrfZ+PkOiVAiXU0RFPiJo8qz1b97yXG48mvA@mail.gmail.com>
<CANxoLDfN2AehHnBPDLPO1vR+yw-16T8dcRx04--UX-69UmCzqQ@mail.gmail.com>
Hi Dave,
On Thu, Jan 21, 2021 at 3:24 PM Akshay Joshi <[email protected]>
wrote:
> Reverted the commit.
>
> On Thu, Jan 21, 2021 at 3:13 PM Dave Page <[email protected]> wrote:
>
>> This seems like a very bad idea. What if the user that has left was the
>> user that setup 50 connections used by everyone else?
>>
>> Deleting those shared entries is (I would guess) most likely *not* what
>> the majority of users would want, and the current behaviour is definitely
>> safest.
>>
> In the current implementation when the admin user gets deleted all "*Server
groups*" created by that user are getting deleted, so if that admin has
created any *Shared server* other users are not able to access it as its
server group is not present in the database.
>
>> We should make this optional; i.e. ask the use if they want shared
>> servers created by the user to be deleted. If they say no, they should be
>> reassigned to another user; either the admin that's deleting the user, or
>> their choice of user (a little more complex of course, but more flexible).
>>
> In the shared server table, we are creating entries per user, for deletion
of non-admin user we can delete the shared server tables entries as it will
not affect any other users. (because only admin users can mark the server
as shared.)
In case of admin user deletion, will add an extra check as suggested.
>
>>
>
>> Please revert this, until the deletion is made optional.
>>
>> On Thu, Jan 21, 2021 at 9:23 AM Akshay Joshi <
>> [email protected]> wrote:
>>
>>> Thanks, patch applied.
>>>
>>> On Thu, Jan 21, 2021 at 12:18 PM Nikhil Mohite <
>>> [email protected]> wrote:
>>>
>>>> Hi Team,
>>>>
>>>> Please find the attached patch for RM-6143
>>>> <https://redmine.postgresql.org/issues/6143;: Shared server entries
>>>> not getting deleted.
>>>> Added code to delete shared server entries if the admin deletes the
>>>> user from user management.
>>>>
>>>>
>>>> --
>>>> *Thanks & Regards,*
>>>> *Nikhil Mohite*
>>>> *Software Engineer.*
>>>> *EDB Postgres* <https://www.enterprisedb.com/;
>>>> *Mob.No: +91-7798364578.*
>>>>
>>>
>>>
>>> --
>>> *Thanks & Regards*
>>> *Akshay Joshi*
>>> *pgAdmin Hacker | Principal Software Architect*
>>> *EDB Postgres <http://edbpostgres.com>*
>>>
>>> *Mobile: +91 976-788-8246*
>>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EDB: http://www.enterprisedb.com
>>
>>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
> *pgAdmin Hacker | Principal Software Architect*
> *EDB Postgres <http://edbpostgres.com>*
>
> *Mobile: +91 976-788-8246*
>
Regards,
Nikhil Mohite.
view thread (12+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: [pgAdmin][RM-6143]: Shared server entries not getting deleted.
In-Reply-To: <CAOBg0AM3ycNtnMwJ2Rk1Ty-qCW4dCsq11Zz6Eaai3bRWDb3LMg@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox