Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l01jd-0000l4-ND for pgadmin-hackers@arkaria.postgresql.org; Thu, 14 Jan 2021 12:28:17 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1l01jc-0001UV-IK for pgadmin-hackers@arkaria.postgresql.org; Thu, 14 Jan 2021 12:28:16 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l01jc-0001UM-32 for pgadmin-hackers@lists.postgresql.org; Thu, 14 Jan 2021 12:28:16 +0000 Received: from mail-qk1-x72c.google.com ([2607:f8b0:4864:20::72c]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1l01jY-0004ox-TQ for pgadmin-hackers@postgresql.org; Thu, 14 Jan 2021 12:28:14 +0000 Received: by mail-qk1-x72c.google.com with SMTP id 186so7368666qkj.3 for ; Thu, 14 Jan 2021 04:28:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=2ZUy1ncS8f6hi3GuyfGWus+oi3dyQMl94+WU4PbbiXE=; b=eAQhJyNW6V5oESi39J8+/kFJmGjPv90ncyOPQoMNO1cPRDADMGfgostUNxzyfjkzEq tB7qguQ3I6I7INHOdQ3ulULvKhsQ36J96C/ThnWV9E9+Pt5NvOy/YOgXtEYsn24fA+/k 3HfJFkwNGKVB5L52PuCf12WrkGXXDaSq42qLa/IoS77n72n4QJeAXuPcyYCQIufEycer p1nnog2bOeTh102B6IbUnne1bgiRmxIzfGHetQnVoK0kciSFZqzN1xlVC8vKH6HGslPx 0lX4vCJY68Wzk31/2rQwmmnanQ8R9PzMscwNgPraL6JBddpjhQhHbqmUbJEYA62tNacO KA1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2ZUy1ncS8f6hi3GuyfGWus+oi3dyQMl94+WU4PbbiXE=; b=IfkIk9nGQOB+yEkzjq7oUXPH+53E8giqWxT8qYjAbVRINJK1lBF/PCr3rMHYbcrwkM G/qJuTnNU8FlNsTU6J4k+ie5J7moyxu+9B9NYzcrjHxwHTu9ntuDJObkVQH/1Get8sTz 5tViIdXS54JAxRWYVnXKHIrejSIjsnuGgUetFZqgBAOQ9JxD1SZG3A3f5L8B6wKEycg5 4Aht4MI7S42AFfvxGx+bCpbiFdk631hA5Gscs0STHo8nPZholpfupVP04g/Y74V/VsjT QvB0lzrNFICqMxFvCgqlMZvGUKUevf5PIIeZDD5H5MN6Ucd8D1eDbZoNKB7dP5ac37Wk F/iQ== X-Gm-Message-State: AOAM533nCb72rpqjve2rrhSSkmjVZnejTkODEUlCvO2k4Z2Ffu9yXswt xCvkiHY6iPRQpAyPJx60HBvlyuQEPgo+LDJGzdZz3hPbW03zAR5ZVm1sb0Rp/hm4QMbWCXBw5+e Auh8bu8FxheMy8tNxiSfviu1ptlFV4JtCN8ckUxb5qe57//PKraXkuRPSZOzynhSla7u51lq7zI ezEbsZs9tYZn9Bc+w1hEpjQZoXI/yGeGx//vQy3+i7n+kJmAtAIqHcPORQHQ== X-Google-Smtp-Source: ABdhPJxOdx94wE7dJmcth4r67tvcojFwXfyT86MWui6lkfryOA2EpyuxgmBaIwh8Rad4lT010tO+skY1C/JlyZChiwk= X-Received: by 2002:a25:a86:: with SMTP id 128mr9668200ybk.370.1610627291440; Thu, 14 Jan 2021 04:28:11 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Nikhil Mohite Date: Thu, 14 Jan 2021 17:58:00 +0530 Message-ID: Subject: Re: [pgAdmin][RM-6120]: Adding/updating user should not allow to add an older date in account expires. To: Akshay Joshi Cc: pgadmin-hackers , Dave Page Content-Type: multipart/mixed; boundary="00000000000092a57e05b8db63da" X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --00000000000092a57e05b8db63da Content-Type: multipart/alternative; boundary="00000000000092a57b05b8db63d8" --00000000000092a57b05b8db63d8 Content-Type: text/plain; charset="UTF-8" Hi Akshay, Please find the updated patch, updated UI to allow users to select an older date for the account expires. Regards, Nikhil Mohite. On Thu, Jan 14, 2021 at 2:52 PM Akshay Joshi wrote: > Hi Nikhil > > On Thu, Jan 14, 2021 at 2:38 PM Dave Page wrote: > >> >> >> On Thu, Jan 14, 2021 at 8:18 AM Akshay Joshi < >> akshay.joshi@enterprisedb.com> wrote: >> >>> Thanks, patch applied. >>> >>> On Thu, Jan 14, 2021 at 11:28 AM Nikhil Mohite < >>> nikhil.mohite@enterprisedb.com> wrote: >>> >>>> Hi Team, >>>> >>>> Please find the attached patch for RM-6120 >>>> : Adding/updating user >>>> should not allow to add an older date in account expires. >>>> Added UI validation if a user enters the account expiration date >>>> manually. >>>> >>> >> I think this needs to be reverted (and the UI fixed to allow an older >> date to be selected). >> > > Please fixed as suggested by Dave and send the patch. I'll update the > RM > >> >> Selecting a past expiry date is a perfectly valid way to create an >> account that is effectively locked, for example, to allow pre-creation of >> roles for staff that are yet to join. >> >> PostgreSQL doesn't prevent this - why should we? >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EDB: http://www.enterprisedb.com >> >> > > -- > *Thanks & Regards* > *Akshay Joshi* > *pgAdmin Hacker | Principal Software Architect* > *EDB Postgres * > > *Mobile: +91 976-788-8246* > --00000000000092a57b05b8db63d8 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Akshay,

Please find the updated = patch, updated UI to allow users to select an older date=C2=A0for the accou= nt expires.


Regards,
Nikh= il Mohite.

On Thu, Jan 14, 2021 at 2:52 PM Akshay Joshi <akshay.joshi@enterprisedb.com>= ; wrote:
Hi Nikhil

On Thu, Jan 14, 2021 at 2:38 PM Dave Pa= ge <dpage@pgadmin= .org> wrote:


On Thu, Jan 14, 2021 at 8:18 AM A= kshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Thanks, patch applied= .

On Thu, Jan 14, 2021 at 11:28 AM Nikhil Mohite <nikhil.mohite@enterprisedb.com= > wrote:
=
Hi Team,

Please find the attached patch= for RM-6120:=C2=A0Adding/updating user should not allow to add=C2=A0an o= lder date in account expires.
Added UI validation if a user enter= s the account expiration date manually.

I think this needs to be reverted (and the UI f= ixed to allow an older date to be selected).
=

=C2=A0 =C2=A0Please fixed as suggested by Dave and send= the patch. I'll update the RM=C2=A0

<= /div>
Selecting a past expiry date is a perfectly valid way to create a= n account that is effectively locked, for example, to allow pre-creation of= roles for staff that are yet to join.

PostgreSQL = doesn't prevent this - why should we?

--=C2=A0= =C2=A0


--
Thank= s & Regards
Akshay Joshi
pgAdmin Hacker | Principal Softw= are Architect
EDB Po= stgres
Mobile: +91 976-788-8246

--00000000000092a57b05b8db63d8-- --00000000000092a57e05b8db63da Content-Type: application/octet-stream; name="RM_6120_v2.patch" Content-Disposition: attachment; filename="RM_6120_v2.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kjwtuwtc0 ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL2Jyb3dzZXIvc2VydmVyX2dyb3Vwcy9zZXJ2ZXJzL3Jv bGVzL3N0YXRpYy9qcy9yb2xlLmpzIGIvd2ViL3BnYWRtaW4vYnJvd3Nlci9zZXJ2ZXJfZ3JvdXBz L3NlcnZlcnMvcm9sZXMvc3RhdGljL2pzL3JvbGUuanMKaW5kZXggNjg5MDlmZDguLjZjMzgyODU0 IDEwMDY0NAotLS0gYS93ZWIvcGdhZG1pbi9icm93c2VyL3NlcnZlcl9ncm91cHMvc2VydmVycy9y b2xlcy9zdGF0aWMvanMvcm9sZS5qcworKysgYi93ZWIvcGdhZG1pbi9icm93c2VyL3NlcnZlcl9n cm91cHMvc2VydmVycy9yb2xlcy9zdGF0aWMvanMvcm9sZS5qcwpAQCAtNDE2LDYgKzQxNiw3IEBA IGRlZmluZSgncGdhZG1pbi5ub2RlLnJvbGUnLCBbCiAgICAgICAgICAgZGVwczogWydyb2xjYW5s b2dpbiddLAogICAgICAgICAgIHBsYWNlaG9sZGVyOiBnZXR0ZXh0KCdObyBFeHBpcnknKSwKICAg ICAgICAgICBoZWxwTWVzc2FnZTogZ2V0dGV4dCgnUGxlYXNlIG5vdGUgdGhhdCBpZiB5b3UgbGVh dmUgdGhpcyBmaWVsZCBibGFuaywgdGhlbiBwYXNzd29yZCB3aWxsIG5ldmVyIGV4cGlyZS4nKSwK KyAgICAgICAgICBzZXRNaW5EYXRlOiBmYWxzZSwKICAgICAgICAgfSx7CiAgICAgICAgICAgaWQ6 ICdyb2xjb25ubGltaXQnLCAgdHlwZTogJ2ludCcsIGdyb3VwOiBnZXR0ZXh0KCdEZWZpbml0aW9u JyksCiAgICAgICAgICAgbGFiZWw6IGdldHRleHQoJ0Nvbm5lY3Rpb24gbGltaXQnKSwgY2VsbDog J2ludGVnZXInLCBtaW4gOiAtMSwKZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL3N0YXRpYy9qcy9i YWNrZm9ybS5wZ2FkbWluLmpzIGIvd2ViL3BnYWRtaW4vc3RhdGljL2pzL2JhY2tmb3JtLnBnYWRt aW4uanMKaW5kZXggMjQyOTVjNzQuLjM2ODZmZmU1IDEwMDY0NAotLS0gYS93ZWIvcGdhZG1pbi9z dGF0aWMvanMvYmFja2Zvcm0ucGdhZG1pbi5qcworKysgYi93ZWIvcGdhZG1pbi9zdGF0aWMvanMv YmFja2Zvcm0ucGdhZG1pbi5qcwpAQCAtMjgyMCw2ICsyODIwLDcgQEAgZGVmaW5lKFsKICAgICAg ICAgcGxhY2Vob2xkZXI6ICdZWVlZLU1NLUREIEhIOm1tOnNzIFonLAogICAgICAgICBleHRyYUNs YXNzZXM6IFtdLAogICAgICAgICBoZWxwTWVzc2FnZTogbnVsbCwKKyAgICAgICAgc2V0TWluRGF0 ZTogdHJ1ZSwKICAgICAgIH0sCiAgICAgICBldmVudHM6IHsKICAgICAgICAgJ2JsdXIgaW5wdXQn OiAnb25DaGFuZ2UnLApAQCAtMzAwOCw2ICszMDA5LDE4IEBAIGRlZmluZShbCiAgICAgICAgICAg ICBkYXRhLnZhbHVlID0gbnVsbDsKICAgICAgICAgICB9CiAKKyAgICAgICAgICB2YXIgZGF0ZVNl dHRpbmdzID0ge307CisgICAgICAgICAgaWYgKCFkYXRhLnNldE1pbkRhdGUpIHsKKyAgICAgICAg ICAgIGRhdGVTZXR0aW5ncyA9IHsKKyAgICAgICAgICAgICAgJ2RhdGUnOiBkYXRhLnZhbHVlLAor ICAgICAgICAgICAgfTsKKyAgICAgICAgICB9IGVsc2UgeworICAgICAgICAgICAgZGF0ZVNldHRp bmdzID0geworICAgICAgICAgICAgICAnZGF0ZSc6IGRhdGEudmFsdWUsCisgICAgICAgICAgICAg ICdtaW5EYXRlJzogZGF0YS52YWx1ZSwKKyAgICAgICAgICAgIH07CisgICAgICAgICAgfQorCiAg ICAgICAgICAgdGhpcy4kZWwuZmluZCgnaW5wdXQnKS5maXJzdCgpLmRhdGV0aW1lcGlja2VyKAog ICAgICAgICAgICAgXy5leHRlbmQoewogICAgICAgICAgICAgICBrZXlCaW5kczogewpAQCAtMzA0 NCwxMCArMzA1Nyw3IEBAIGRlZmluZShbCiAgICAgICAgICAgICAgICAgICB9CiAgICAgICAgICAg ICAgICAgfSwKICAgICAgICAgICAgICAgfSwKLSAgICAgICAgICAgIH0sIHRoaXMuZGVmYXVsdHMu b3B0aW9ucywgdGhpcy5maWVsZC5nZXQoJ29wdGlvbnMnKSwgewotICAgICAgICAgICAgICAnZGF0 ZSc6IGRhdGEudmFsdWUsCi0gICAgICAgICAgICAgICdtaW5EYXRlJzogZGF0YS52YWx1ZSwKLSAg ICAgICAgICAgIH0pCisgICAgICAgICAgICB9LCB0aGlzLmRlZmF1bHRzLm9wdGlvbnMsIHRoaXMu ZmllbGQuZ2V0KCdvcHRpb25zJyksIGRhdGVTZXR0aW5ncykKICAgICAgICAgICApOwogICAgICAg ICB9CiAgICAgICAgIHRoaXMudXBkYXRlSW52YWxpZCgpOwo= --00000000000092a57e05b8db63da--