public inbox for [email protected]  

help / color / mirror / Atom feed
From: Nikhil Mohite <[email protected]>
To: Rahul Shirsat <[email protected]>
Cc: Aditya Toshniwal <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Cc: Akshay Joshi <[email protected]>
Subject: Re: [pgAdmin] RM6117 Unable to update column level privileges from security tab.
Date: Wed, 10 Feb 2021 12:57:05 +0530
Message-ID: <CAOBg0AMWsVZG6khn+tAR84mUAg9y3Q+EBs0-C_WPmx70zBUx9w@mail.gmail.com> (raw)
In-Reply-To: <CANxoLDcdL=QBnU43Ntk0WtVxs=H11pEG8bbrcUYGgKLRXe47Yg@mail.gmail.com>
References: <CAKtn9dO1bk_1aNRcOFE_FhM-KnN6Sws2w3fn=U2XK+=C=dkMDg@mail.gmail.com>
	<CAM9w-_mOwEhf8HTXDERFBoRfB_mjJqWjDQd5r83tQ8QfUmfM7w@mail.gmail.com>
	<CAKtn9dPisrrX3DCBU+AAwVZo2XmaUKCaQRBO+m5R-J6u_z1Ung@mail.gmail.com>
	<CANxoLDcdL=QBnU43Ntk0WtVxs=H11pEG8bbrcUYGgKLRXe47Yg@mail.gmail.com>

Hi Rahul,

While reviewing the patch, found one observation with update privileges.
1. While creating a table add any privileges for any user and save. (e.g:
Add Insert to user1)
2. Open table properties and update privileges for the same user by editing
the privilege (e.g: Now Add Update to user1), check "Save" button is
enabled.(Don't save the new privileges )
3. Now if we retore the privilege to older values "Save" button remains
enabled. (e.g:  Deselect "Update" from privilege.)
4. SQL is also getting generated after restoring the privilege to older
values.
[image: image.png]


Regards,
Nikhil Mohite.



On Tue, Feb 9, 2021 at 4:45 PM Akshay Joshi <[email protected]>
wrote:

> Hi Nikhil
>
> Can you please review the patch thoroughly?
>
> On Mon, Feb 8, 2021 at 3:28 PM Rahul Shirsat <
> [email protected]> wrote:
>
>> Akshay,
>>
>> Removed some whitespace warnings. While this new patch is applied there
>> are still 2 unknown whitespace warnings which are pointing to the wrong
>> location.
>>
>> Could you please let me know if this works?
>>
>> On Mon, Feb 8, 2021 at 9:53 AM Aditya Toshniwal <
>> [email protected]> wrote:
>>
>>> Hi Rahul,
>>>
>>> On Sat, Feb 6, 2021 at 1:25 AM Rahul Shirsat <
>>> [email protected]> wrote:
>>>
>>>> Hi Hackers,
>>>>
>>>> Please find the attached patch which resolves the issue of unable to
>>>> update column level privileges in the security tab.
>>>>
>>>> Additionally, when the user tries to change grantee, the sql wasn't
>>>> generating, this too issue is resolved.
>>>>
>>>> This security privilege issue is resolved for the following nodes:
>>>>
>>>> 1.) Tables (test cases are skipped as there are no resql test cases
>>>> based on pg & ppas)
>>>> 2.) Columns
>>>> 3.) Views
>>>> 4.) MViews
>>>> 5.) Types
>>>> 6.) Functions
>>>> 7.) Procedures
>>>> 8.) Trigger functions
>>>> 9.) Sequences
>>>> 10.) Schema
>>>>
>>>> P.S for committer : Warning of whitespaces after applying patch should
>>>> be ignored as it is a part of resql test case results.
>>>>
>>> Probably change the SQL generation logic to avoid the trailing
>>> whitespaces ?
>>>
>>>>
>>>> --
>>>> *Rahul Shirsat*
>>>> Senior Software Engineer | EnterpriseDB Corporation.
>>>>
>>>
>>>
>>> --
>>> Thanks,
>>> Aditya Toshniwal
>>> pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*
>>> <http://edbpostgres.com;
>>> "Don't Complain about Heat, Plant a TREE"
>>>
>>
>>
>> --
>> *Rahul Shirsat*
>> Senior Software Engineer | EnterpriseDB Corporation.
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
> *pgAdmin Hacker | Principal Software Architect*
> *EDB Postgres <http://edbpostgres.com>*
>
> *Mobile: +91 976-788-8246*
>


Attachments:

  [image/png] image.png (40.2K, 3-image.png)
  download | view image

view thread (7+ messages)  latest in thread

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: [pgAdmin] RM6117 Unable to update column level privileges from security tab.
  In-Reply-To: <CAOBg0AMWsVZG6khn+tAR84mUAg9y3Q+EBs0-C_WPmx70zBUx9w@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox