public inbox for [email protected]
help / color / mirror / Atom feedFrom: Nikhil Mohite <[email protected]>
To: Akshay Joshi <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin][RM-6988]: Reset pgAdmin layout if the layout is in an inconsistent state.
Date: Tue, 23 Nov 2021 18:28:06 +0530
Message-ID: <CAOBg0AMhtSYQnhwHSH8aAm_s4apcDy5u7PXJ9gemAYZZCvwC4Q@mail.gmail.com> (raw)
In-Reply-To: <CANxoLDeTicnSV4Dj8pXtzW3egn2jdC1u2f5_w=hxsJ3_6KpPLw@mail.gmail.com>
References: <CAOBg0AMiZfL5--CNcfcaG2kvb5SeRswpEj0gSibyVemYDaSdSQ@mail.gmail.com>
<CANxoLDfX-iLgP-DFykJLwVep67+Nn2VQ2FqO-iB2H8nhpyAVhg@mail.gmail.com>
<CAOBg0AOKHUCO0mSj_MNKPF-+zNvus2mrwmFcvWAjxV=oDS4m8Q@mail.gmail.com>
<CANxoLDeTicnSV4Dj8pXtzW3egn2jdC1u2f5_w=hxsJ3_6KpPLw@mail.gmail.com>
Hi Akshay,
Please find the updated patch for RM-6988.
1. Updated notification message for the reset layout.
2. Added notification type in alertify which was missing.
On Mon, Nov 15, 2021 at 4:38 PM Akshay Joshi <[email protected]>
wrote:
> Thanks, the patch applied.
>
> On Mon, Nov 15, 2021 at 3:36 PM Nikhil Mohite <
> [email protected]> wrote:
>
>> Hi Akshay,
>>
>> Please find the updated patch for RM-6988.
>> Resolved the issue where reset layout message showing when open query
>> tool(or open query tool in new tab).
>>
>> Regards,
>> Nikhil Mohite
>>
>> On Fri, Nov 12, 2021 at 12:00 PM Akshay Joshi <
>> [email protected]> wrote:
>>
>>> Thanks, the patch applied.
>>>
>>> On Thu, Nov 11, 2021 at 3:05 PM Nikhil Mohite <
>>> [email protected]> wrote:
>>>
>>>> Hi Hackers,
>>>>
>>>> Please find the attached patch for RM-6988:
>>>> <https://redmine.postgresql.org/issues/6988; Reset pgAdmin layout if
>>>> the layout is in an inconsistent state.
>>>>
>>>>
>>>> --
>>>> *Thanks & Regards,*
>>>> *Nikhil Mohite*
>>>> *Senior Software Engineer.*
>>>> *EDB Postgres* <https://www.enterprisedb.com/;
>>>> *Mob.No: +91-7798364578.*
>>>>
>>>
>>>
>>> --
>>> *Thanks & Regards*
>>> *Akshay Joshi*
>>> *pgAdmin Hacker | Principal Software Architect*
>>> *EDB Postgres <http://edbpostgres.com>*
>>>
>>> *Mobile: +91 976-788-8246*
>>>
>>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
> *pgAdmin Hacker | Principal Software Architect*
> *EDB Postgres <http://edbpostgres.com>*
>
> *Mobile: +91 976-788-8246*
>
--
*Thanks & Regards,*
*Nikhil Mohite*
*Senior Software Engineer.*
*EDB Postgres* <https://www.enterprisedb.com/;
*Mob.No: +91-7798364578.*
Attachments:
[application/octet-stream] RM-6988_v3.patch (1.3K, 3-RM-6988_v3.patch)
download | inline diff:
diff --git a/web/pgadmin/browser/static/js/layout.js b/web/pgadmin/browser/static/js/layout.js
index 6fa19e47..fa482f51 100644
--- a/web/pgadmin/browser/static/js/layout.js
+++ b/web/pgadmin/browser/static/js/layout.js
@@ -67,7 +67,7 @@ _.extend(pgBrowser, {
if(_panel.length == 0 && defaultLayoutCallback){
// clear the wcDocker before reset layout.
docker.clear();
- Alertify.info(gettext('pgAdmin has detected some issues with the UI layout, so reset it to the default.'), 0);
+ Alertify.info(gettext('pgAdmin has reset the layout because the previously saved layout is invalid.'), 0);
if(defaultLayoutCallback){
defaultLayoutCallback(docker);
}
diff --git a/web/pgadmin/static/js/alertify.pgadmin.defaults.js b/web/pgadmin/static/js/alertify.pgadmin.defaults.js
index d38bfff9..6c0a0054 100644
--- a/web/pgadmin/static/js/alertify.pgadmin.defaults.js
+++ b/web/pgadmin/static/js/alertify.pgadmin.defaults.js
@@ -466,7 +466,7 @@ define([
</div>
<div class="alert-text-body" role="status">${message}</div>
</div>`;
- var alert = alertify.notify(alertMessage, timeout);
+ var alert = alertify.notify(alertMessage, 'custom', timeout);
return alert;
},
warning: function(message, timeout) {
view thread (6+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: [pgAdmin][RM-6988]: Reset pgAdmin layout if the layout is in an inconsistent state.
In-Reply-To: <CAOBg0AMhtSYQnhwHSH8aAm_s4apcDy5u7PXJ9gemAYZZCvwC4Q@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox