MIME-Version: 1.0
References: 
 <CAOBg0AOa4EfDwph4Ba2=GV4SSnLJ8vxtqdb=zt8koQNAwuNy9w@mail.gmail.com>
 <CA+OCxoz-Qr9ubPZ-1wBrHkF+0B=cC72rEHURyLQfFF4dHSDbhg@mail.gmail.com>
In-Reply-To: 
 <CA+OCxoz-Qr9ubPZ-1wBrHkF+0B=cC72rEHURyLQfFF4dHSDbhg@mail.gmail.com>
From: Nikhil Mohite <nikhil.mohite@enterprisedb.com>
Date: Thu, 3 Jun 2021 14:31:32 +0530
Message-ID: 
 <CAOBg0ANKd=_H+P6v7Pp9mLE1uVdrWtSqfn_gWdLowVsyYWTS+Q@mail.gmail.com>
Subject: Re: [pgAdmin][RM-6460]: Need a mechanism to detect a corrupt/broken
 config DB file.
To: Dave Page <dpage@pgadmin.org>
Cc: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary="00000000000002296405c3d8d30a"
Archived-At: 
 <https://www.postgresql.org/message-id/CAOBg0ANKd%3D_H%2BP6v7Pp9mLE1uVdrWtSqfn_gWdLowVsyYWTS%2BQ%40mail.gmail.com>
Precedence: bulk

--00000000000002296405c3d8d30a
Content-Type: text/plain; charset="UTF-8"

Hi Dave,

On Thu, Jun 3, 2021 at 1:47 PM Dave Page <dpage@pgadmin.org> wrote:

> Hi
>
> On Thu, Jun 3, 2021 at 7:39 AM Nikhil Mohite <
> nikhil.mohite@enterprisedb.com> wrote:
>
>> Hi Hackers,
>>
>> Please find the attached patch for RM-6460
>> <https://redmine.postgresql.org/issues/6460>:  Need a mechanism to
>> detect a corrupt/broken config DB file.
>>
>> 1. Added checks if all tables added in the model are present in SQLite DB
>> or not.
>> 2. If migrations fail it will backup older file and try migrations with
>> the newly created file.
>> (User will get notification on UI for the location of the backup file and
>> newly created.)
>> 3. If the user deleted any table from SQLite DB pgAdmin will not run on
>> the next restart and it will add the missing table list in the logs.
>>
>
> Surely if any tables have been deleted, it'll fail the check in point 1?
>
Yes, but if the user deletes any table while pgAdmin is running then it
will fail when the user tries to run pgAdmin next time.
(If we remove the table from the model it will not check particular table
is present in DB or not. )

>
> --
> Dave Page
> Blog: https://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EDB: https://www.enterprisedb.com
>
> Regards,
Nikhil Mohite.

--00000000000002296405c3d8d30a
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr">Hi Dave,</div><br><div class=3D"gmail_quo=
te"><div dir=3D"ltr" class=3D"gmail_attr">On Thu, Jun 3, 2021 at 1:47 PM Da=
ve Page &lt;<a href=3D"mailto:dpage@pgadmin.org">dpage@pgadmin.org</a>&gt; =
wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0=
px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir=
=3D"ltr"><div dir=3D"ltr">Hi</div><br><div class=3D"gmail_quote"><div dir=
=3D"ltr" class=3D"gmail_attr">On Thu, Jun 3, 2021 at 7:39 AM Nikhil Mohite =
&lt;<a href=3D"mailto:nikhil.mohite@enterprisedb.com" target=3D"_blank">nik=
hil.mohite@enterprisedb.com</a>&gt; wrote:<br></div><blockquote class=3D"gm=
ail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,=
204,204);padding-left:1ex"><div dir=3D"ltr">Hi Hackers,<div><br></div><div>=
Please find the attached patch for=C2=A0<a href=3D"https://redmine.postgres=
ql.org/issues/6460" target=3D"_blank">RM-6460</a>:=C2=A0 Need a mechanism t=
o detect a corrupt/broken config DB file.</div><div><br></div><div>1. Added=
 checks if all tables added in the model are present in SQLite DB or not.</=
div><div>2. If migrations fail it will backup older file and try migrations=
 with the newly created file.=C2=A0</div><div>(User will get notification o=
n UI=C2=A0for the location=C2=A0of the backup file and newly created.)</div=
><div>3. If the user deleted any table from SQLite DB pgAdmin will not run =
on the next restart and it will add the missing table list in the logs.</di=
v></div></blockquote><div><br></div><div>Surely if any tables have been del=
eted, it&#39;ll fail the check in point 1?</div></div></div></blockquote><d=
iv>Yes, but if the user deletes any table while pgAdmin is running then it =
will fail when the user tries to run pgAdmin next time.</div><div>(If we re=
move the table from the model it will not check particular table is present=
 in DB or not. )</div><blockquote class=3D"gmail_quote" style=3D"margin:0px=
 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><di=
v dir=3D"ltr"><div class=3D"gmail_quote"><div>=C2=A0</div></div>-- <br><div=
 dir=3D"ltr"><div dir=3D"ltr">Dave Page<br>Blog: <a href=3D"https://pgsnake=
.blogspot.com" target=3D"_blank">https://pgsnake.blogspot.com</a><br>Twitte=
r: @pgsnake<br><br>EDB: <a href=3D"https://www.enterprisedb.com" target=3D"=
_blank">https://www.enterprisedb.com</a><br><br></div></div></div></blockqu=
ote><div>Regards,</div><div>Nikhil Mohite.=C2=A0</div></div></div>

--00000000000002296405c3d8d30a--