public inbox for [email protected]  

help / color / mirror / Atom feed
From: Nikhil Mohite <[email protected]>
To: Akshay Joshi <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin][RM-3827]: In Query History tab, query details should be scrollable
Date: Thu, 30 Sep 2021 22:51:38 +0530
Message-ID: <CAOBg0ANUxWVh6R6ac6WqJRwufqvUPNX9CP4EGFxDtYs0SGmE4A@mail.gmail.com> (raw)
In-Reply-To: <CANxoLDdgBUUO9ALKL6q50TaxPN093yKpTqZg15cmc90Z95DEMA@mail.gmail.com>
References: <CAOBg0AOJ34EGiXv-z6=yy9YMDre-4_Bte7VQZExK-q00F7Jmfw@mail.gmail.com>
	<CANxoLDdgBUUO9ALKL6q50TaxPN093yKpTqZg15cmc90Z95DEMA@mail.gmail.com>

Hi Akshay,

please find the attached updated patch for RM-3827 (v2)

On Fri, Sep 17, 2021 at 9:07 PM Akshay Joshi <[email protected]>
wrote:

> Thanks, the patch applied.
>
> On Thu, Sep 16, 2021 at 2:21 PM Nikhil Mohite <
> [email protected]> wrote:
>
>> Hi Hackers,
>>
>> Please find the attached patch for
>> <https://redmine.postgresql.org/issues/6672>RM-3827:
>> <https://redmine.postgresql.org/issues/3827; In Query History tab, query
>> details should be scrollable
>>
>>
>> --
>> *Thanks & Regards,*
>> *Nikhil Mohite*
>> *Software Engineer.*
>> *EDB Postgres* <https://www.enterprisedb.com/;
>> *Mob.No: +91-7798364578.*
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
> *pgAdmin Hacker | Principal Software Architect*
> *EDB Postgres <http://edbpostgres.com>*
>
> *Mobile: +91 976-788-8246*
>


Attachments:

  [application/octet-stream] RM-3827_v2.patch (1.4K, 3-RM-3827_v2.patch)
  download | inline diff:
diff --git a/web/pgadmin/static/js/sqleditor/history/query_history.js b/web/pgadmin/static/js/sqleditor/history/query_history.js
index c171f7fb..76a7aca9 100644
--- a/web/pgadmin/static/js/sqleditor/history/query_history.js
+++ b/web/pgadmin/static/js/sqleditor/history/query_history.js
@@ -73,6 +73,8 @@ export default class QueryHistory {
         cursor: 'ew-resize',
       });
 
+      $histDetails.css('overflow', 'auto');
+
       this.queryHistDetails = new QueryHistoryDetails($histDetails);
       this.queryHistDetails.setEditorPref(this.editorPref);
       this.queryHistDetails.onCopyToEditorClick(this.onCopyToEditorHandler);
diff --git a/web/pgadmin/tools/sqleditor/static/scss/_history.scss b/web/pgadmin/tools/sqleditor/static/scss/_history.scss
index cbb7b029..fbb81782 100644
--- a/web/pgadmin/tools/sqleditor/static/scss/_history.scss
+++ b/web/pgadmin/tools/sqleditor/static/scss/_history.scss
@@ -88,7 +88,7 @@
 
 .sql-editor-history-container {
   height: 100%;
-  overflow: auto;
+  overflow: hidden;
   background-color: $negative-bg;
 }
 
@@ -97,6 +97,7 @@
   height: 100%;
   width: 100%;
   min-height: 19em;
+  overflow: auto;
   display: flex;
   flex-direction: column;
   background-color: $color-bg;
@@ -157,7 +158,7 @@
     flex: 5;
     margin-left: 10px;
     margin-right: 10px;
-    min-height: 1em;
+    min-height: 4em;
     position: relative;
 
     .copy-all, .was-copied, .copy-to-editor {


view thread (4+ messages)  latest in thread

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: [pgAdmin][RM-3827]: In Query History tab, query details should be scrollable
  In-Reply-To: <CAOBg0ANUxWVh6R6ac6WqJRwufqvUPNX9CP4EGFxDtYs0SGmE4A@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox