MIME-Version: 1.0
References: 
 <CAOBg0APb6Rdy1i3n_SmB4feywcPw_fh7EWi9TdZTsDroG6gaMA@mail.gmail.com>
In-Reply-To: 
 <CAOBg0APb6Rdy1i3n_SmB4feywcPw_fh7EWi9TdZTsDroG6gaMA@mail.gmail.com>
From: Nikhil Mohite <nikhil.mohite@enterprisedb.com>
Date: Wed, 30 Dec 2020 12:29:42 +0530
Message-ID: 
 <CAOBg0ANfoqdkRh1L8Q8NeDmm_ktTNP6+=Bxx2dXg=eh_=idLdA@mail.gmail.com>
Subject: Re: [pgAdmin][RM-6088]: Migrate pgadmin4 from Flask-BabelEx to
 Flask-Babel >= 2.0
To: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary="000000000000e22d0905b7a90d6b"
Precedence: bulk

--000000000000e22d0905b7a90d6b
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Team,

I found one issue related to Flask-Babel migration.

Flask-Babel and Flask-BabelEx are causing the issue if we install them in
the same environment.
Flask-BabelEx gets installed as a dependency of Flask-Security-Too library
and currently, Flask-Security-Too doesn=E2=80=99t support Flask-Babel, but =
the
latest version (4.0 Not yet released) of Flask-Security-Too will shift to
Flask-Babel.
ref: https://github.com/Flask-Middleware/flask-security/issues/353

So I think we should hold Flask-Babel migration for now. but we can update
the FLask-BabelEx to the latest version as there is one issue related to it
this https://redmine.postgresql.org/issues/5997
<https://redmine.postgresql.org/issues/5997> we can fix it first by adding
the Flask-BabelEx minimum version in our requirements.


Regards,
Nikhil Mohite.

On Tue, Dec 29, 2020 at 4:36 PM Nikhil Mohite <
nikhil.mohite@enterprisedb.com> wrote:

> Hi Team,
>
> Please find the attached patch for RM-6088
> <https://redmine.postgresql.org/issues/6088>: Migrate pgadmin4 from
> Flask-BabelEx to Flask-Babel >=3D 2.0.
>
>
> --
> *Thanks & Regards,*
> *Nikhil Mohite*
> *Software Engineer.*
> *EDB Postgres* <https://www.enterprisedb.com/>
> *Mob.No: +91-7798364578.*
>

--000000000000e22d0905b7a90d6b
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hi Team,<br><br><div>I found one issue related to Flask-Ba=
bel migration.</div><div><br></div><div>Flask-Babel and Flask-BabelEx are c=
ausing=C2=A0the issue if we install them in the same environment.</div><div=
>Flask-BabelEx gets installed as a dependency of Flask-Security-Too library=
 and currently, Flask-Security-Too doesn=E2=80=99t support Flask-Babel, but=
 the latest version (4.0 Not yet released) of Flask-Security-Too will shift=
 to Flask-Babel.</div><div>ref:=C2=A0<a href=3D"https://github.com/Flask-Mi=
ddleware/flask-security/issues/353">https://github.com/Flask-Middleware/fla=
sk-security/issues/353</a></div><div><br></div><div>So I think we should ho=
ld Flask-Babel migration for now. but we can update the=C2=A0FLask-BabelEx =
to the latest version as there is one issue related to it this=C2=A0<a href=
=3D"https://redmine.postgresql.org/issues/5997">https://redmine.postgresql.=
org/issues/5997=C2=A0</a>=C2=A0we can fix it first by adding the Flask-Babe=
lEx minimum version in our requirements.</div><div><br></div><div><br></div=
><div><br></div><div>Regards,</div><div>Nikhil Mohite.</div></div><br><div =
class=3D"gmail_quote"><div dir=3D"ltr" class=3D"gmail_attr">On Tue, Dec 29,=
 2020 at 4:36 PM Nikhil Mohite &lt;<a href=3D"mailto:nikhil.mohite@enterpri=
sedb.com">nikhil.mohite@enterprisedb.com</a>&gt; wrote:<br></div><blockquot=
e class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px s=
olid rgb(204,204,204);padding-left:1ex"><div dir=3D"ltr">Hi Team,<div><br><=
/div><div>Please find the attached patch for <a href=3D"https://redmine.pos=
tgresql.org/issues/6088" target=3D"_blank">RM-6088</a>:=C2=A0Migrate pgadmi=
n4 from Flask-BabelEx to Flask-Babel &gt;=3D 2.0.</div><div><br><div><br></=
div>-- <br><div dir=3D"ltr"><div dir=3D"ltr"><b><font face=3D"verdana, sans=
-serif">Thanks &amp; Regards,</font></b><div><b><font face=3D"verdana, sans=
-serif">Nikhil Mohite</font></b></div><div><b><font face=3D"verdana, sans-s=
erif">Software Engineer.</font></b></div><div><a href=3D"https://www.enterp=
risedb.com/" target=3D"_blank"><b><font face=3D"verdana, sans-serif">EDB Po=
stgres</font></b></a></div><div><b><font face=3D"verdana, sans-serif">Mob.N=
o: +91-7798364578.</font></b></div></div></div></div></div>
</blockquote></div>

--000000000000e22d0905b7a90d6b--