public inbox for [email protected]  

help / color / mirror / Atom feed

From: Nikhil Mohite <[email protected]>
To: pgadmin-hackers <[email protected]>
Subject: [pgAdmin][RM-6077]: Accessibility issues in various dialogs
Date: Thu, 24 Dec 2020 13:20:32 +0530
Message-ID: <CAOBg0AOc2J3zcC+52DswB8KXsjE6FmdP13HMgg+hGYoT-yPMfQ@mail.gmail.com> (raw)

Hi Team,

Please find the attached patch for RM-6077:
<https://redmine.postgresql.org/issues/6077; Accessibility issues in
various dialogs.
Accessibility issues:
1. Server dialog.
2. Database dialog.
3. Import/Export dialog.
4. Process watcher.

Low contrast issue:
1. Updated text-muted color to "#646B82".


-- 
*Thanks & Regards,*
*Nikhil Mohite*
*Software Engineer.*
*EDB Postgres* <https://www.enterprisedb.com/;
*Mob.No: +91-7798364578.*


Attachments:

  [application/octet-stream] RM_6077.patch (2.6K, 3-RM_6077.patch)
  download | inline diff:
diff --git a/web/pgadmin/browser/static/js/node.js b/web/pgadmin/browser/static/js/node.js
index 827c7ca..3de7e5d 100644
--- a/web/pgadmin/browser/static/js/node.js
+++ b/web/pgadmin/browser/static/js/node.js
@@ -1613,6 +1613,8 @@ define('pgadmin.browser.node', [
 
           // Show contents before buttons
           j.prepend(content);
+          // add required attributes to select2 input to resolve accessibility issue.
+          $('.select2-search__field').attr('aria-label', 'select2');
           view.$el.closest('.wcFloating').find('.wcFrameButtonBar > .wcFrameButton[style!="display: none;"]').on('keydown', function(e) {
 
             if(e.shiftKey && e.keyCode === 9) {
diff --git a/web/pgadmin/misc/bgprocess/static/js/bgprocess.js b/web/pgadmin/misc/bgprocess/static/js/bgprocess.js
index 285607f..b825d02 100644
--- a/web/pgadmin/misc/bgprocess/static/js/bgprocess.js
+++ b/web/pgadmin/misc/bgprocess/static/js/bgprocess.js
@@ -319,7 +319,7 @@ define('misc.bgprocess', [
               <div class="card-header bg-primary d-flex">
                 <div>${self.type_desc}</div>
                 <div class="ml-auto">
-                  <button class="btn btn-sm-sq btn-primary pg-bg-close"><i class="fa fa-lg fa-times" role="img"></i></button>
+                  <button class="btn btn-sm-sq btn-primary pg-bg-close" aria-label='close'><i class="fa fa-lg fa-times" role="img"></i></button>
                 </div>
               </div>
               <div class="card-body px-2">
diff --git a/web/pgadmin/static/scss/resources/_default.variables.scss b/web/pgadmin/static/scss/resources/_default.variables.scss
index 1ad7c99..9d91378 100644
--- a/web/pgadmin/static/scss/resources/_default.variables.scss
+++ b/web/pgadmin/static/scss/resources/_default.variables.scss
@@ -65,7 +65,7 @@ $text-height-calc: $line-height-base*$font-size-base/1rem;
 $grid-gutter-width: 15px;
 $border-radius: 0.25rem;
 
-$text-muted: #667185 !default;
+$text-muted: #646B82 !default;
 $header-bg: $color-bg !default;
 $badge-header-bg: $header-bg !default;
 
diff --git a/web/pgadmin/tools/import_export/static/js/import_export.js b/web/pgadmin/tools/import_export/static/js/import_export.js
index fcb8bf8..7fbaab3 100644
--- a/web/pgadmin/tools/import_export/static/js/import_export.js
+++ b/web/pgadmin/tools/import_export/static/js/import_export.js
@@ -591,6 +591,7 @@ define([
 
               onshow: function() {
                 var container = $(this.elements.body).find('.tab-content:first > .tab-pane.active:first');
+                $('.select2-search__field').attr('aria-label', 'select2');
                 commonUtils.findAndSetFocus(container);
               },
             },

view thread (2+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected]
  Subject: Re: [pgAdmin][RM-6077]: Accessibility issues in various dialogs
  In-Reply-To: <CAOBg0AOc2J3zcC+52DswB8KXsjE6FmdP13HMgg+hGYoT-yPMfQ@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox