Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lNBT3-0004dy-CG for pgadmin-hackers@arkaria.postgresql.org; Fri, 19 Mar 2021 09:30:53 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1lNBT1-0005pR-Ir for pgadmin-hackers@arkaria.postgresql.org; Fri, 19 Mar 2021 09:30:51 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lNBT1-0005pK-33 for pgadmin-hackers@lists.postgresql.org; Fri, 19 Mar 2021 09:30:51 +0000 Received: from mail-yb1-xb33.google.com ([2607:f8b0:4864:20::b33]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lNBSw-0000Ps-Hz for pgadmin-hackers@postgresql.org; Fri, 19 Mar 2021 09:30:49 +0000 Received: by mail-yb1-xb33.google.com with SMTP id b10so5569898ybn.3 for ; Fri, 19 Mar 2021 02:30:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=WRg1rjLAv/03nMyNcZjs33x8R+eEskNW7uskAvxU5bU=; b=pIo1guod7rIL3p8P7gxoQJgMDXDOGh2C+1XHTLcTeD+0mAiI0LKiJvjP2UG3z8y4/x 2g+ZiYbuEEZTcNBI9fP3c/lke3Nzx25DJ2XyFVhiSNMO9wjtB9lAJ0e5/QLGkueQ592K z7E3c4C/aJWEdRM/NknFJTWn5cqoJmDN3wtQGxP6UndqP1G2gdThflB49u4MNkHksVOW m45Cj8pZ3rHBnmaZwLVZyymqjD/SQ0wvI8sKEZbF/ZHxx9Uwmn2mQbAjblH9kgF2bcA6 ZJY2t0tcof3dFvKfsb/9GTvWfrqgOwhRzMTtJj/en+7v61fudKMZ0YAbW5SxtaUrs1xL Xi/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WRg1rjLAv/03nMyNcZjs33x8R+eEskNW7uskAvxU5bU=; b=CCWj1gmW2blcJPC7Zo0AdCPZroMxE09s3UwlFtHibuik6DBSQKVqO6kWi/45a5NMWQ ECyM4ozcIeaCfNSsBRQk3zr+yYfaA/hTcDdyONN3vvQanVDfuog1rSgRuaj+0KGTKxbE WCbtCbiGLWr/11BIDGZK2MFpxDSaQxFZ/Ncu6DQPrczqJoFF/XY8Oedsix0X2ENFowNG bzMelrZnn/2vsf4jxi24deB2fM6I8yfEd7yLDFJr9DEbvU/UU2LXKZo1LsVINmOEqeO1 cS421D4plIwt/o5lucJSLQnJK+ZosW0LuL6TCxyO3kG8chzITmti2iPYzVLezKAfrflN ylDw== X-Gm-Message-State: AOAM531JGX8UuZYp9Slcasfj8TnIMdDEyOmypzXH+rgxl+0TiKjrg+oI cGZzitjD5vXcuUnvAgVVKA9/BOyKi3EtPxleNAKM5Jr5kttCKlKkSYXtqtN3YiKVCf8eSnooUiW XARnbuIJr7XeulPx2uv0PhJZG0qk/U9uYAOe4We+KMzUv0lFJoQKy1EGZuude3ssumSdeke56YD WKErjFdFOpqT90SYowb1tEZ7hOjai3N6knJHdZAShAqjmOXtNHluVZdTjZ2g== X-Google-Smtp-Source: ABdhPJx3ert8ubta3Vsm05e3JWGf8DEl9zGwwLxu01lwfdTk24LfmR1zqWYny+uDhkq0NUmgSrmUbthOkSR6PqK3IfY= X-Received: by 2002:a25:ab32:: with SMTP id u47mr4972183ybi.46.1616146244903; Fri, 19 Mar 2021 02:30:44 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Nikhil Mohite Date: Fri, 19 Mar 2021 15:00:33 +0530 Message-ID: Subject: Re: [pgAdmin][RM-5404]: Show the login roles that are members of a group role be shown when examining a group role. To: Akshay Joshi Cc: pgadmin-hackers Content-Type: multipart/mixed; boundary="000000000000d5533c05bde05ee7" X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --000000000000d5533c05bde05ee7 Content-Type: multipart/alternative; boundary="000000000000d5533905bde05ee5" --000000000000d5533905bde05ee5 Content-Type: text/plain; charset="UTF-8" Hi Akshay/ Team, Please find the updated patch. Details: 1. Hide the close tag icon on the role property tab (for 'Member of' and 'Member' field). - resolved Regards, Nikhil Mohite On Fri, Mar 12, 2021 at 1:34 PM Akshay Joshi wrote: > Thanks, patch applied. > > On Wed, Mar 10, 2021 at 5:31 PM Nikhil Mohite < > nikhil.mohite@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Please find the attached patch for RM-5404 >> : Show the login roles that >> are members of a group role be shown when examining a group role. >> Updated the existing "Role" label to "Member of" and added a new option >> "Members" to show all the roles that are members of the current Role/Group. >> Users can add or remove the roles from the list similar to the "Members of" >> option. >> >> Also added 2 UI fixes: >> 1. "Member of" (Roles in earlier implementation) and "Members" fields >> (Membership section) should be read-only in the properties panel. >> 2. If the select2 controller is set to read-only its background color is >> not getting set as per the theme color. (earlier it is set to '#eee' for >> all themes.) >> >> -- >> *Thanks & Regards,* >> *Nikhil Mohite* >> *Software Engineer.* >> *EDB Postgres* >> *Mob.No: +91-7798364578.* >> > > > -- > *Thanks & Regards* > *Akshay Joshi* > *pgAdmin Hacker | Principal Software Architect* > *EDB Postgres * > > *Mobile: +91 976-788-8246* > --000000000000d5533905bde05ee5 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi=C2=A0Akshay/ Team,

Please find t= he updated patch.
Details:
1. Hide the close tag icon o= n the role property tab (for 'Member of' and 'Member' field= ). - resolved

Regards,
Nikhil Mohite

On Fri, Mar 12, 2021 at 1:34 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Than= ks, patch applied.

On Wed, Mar 10, 2021 at 5:31 PM Nikhil Mohite <nikhil.moh= ite@enterprisedb.com> wrote:
Hi Hackers,

Please = find the attached patch for RM-5404:=C2=A0Show the login roles that are m= embers of a group role be shown when examining a group role.
Upda= ted the existing "Role" label to "Member of" and added = a new option "Members" to show all the roles that are members of = the current Role/Group. Users can add or remove the roles from the list sim= ilar to the "Members of" option.

Also ad= ded 2 UI fixes:
1. "Member of" (Roles in earlier implem= entation) and "Members" fields (Membership section) should be rea= d-only=C2=A0in the=C2=A0properties=C2=A0panel.
2. If the select2 = controller is set to read-only its background color is not getting set as p= er the theme color. (earlier it is set to '#eee' for all themes.)

--
Thanks & Regards,
Nikhil Mohite
Software Engineer.
Mob.No: +91-7798364578.
=


--
Thank= s & Regards
Akshay Joshi
pgAdmin Hacker | Principal Softw= are Architect
EDB Po= stgres
Mobile: +91 976-788-8246

--000000000000d5533905bde05ee5-- --000000000000d5533c05bde05ee7 Content-Type: application/octet-stream; name="RM-5404_v2.patch" Content-Disposition: attachment; filename="RM-5404_v2.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kmg3orqy0 ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL2Jyb3dzZXIvc2VydmVyX2dyb3Vwcy9zZXJ2ZXJzL3Jv bGVzL3N0YXRpYy9qcy9yb2xlLmpzIGIvd2ViL3BnYWRtaW4vYnJvd3Nlci9zZXJ2ZXJfZ3JvdXBz L3NlcnZlcnMvcm9sZXMvc3RhdGljL2pzL3JvbGUuanMKaW5kZXggOWJmYzJiMjYuLmRjYjk5ZWIy IDEwMDY0NAotLS0gYS93ZWIvcGdhZG1pbi9icm93c2VyL3NlcnZlcl9ncm91cHMvc2VydmVycy9y b2xlcy9zdGF0aWMvanMvcm9sZS5qcworKysgYi93ZWIvcGdhZG1pbi9icm93c2VyL3NlcnZlcl9n cm91cHMvc2VydmVycy9yb2xlcy9zdGF0aWMvanMvcm9sZS5qcwpAQCAtMjQ1LDYgKzI0NSw3IEBA IGRlZmluZSgncGdhZG1pbi5ub2RlLnJvbGUnLCBbCiAgICAgICAgIGFsbG93Q2xlYXI6IGRhdGEu ZGlzYWJsZWQgPyBmYWxzZSA6IHRydWUsCiAgICAgICAgIHBsYWNlaG9sZGVyOiBkYXRhLmRpc2Fi bGVkID8gJycgOiBnZXR0ZXh0KCdTZWxlY3Qgcm9sZXMnKSwKICAgICAgICAgd2lkdGg6ICdzdHls ZScsCisgICAgICAgIGRpc2FibGVkOiBkYXRhLnJlYWRvbmx5ID8gdHJ1ZSA6IGZhbHNlLAogICAg ICAgfSkub24oJ2NoYW5nZScsIGZ1bmN0aW9uKGUpIHsKICAgICAgICAgJChlLnRhcmdldCkuZmlu ZCgnOnNlbGVjdGVkJykuZWFjaChmdW5jdGlvbigpIHsKICAgICAgICAgfSk7Cg== --000000000000d5533c05bde05ee7--