public inbox for [email protected]
help / color / mirror / Atom feed[pgAdmin][PM-6045]: Filtered Rows along with Shift+Enter submit can result in confusing UX.
2+ messages / 2 participants
[nested] [flat]
* [pgAdmin][PM-6045]: Filtered Rows along with Shift+Enter submit can result in confusing UX.
@ 2021-02-03 12:46 Nikhil Mohite <[email protected]>
0 siblings, 1 reply; 2+ messages in thread
From: Nikhil Mohite @ 2021-02-03 12:46 UTC (permalink / raw)
To: pgadmin-hackers
Hi Team,
Please find the attached patch for RM-5809
<https://redmine.postgresql.org/issues/5809;: Filtered Rows along with
Shift+Enter submit can result in confusing UX.
Added set focus to filter text editor on the closing of the error dialog.
--
*Thanks & Regards,*
*Nikhil Mohite*
*Software Engineer.*
*EDB Postgres* <https://www.enterprisedb.com/;
*Mob.No: +91-7798364578.*
Attachments:
[application/octet-stream] RM_5809.patch (1.8K, 3-RM_5809.patch)
download | inline diff:
diff --git a/web/pgadmin/tools/datagrid/static/js/show_data.js b/web/pgadmin/tools/datagrid/static/js/show_data.js
index 741ecad0..75e4639a 100644
--- a/web/pgadmin/tools/datagrid/static/js/show_data.js
+++ b/web/pgadmin/tools/datagrid/static/js/show_data.js
@@ -109,6 +109,7 @@ function generateFilterValidateUrl(nodeData, parentData) {
function initFilterDialog(alertify, pgBrowser) {
// Create filter dialog using alertify
+ let filter_editor = null;
if (!alertify.filterDialog) {
alertify.dialog('filterDialog', function factory() {
return {
@@ -183,7 +184,7 @@ function initFilterDialog(alertify, pgBrowser) {
that.__internal.buttons[2].element.disabled = true;
// Apply CodeMirror to filter text area.
- this.filter_obj = CodeMirror.fromTextArea($sql_filter.get(0), {
+ filter_editor = this.filter_obj = CodeMirror.fromTextArea($sql_filter.get(0), {
lineNumbers: true,
mode: 'text/x-pgsql',
extraKeys: pgBrowser.editor_shortcut_keys,
@@ -235,10 +236,15 @@ function initFilterDialog(alertify, pgBrowser) {
that.close(); // Close the dialog
}
else {
- alertify.alert(
- gettext('Validation Error'),
- res.data.result
- );
+ alertify.alert()
+ .setting({
+ 'title': gettext('Validation Error 1'),
+ 'label':gettext('Ok'),
+ 'message': gettext(res.data.result),
+ 'onok': function(){
+ filter_editor.focus();
+ },
+ }).show();
}
})
.fail(function(e) {
^ permalink raw reply [nested|flat] 2+ messages in thread
* Re: [pgAdmin][PM-6045]: Filtered Rows along with Shift+Enter submit can result in confusing UX.
@ 2021-02-04 06:16 Akshay Joshi <[email protected]>
parent: Nikhil Mohite <[email protected]>
0 siblings, 0 replies; 2+ messages in thread
From: Akshay Joshi @ 2021-02-04 06:16 UTC (permalink / raw)
To: Nikhil Mohite <[email protected]>; +Cc: pgadmin-hackers
Thanks, patch applied.
On Wed, Feb 3, 2021 at 6:16 PM Nikhil Mohite <[email protected]>
wrote:
> Hi Team,
>
> Please find the attached patch for RM-5809
> <https://redmine.postgresql.org/issues/5809;: Filtered Rows along with
> Shift+Enter submit can result in confusing UX.
> Added set focus to filter text editor on the closing of the error dialog.
>
>
> --
> *Thanks & Regards,*
> *Nikhil Mohite*
> *Software Engineer.*
> *EDB Postgres* <https://www.enterprisedb.com/;
> *Mob.No: +91-7798364578.*
>
--
*Thanks & Regards*
*Akshay Joshi*
*pgAdmin Hacker | Principal Software Architect*
*EDB Postgres <http://edbpostgres.com>*
*Mobile: +91 976-788-8246*
^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2021-02-04 06:16 UTC | newest]
Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2021-02-03 12:46 [pgAdmin][PM-6045]: Filtered Rows along with Shift+Enter submit can result in confusing UX. Nikhil Mohite <[email protected]>
2021-02-04 06:16 ` Akshay Joshi <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox