public inbox for [email protected]  

help / color / mirror / Atom feed

From: Nikhil Mohite <[email protected]>
To: Akshay Joshi <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin][RM-6157]: UI issue in delete records.
Date: Tue, 9 Feb 2021 16:41:41 +0530
Message-ID: <CAOBg0APg==JtOqnmjG69OJQp8XyPK1tuLvyMcFtkGDbz-dk=rA@mail.gmail.com> (raw)
In-Reply-To: <CANxoLDczLDVkR_F_09t7O=eoUN=cSr-WLVAf95B191kyCKZb3w@mail.gmail.com>
References: <CAOBg0AM8idG7+c8+QZ7Cw+0v=KjO9H0Vmjv1hwVZXLnn4m7j9A@mail.gmail.com>
	<CANxoLDczLDVkR_F_09t7O=eoUN=cSr-WLVAf95B191kyCKZb3w@mail.gmail.com>

Hi Akshay/ Team,

Please find the updated patch for RM-6157.
1. Resolved issue related to strikeout (Red strike-through line which
indicates delete records) is getting removed on scrolling for index(Serial)
column of the table.


Regards,
Nikhil Mohite.


On Fri, Feb 5, 2021 at 2:16 PM Akshay Joshi <[email protected]>
wrote:

> Thanks, patch applied.
>
> On Thu, Feb 4, 2021 at 5:02 PM Nikhil Mohite <
> [email protected]> wrote:
>
>> Hi Team,
>>
>> Please find the attached patch for RM-6157
>> <https://redmine.postgresql.org/issues/6157;: UI issue in delete records.
>> 1. Resolved CSS issue in delete records from a data-output table.
>>
>> --
>> *Thanks & Regards,*
>> *Nikhil Mohite*
>> *Software Engineer.*
>> *EDB Postgres* <https://www.enterprisedb.com/;
>> *Mob.No: +91-7798364578.*
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
> *pgAdmin Hacker | Principal Software Architect*
> *EDB Postgres <http://edbpostgres.com>*
>
> *Mobile: +91 976-788-8246*
>


Attachments:

  [application/octet-stream] RM_6157_v2.patch (1.1K, 3-RM_6157_v2.patch)
  download | inline diff:
diff --git a/web/pgadmin/tools/sqleditor/static/js/sqleditor.js b/web/pgadmin/tools/sqleditor/static/js/sqleditor.js
index 34985b80..459e3f07 100644
--- a/web/pgadmin/tools/sqleditor/static/js/sqleditor.js
+++ b/web/pgadmin/tools/sqleditor/static/js/sqleditor.js
@@ -1053,6 +1053,18 @@ define('tools.querytool', [
       self.handler.slickgrid = grid;
       // Add listener on data-grid table scroll.
       self.handler.slickgrid.onScroll.subscribe(function() {
+        // Mark selected rows cells as selected.
+        setTimeout(() => {
+          // Can't use setSelectedRows as we are using cellSelectionModel.
+          var cellSelectionModel = self.handler.gridView.grid.getSelectionModel();
+          var ranges = cellSelectionModel.getSelectedRanges();
+
+          if (ranges.length > 1) {
+            // Set selected rows cell as selected.
+            cellSelectionModel.setSelectedRanges(ranges);
+          }
+        }, 100);
+
         if(Object.keys(self.handler.data_store.deleted).length > 0) {
           setTimeout(() => {
             $(self.handler.gridView.grid.getCanvasNode()).find('div.selected').removeClass('strikeout');

view thread (4+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: [pgAdmin][RM-6157]: UI issue in delete records.
  In-Reply-To: <CAOBg0APg==JtOqnmjG69OJQp8XyPK1tuLvyMcFtkGDbz-dk=rA@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox