MIME-Version: 1.0
References: 
 <CAOBg0AO5-Px-G4y=aMRaeAa8T8A-mWtaBhKgh4GHPiN2cSPyhg@mail.gmail.com>
 <CANxoLDfWcLzFg7EgJ6SW9qdzuGQngzHvbeS2qCN7ftnj4iaKBw@mail.gmail.com>
In-Reply-To: 
 <CANxoLDfWcLzFg7EgJ6SW9qdzuGQngzHvbeS2qCN7ftnj4iaKBw@mail.gmail.com>
From: Nikhil Mohite <nikhil.mohite@enterprisedb.com>
Date: Mon, 1 Mar 2021 16:42:39 +0530
Message-ID: 
 <CAOBg0APj74-4QGoq5+xs+d2Qq3ynVPQMQnnfPdXzXtSCTOJvYQ@mail.gmail.com>
Subject: Re: [pgAdmin]: Patch for SonarQube fixes.
To: Akshay Joshi <akshay.joshi@enterprisedb.com>
Cc: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/mixed; boundary="000000000000d14bbd05bc77b22a"
Precedence: bulk

--000000000000d14bbd05bc77b22a
Content-Type: multipart/alternative; boundary="000000000000d14bbb05bc77b228"

--000000000000d14bbb05bc77b228
Content-Type: text/plain; charset="UTF-8"

Hi Akshay,

Sorry for the inconvenience, Please find the attached patch.

Regards,
Nikhil Mohite.

On Mon, Mar 1, 2021 at 4:37 PM Akshay Joshi <akshay.joshi@enterprisedb.com>
wrote:

> Hi Nikhil
>
> You forgot to attach the patch :)
>
> On Mon, Mar 1, 2021 at 4:12 PM Nikhil Mohite <
> nikhil.mohite@enterprisedb.com> wrote:
>
>> Hi Team,
>>
>> I have fixed a few sonarQube issues, PFA patch
>> Details as follows:
>>
>> 1. Back-form  (backform.pgadmin.js):
>>
>>    - TypeError can be thrown as "$tabContent" might be null or undefined
>>    here.
>>
>> 2. User Management (user_management.js):
>>
>>    - 'self' is already declared in the upper scope.
>>    - 'res' is already declared in the upper scope.
>>    - 'self' is already declared in the upper scope.
>>    - 'ownershipModel' is already declared in the upper scope.
>>
>>
>> --
>> *Thanks & Regards,*
>> *Nikhil Mohite*
>> *Software Engineer.*
>> *EDB Postgres* <https://www.enterprisedb.com/>
>> *Mob.No: +91-7798364578.*
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
> *pgAdmin Hacker | Principal Software Architect*
> *EDB Postgres <http://edbpostgres.com>*
>
> *Mobile: +91 976-788-8246*
>

--000000000000d14bbb05bc77b228
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hi Akshay,<br><div><br></div><div>Sorry for the inconvenie=
nce, Please find the attached patch.</div><div><br></div><div>Regards,</div=
><div>Nikhil Mohite.</div></div><br><div class=3D"gmail_quote"><div dir=3D"=
ltr" class=3D"gmail_attr">On Mon, Mar 1, 2021 at 4:37 PM Akshay Joshi &lt;<=
a href=3D"mailto:akshay.joshi@enterprisedb.com">akshay.joshi@enterprisedb.c=
om</a>&gt; wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"margi=
n:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex=
"><div dir=3D"ltr">Hi=C2=A0Nikhil<div><br></div><div>You forgot to attach t=
he patch :)</div></div><br><div class=3D"gmail_quote"><div dir=3D"ltr" clas=
s=3D"gmail_attr">On Mon, Mar 1, 2021 at 4:12 PM Nikhil Mohite &lt;<a href=
=3D"mailto:nikhil.mohite@enterprisedb.com" target=3D"_blank">nikhil.mohite@=
enterprisedb.com</a>&gt; wrote:<br></div><blockquote class=3D"gmail_quote" =
style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);pa=
dding-left:1ex"><div dir=3D"ltr"><div>Hi Team,<div><br></div><div>I have fi=
xed a few=C2=A0<span>sonarQube</span>=C2=A0issues, PFA patch</div><div>Deta=
ils as follows:</div></div><div><br></div><div>1. Back-form=C2=A0 (backform=
.pgadmin.js):</div><ul><li>TypeError can be thrown as &quot;$tabContent&quo=
t; might be null or undefined here.</li></ul><div>2. User Management (user_=
management.js):</div><div><ul><li>&#39;self&#39; is already declared in the=
 upper scope. </li><li>&#39;res&#39; is already declared in the upper scope=
.</li><li>&#39;self&#39; is already declared in the upper scope.</li><li>&#=
39;ownershipModel&#39; is already declared in the upper scope.</li></ul></d=
iv><div><br></div>-- <br><div dir=3D"ltr"><div dir=3D"ltr"><b><font face=3D=
"verdana, sans-serif">Thanks &amp; Regards,</font></b><div><b><font face=3D=
"verdana, sans-serif">Nikhil Mohite</font></b></div><div><b><font face=3D"v=
erdana, sans-serif">Software Engineer.</font></b></div><div><a href=3D"http=
s://www.enterprisedb.com/" target=3D"_blank"><b><font face=3D"verdana, sans=
-serif">EDB Postgres</font></b></a></div><div><b><font face=3D"verdana, san=
s-serif">Mob.No: +91-7798364578.</font></b></div></div></div></div>
</blockquote></div><br clear=3D"all"><div><br></div>-- <br><div dir=3D"ltr"=
><div dir=3D"ltr"><div dir=3D"ltr"><div dir=3D"ltr"><div dir=3D"ltr"><div d=
ir=3D"ltr"><div><font color=3D"#3333FF"><b><span style=3D"color:rgb(0,0,0);=
font-family:arial,sans-serif;font-size:13px;border-collapse:collapse">Thank=
s &amp; Regards</span></b></font></div><div><font color=3D"#3333FF"><b><spa=
n style=3D"color:rgb(0,0,0);font-family:arial,sans-serif;font-size:13px;bor=
der-collapse:collapse">Akshay Joshi</span></b></font></div><div><font color=
=3D"#3333FF"><b><span style=3D"color:rgb(0,0,0);font-family:arial,sans-seri=
f;font-size:13px;border-collapse:collapse">pgAdmin Hacker | Principal Softw=
are Architect</span></b></font></div><font color=3D"#000000" face=3D"arial,=
 sans-serif"><b><a href=3D"http://edbpostgres.com" target=3D"_blank">EDB Po=
stgres</a></b></font><br><div><b style=3D"color:rgb(51,51,255)"><span style=
=3D"color:rgb(0,0,0);font-family:arial,sans-serif;font-size:13px;border-col=
lapse:collapse">Mobile: +91 976-788-8246<br></span></b><br></div></div></di=
v></div></div></div></div>
</blockquote></div>

--000000000000d14bbb05bc77b228--

--000000000000d14bbd05bc77b22a
Content-Type: application/octet-stream; name="SonarQubeCodeSmellFixes.patch"
Content-Disposition: attachment; filename="SonarQubeCodeSmellFixes.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_klqhd8ej0>
X-Attachment-Id: f_klqhd8ej0

ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL3N0YXRpYy9qcy9iYWNrZm9ybS5wZ2FkbWluLmpzIGIv
d2ViL3BnYWRtaW4vc3RhdGljL2pzL2JhY2tmb3JtLnBnYWRtaW4uanMKaW5kZXggMTYxMWNiNTku
LjkxYTNkZjRjIDEwMDY0NAotLS0gYS93ZWIvcGdhZG1pbi9zdGF0aWMvanMvYmFja2Zvcm0ucGdh
ZG1pbi5qcworKysgYi93ZWIvcGdhZG1pbi9zdGF0aWMvanMvYmFja2Zvcm0ucGdhZG1pbi5qcwpA
QCAtMTkwMSw4ICsxOTAxLDggQEAgZGVmaW5lKFsKICAgICAgICAgICAgICdoZWlnaHQ6ICcgKyAo
JHRhYkNvbnRlbnQuaGVpZ2h0KCkgKyA4KSArICdweCAhaW1wb3J0YW50OycKICAgICAgICAgICAp
OwogICAgICAgICB9CisgICAgICAgIHRoaXMuc3FsQ3RybC5zZXRTaXplKCR0YWJDb250ZW50Lndp
ZHRoKCkgKyAncHgnLCAkdGFiQ29udGVudC5oZWlnaHQoKSArICdweCcpOwogICAgICAgfQotICAg
ICAgdGhpcy5zcWxDdHJsLnNldFNpemUoJHRhYkNvbnRlbnQud2lkdGgoKSArICdweCcsICR0YWJD
b250ZW50LmhlaWdodCgpICsgJ3B4Jyk7CiAgICAgfSwKICAgICByZW1vdmU6IGZ1bmN0aW9uKCkg
ewogICAgICAgaWYgKHRoaXMuc3FsQ3RybCkgewpkaWZmIC0tZ2l0IGEvd2ViL3BnYWRtaW4vdG9v
bHMvdXNlcl9tYW5hZ2VtZW50L3N0YXRpYy9qcy91c2VyX21hbmFnZW1lbnQuanMgYi93ZWIvcGdh
ZG1pbi90b29scy91c2VyX21hbmFnZW1lbnQvc3RhdGljL2pzL3VzZXJfbWFuYWdlbWVudC5qcwpp
bmRleCA1MzFjOGM1OS4uY2ZhNmU1YTIgMTAwNjQ0Ci0tLSBhL3dlYi9wZ2FkbWluL3Rvb2xzL3Vz
ZXJfbWFuYWdlbWVudC9zdGF0aWMvanMvdXNlcl9tYW5hZ2VtZW50LmpzCisrKyBiL3dlYi9wZ2Fk
bWluL3Rvb2xzL3VzZXJfbWFuYWdlbWVudC9zdGF0aWMvanMvdXNlcl9tYW5hZ2VtZW50LmpzCkBA
IC02MTIsOCArNjEyLDggQEAgZGVmaW5lKFsKIAogICAgICAgICAgICAgbGV0IG93bmVyc2hpcFNl
bGVjdDJDb250cm9sID0gQmFja2Zvcm0uU2VsZWN0MkNvbnRyb2wuZXh0ZW5kKHsKICAgICAgICAg
ICAgICAgZmV0Y2hEYXRhOiBmdW5jdGlvbigpewotICAgICAgICAgICAgICAgIGxldCBzZWxmID0g
dGhpczsKLSAgICAgICAgICAgICAgICBsZXQgdXJsID0gc2VsZi5maWVsZC5nZXQoJ3VybCcpOwor
ICAgICAgICAgICAgICAgIGxldCB0aGF0ID0gdGhpczsKKyAgICAgICAgICAgICAgICBsZXQgdXJs
ID0gdGhhdC5maWVsZC5nZXQoJ3VybCcpOwogCiAgICAgICAgICAgICAgICAgdXJsID0gdXJsX2Zv
cih1cmwsIHsndWlkJzogdWlkfSk7CiAKQEAgLTYyMiwyNCArNjIyLDI0IEBAIGRlZmluZShbCiAg
ICAgICAgICAgICAgICAgICBoZWFkZXJzOiB7CiAgICAgICAgICAgICAgICAgICAgICdDYWNoZS1D
b250cm9sJyA6ICduby1jYWNoZScsCiAgICAgICAgICAgICAgICAgICB9LAotICAgICAgICAgICAg
ICAgIH0pLmRvbmUoZnVuY3Rpb24gKHJlcykgewotICAgICAgICAgICAgICAgICAgdmFyIHRyYW5z
Zm9ybSA9IHNlbGYuZmllbGQuZ2V0KCd0cmFuc2Zvcm0nKTsKLSAgICAgICAgICAgICAgICAgIGlm
KHJlcy5kYXRhLnN0YXR1cyl7Ci0gICAgICAgICAgICAgICAgICAgIGxldCBkYXRhID0gcmVzLmRh
dGEucmVzdWx0LmRhdGE7CisgICAgICAgICAgICAgICAgfSkuZG9uZShmdW5jdGlvbiAocmVzX2Rh
dGEpIHsKKyAgICAgICAgICAgICAgICAgIHZhciB0cmFuc2Zvcm0gPSB0aGF0LmZpZWxkLmdldCgn
dHJhbnNmb3JtJyk7CisgICAgICAgICAgICAgICAgICBpZihyZXNfZGF0YS5kYXRhLnN0YXR1cyl7
CisgICAgICAgICAgICAgICAgICAgIGxldCBkYXRhID0gcmVzX2RhdGEuZGF0YS5yZXN1bHQuZGF0
YTsKIAogICAgICAgICAgICAgICAgICAgICBpZiAodHJhbnNmb3JtICYmIF8uaXNGdW5jdGlvbih0
cmFuc2Zvcm0pKSB7Ci0gICAgICAgICAgICAgICAgICAgICAgc2VsZi5maWVsZC5zZXQoJ29wdGlv
bnMnLCB0cmFuc2Zvcm0uYmluZChzZWxmLCBkYXRhKSk7CisgICAgICAgICAgICAgICAgICAgICAg
dGhhdC5maWVsZC5zZXQoJ29wdGlvbnMnLCB0cmFuc2Zvcm0uYmluZCh0aGF0LCBkYXRhKSk7CiAg
ICAgICAgICAgICAgICAgICAgIH0gZWxzZSB7Ci0gICAgICAgICAgICAgICAgICAgICAgc2VsZi5m
aWVsZC5zZXQoJ29wdGlvbnMnLCBkYXRhKTsKKyAgICAgICAgICAgICAgICAgICAgICB0aGF0LmZp
ZWxkLnNldCgnb3B0aW9ucycsIGRhdGEpOwogICAgICAgICAgICAgICAgICAgICB9CiAgICAgICAg
ICAgICAgICAgICB9IGVsc2UgewogICAgICAgICAgICAgICAgICAgICBpZiAodHJhbnNmb3JtICYm
IF8uaXNGdW5jdGlvbih0cmFuc2Zvcm0pKSB7Ci0gICAgICAgICAgICAgICAgICAgICAgc2VsZi5m
aWVsZC5zZXQoJ29wdGlvbnMnLCB0cmFuc2Zvcm0uYmluZChzZWxmLCBbXSkpOworICAgICAgICAg
ICAgICAgICAgICAgIHRoYXQuZmllbGQuc2V0KCdvcHRpb25zJywgdHJhbnNmb3JtLmJpbmQodGhh
dCwgW10pKTsKICAgICAgICAgICAgICAgICAgICAgfSBlbHNlIHsKLSAgICAgICAgICAgICAgICAg
ICAgICBzZWxmLmZpZWxkLnNldCgnb3B0aW9ucycsIFtdKTsKKyAgICAgICAgICAgICAgICAgICAg
ICB0aGF0LmZpZWxkLnNldCgnb3B0aW9ucycsIFtdKTsKICAgICAgICAgICAgICAgICAgICAgfQog
ICAgICAgICAgICAgICAgICAgfQotICAgICAgICAgICAgICAgICAgQmFja2Zvcm0uU2VsZWN0MkNv
bnRyb2wucHJvdG90eXBlLnJlbmRlci5hcHBseShzZWxmLCBhcmd1bWVudHMpOworICAgICAgICAg
ICAgICAgICAgQmFja2Zvcm0uU2VsZWN0MkNvbnRyb2wucHJvdG90eXBlLnJlbmRlci5hcHBseSh0
aGF0LCBhcmd1bWVudHMpOwogICAgICAgICAgICAgICAgIH0pLmZhaWwoZnVuY3Rpb24oZSl7CiAg
ICAgICAgICAgICAgICAgICBsZXQgbXNnID0gJyc7CiAgICAgICAgICAgICAgICAgICBpZihlLnN0
YXR1cyA9PSA0MDQpIHsKQEAgLTcyOCwxNSArNzI4LDE1IEBAIGRlZmluZShbCiAgICAgICAgICAg
ICAgICAgICAgIH07CiAgICAgICAgICAgICAgICAgICB9LAogICAgICAgICAgICAgICAgICAgcHJl
cGFyZTogZnVuY3Rpb24oKSB7Ci0gICAgICAgICAgICAgICAgICAgIGxldCBzZWxmID0gdGhpczsK
KyAgICAgICAgICAgICAgICAgICAgbGV0IHRoYXQgPSB0aGlzOwogICAgICAgICAgICAgICAgICAg
ICAkY29udGFpbmVyLmh0bWwoJycpOwogCi0gICAgICAgICAgICAgICAgICAgIHNlbGYub3duZXJz
aGlwTW9kZWwgPSBuZXcgb3duZXJzaGlwTW9kZWwoKTsKLSAgICAgICAgICAgICAgICAgICAgbGV0
IGZpZWxkcyA9IHBnQmFja2Zvcm0uZ2VuZXJhdGVWaWV3U2NoZW1hKG51bGwsIHNlbGYub3duZXJz
aGlwTW9kZWwsICdjcmVhdGUnLCBudWxsLCBudWxsLCB0cnVlLCBudWxsKTsKKyAgICAgICAgICAg
ICAgICAgICAgdGhhdC5vd25lcnNoaXBNb2RlbCA9IG5ldyBvd25lcnNoaXBNb2RlbCgpOworICAg
ICAgICAgICAgICAgICAgICBsZXQgZmllbGRzID0gcGdCYWNrZm9ybS5nZW5lcmF0ZVZpZXdTY2hl
bWEobnVsbCwgdGhhdC5vd25lcnNoaXBNb2RlbCwgJ2NyZWF0ZScsIG51bGwsIG51bGwsIHRydWUs
IG51bGwpOwogCiAgICAgICAgICAgICAgICAgICAgIGxldCB2aWV3ID0gdGhpcy52aWV3ID0gbmV3
IHBnQmFja2Zvcm0uRGlhbG9nKHsKICAgICAgICAgICAgICAgICAgICAgICBlbDogJzxkaXY+PC9k
aXY+JywKLSAgICAgICAgICAgICAgICAgICAgICBtb2RlbDogc2VsZi5vd25lcnNoaXBNb2RlbCwK
KyAgICAgICAgICAgICAgICAgICAgICBtb2RlbDogdGhhdC5vd25lcnNoaXBNb2RlbCwKICAgICAg
ICAgICAgICAgICAgICAgICBzY2hlbWE6IGZpZWxkcywKICAgICAgICAgICAgICAgICAgICAgfSk7
CiAgICAgICAgICAgICAgICAgICAgIC8vUmVuZGVyIGNoYW5nZSBvd25lcnNoaXAgZGlhbG9nLgpA
QCAtNzQ1LDggKzc0NSw4IEBAIGRlZmluZShbCiAgICAgICAgICAgICAgICAgICBjYWxsYmFjazog
ZnVuY3Rpb24oZSkgewogICAgICAgICAgICAgICAgICAgICBpZihlLmJ1dHRvblsnZGF0YS1idG4t
bmFtZSddID09PSAnb2snKSB7CiAgICAgICAgICAgICAgICAgICAgICAgZS5jYW5jZWwgPSB0cnVl
OyAvLyBEbyBub3QgY2xvc2UgZGlhbG9nCi0gICAgICAgICAgICAgICAgICAgICAgbGV0IG93bmVy
c2hpcE1vZGVsID0gdGhpcy5vd25lcnNoaXBNb2RlbC50b0pTT04oKTsKLSAgICAgICAgICAgICAg
ICAgICAgICBpZiAob3duZXJzaGlwTW9kZWwudXNlciA9PSAnJyB8fCBvd25lcnNoaXBNb2RlbC51
c2VyID09IHVuZGVmaW5lZCkgeworICAgICAgICAgICAgICAgICAgICAgIGxldCBuZXdPd25lcnNo
aXBNb2RlbCA9IHRoaXMub3duZXJzaGlwTW9kZWwudG9KU09OKCk7CisgICAgICAgICAgICAgICAg
ICAgICAgaWYgKG5ld093bmVyc2hpcE1vZGVsLnVzZXIgPT0gJycgfHwgbmV3T3duZXJzaGlwTW9k
ZWwudXNlciA9PSB1bmRlZmluZWQpIHsKICAgICAgICAgICAgICAgICAgICAgICAgIGFsZXJ0aWZ5
LmNvbmZpcm0oCiAgICAgICAgICAgICAgICAgICAgICAgICAgIGdldHRleHQoJ0RlbGV0ZSB1c2Vy
PycpLAogICAgICAgICAgICAgICAgICAgICAgICAgICBnZXR0ZXh0KCdUaGUgc2hhcmVkIHNlcnZl
cnMgb3duZWQgYnkgPGI+Jysgc2VsZi5tb2RlbC5nZXQoJ3VzZXJuYW1lJykgKyc8L2I+IHdpbGwg
YmUgZGVsZXRlZC4gRG8geW91IHdpc2ggdG8gY29udGludWU/JyksCkBAIC03NzIsNyArNzcyLDcg
QEAgZGVmaW5lKFsKICAgICAgICAgICAgICAgICAgICAgICAgICAgfQogICAgICAgICAgICAgICAg
ICAgICAgICAgKTsKICAgICAgICAgICAgICAgICAgICAgICB9IGVsc2UgewotICAgICAgICAgICAg
ICAgICAgICAgICAgc2VsZi5jaGFuZ2VPd25lcihvd25lcnNoaXBNb2RlbC51c2VyLCB1aWQpOwor
ICAgICAgICAgICAgICAgICAgICAgICAgc2VsZi5jaGFuZ2VPd25lcihuZXdPd25lcnNoaXBNb2Rl
bC51c2VyLCB1aWQpOwogICAgICAgICAgICAgICAgICAgICAgIH0KICAgICAgICAgICAgICAgICAg
ICAgfSBlbHNlIHsKICAgICAgICAgICAgICAgICAgICAgICBhbGVydGlmeS5jaGFuZ2VPd25lcnNo
aXBEaWFsb2coKS5kZXN0cm95KCk7Cg==
--000000000000d14bbd05bc77b22a--