Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mpqcf-0007cs-DY for pgadmin-hackers@arkaria.postgresql.org; Wed, 24 Nov 2021 11:39:34 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1mpqcd-000440-UK for pgadmin-hackers@arkaria.postgresql.org; Wed, 24 Nov 2021 11:39:31 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mpqcd-00043r-A2 for pgadmin-hackers@lists.postgresql.org; Wed, 24 Nov 2021 11:39:31 +0000 Received: from mail-yb1-xb2f.google.com ([2607:f8b0:4864:20::b2f]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1mpqcZ-0005sA-Gt for pgadmin-hackers@postgresql.org; Wed, 24 Nov 2021 11:39:30 +0000 Received: by mail-yb1-xb2f.google.com with SMTP id 131so6385951ybc.7 for ; Wed, 24 Nov 2021 03:39:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=mBEWFiN3LWKNXVJGiln17jDdfab4g4FJiRJgIFG8+Z8=; b=mjQK4Sht8gJIvnVJL65CV5roAfypPp9yq8GMS6aV6iEYCqffztDz6gxFphPuWIE8yS qnNHbaA/jLafCGWruhWmIiChWf26dWhKu+I/IEhc4GJmCDXTVfrjONY4pDpdqxfCUhAe d6qhw9Mrx21cv1soEoLlrk3bLofycuCdfsQe4pcdEwJd1oU5FvuRLOZM8y2RjQu9P6Qr yKRUiVypnpJNuDNfK+AjI0OdOrkZ37baa0JJyHZ1If5WTsdNukCUvC/xKuovZc7qbnMB M4780M0b5wjeGRzD/qrmMP98uSzgkeVUMeRBGEX3QtgfoZYOypSw9QeK8VXsmuJ0JZt6 pf3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mBEWFiN3LWKNXVJGiln17jDdfab4g4FJiRJgIFG8+Z8=; b=SS5V9aSYx4IRqbxtw3MHTrxBpp8sjbc3HgM3nBZrnmjfb3sfqYK8Cq4kf/Cs/5lCjo qFrUZAIWsrSNMVesoK7OWI6f3gqsd/BqNm9C8tWgHEA/kXKbrY4CA+wDLeYtN6lPXowo xmDNunx/ZGDnwhCufWG4ZzEhjO6LIQTLC3rGYjiaGMwm6ZcQDE1tULRVgHRD8WAu8b+H CMUkc2c/b7d6+SAl8JLXYXBazz2SmnQSHTGBBEJiZS6MGWekw8N/y7RLBY0k0VPMK7WU CafwV4NchmMgHf9tVxpHYzLibBsMYp8azqhCnP3mAd/n+AE6nUUjkFBrJ8daeN9/D+1B XrnQ== X-Gm-Message-State: AOAM530UGnIsWyCls4m+u/D/HEfT6uW5BdDLEM3iPBpNKKKai5YvNXxY +gE/mNyBQjYODUzPTpNuFUJIVkz0eXPnZjAd3cBdFqJOQMLUbb18hnoRpjZdfExctORlexvdldg wOvH4vJmZjkP1qiXZgWnchK9uDgmb09Sl+X+Tbz/VpfYTddRHCW7xUAR2Azegqbk+KUe/I8C2ut nn+LS8FxFKclb2LUwyQNnreFK6CxF1nOPWsC3n7MkUl20bltCJdqEze66rnA== X-Google-Smtp-Source: ABdhPJyvxfLeNlnUN9xaugNZrcngRBY3Uel7IGoBC449GpmgD/RsX23eaklfA04GERJXYE5nn/xMLEvxf4mY54yNtQ4= X-Received: by 2002:a05:6902:100b:: with SMTP id w11mr16570594ybt.64.1637753965301; Wed, 24 Nov 2021 03:39:25 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Nikhil Mohite Date: Wed, 24 Nov 2021 17:09:14 +0530 Message-ID: Subject: Re: [pgAdmin][RM-6984]: Port Backup Global, Backup Server and Backup object dialog in React To: Akshay Joshi Cc: pgadmin-hackers Content-Type: multipart/mixed; boundary="00000000000054fb2305d1874fd4" X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --00000000000054fb2305d1874fd4 Content-Type: multipart/alternative; boundary="00000000000054fb2105d1874fd2" --00000000000054fb2105d1874fd2 Content-Type: text/plain; charset="UTF-8" Hi Akshay, Please find the updated patch: 1. Resolved issue if the binary patch is not present/ not correct, then show error notification to add/ correct the binary path. Regards, Nikhil Mohite On Mon, Nov 22, 2021 at 11:22 AM Akshay Joshi wrote: > Thanks, the patch applied. > > On Mon, Nov 22, 2021 at 10:48 AM Nikhil Mohite < > nikhil.mohite@enterprisedb.com> wrote: > >> Hi Akshay, >> >> Please find the updated patch. >> >> On Wed, Nov 17, 2021 at 6:34 PM Akshay Joshi < >> akshay.joshi@enterprisedb.com> wrote: >> >>> Hi Nikhil >>> >>> Following are the review comments: >>> >>> GUI: >>> >>> - Dialog size should be increased. >>> - Remove the first blank element from the Encoding dropdown. >>> - When opening the file dialog header should have the title 'Select >>> file'. >>> - 'Backup server' title should be changed to 'Backup Server'. >>> - When taking the backup of any object like database, schema, etc.. >>> the title on the dialog header should be "Backup (Database/Schema ..." >>> instead of "Backup (database/schema ..." >>> >>> >>> Code: >>> >>> - Jasmine test cases are failing. >>> - Remove warnBeforeChangesLost function not needed for Utilities. >>> (Remove Alertify as well) >>> - The naming convention should be identical, in some cases, you used >>> camel case and in some cases used with an underscore. >>> - Remove the commented code from all the files. >>> - Take all the screenshots again with a width of 681. >>> >>> Resolved all review comments. >> >>> Note: I haven't tested it thoroughly with all combinations. >>> >>> On Wed, Nov 10, 2021 at 2:50 PM Nikhil Mohite < >>> nikhil.mohite@enterprisedb.com> wrote: >>> >>>> Hi Hackers, >>>> >>>> Please find the attached patch for RM-6884: >>>> Port Backup Global, >>>> Backup Server, and Backup object dialog in React >>>> >>>> >>> >>> -- >>> *Thanks & Regards* >>> *Akshay Joshi* >>> *pgAdmin Hacker | Principal Software Architect* >>> *EDB Postgres * >>> *Mobile: +91 976-788-8246* >>> >> >> >> -- >> *Thanks & Regards,* >> *Nikhil Mohite* >> *Senior Software Engineer.* >> *EDB Postgres* >> *Mob.No: +91-7798364578.* >> > > > -- > *Thanks & Regards* > *Akshay Joshi* > *pgAdmin Hacker | Principal Software Architect* > *EDB Postgres * > > *Mobile: +91 976-788-8246* > --00000000000054fb2105d1874fd2 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Akshay,

Please find the updated patc= h:
1. Resolved issue if the binary patch is not present/ not corr= ect, then show error notification to add/ correct the binary path.

Regards,
Nikhil Mohite

On Mon, Nov 22, 2021= at 11:22 AM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Thanks, the patch applied= .

On Mon, Nov 22, 2021 at 10:48 AM Nikhil Mohite <nikhil.mohite@enterprisedb.com= > wrote:
=
Hi Akshay,

Please find= the updated patch.

On Wed, Nov 17, 2021 at 6:34 PM Akshay Joshi <<= a href=3D"mailto:akshay.joshi@enterprisedb.com" target=3D"_blank">akshay.jo= shi@enterprisedb.com> wrote:
Hi Nikhil

Following= are the review comments:

GUI:
  • D= ialog size should be increased.
  • Remove the first blank element from= the Encoding dropdown.
  • When opening the file dialog header should = have the title 'Select file'.
  • 'Backup server' title= should be changed to 'Backup Server'.
  • When taking the back= up of any object like database, schema, etc.. the=C2=A0title on the dialog = header should be "Backup (Database/Schema ..." instead of=C2=A0 &= quot;Backup (database/schema ..."

C= ode:
  • Jasmine test cases are failing.
  • Remove warnBeforeCh= angesLost function not needed for Utilities. (Remove Alertify as well)
    • =
  • The naming convention should be identical, in some cases, you used came= l case and in some cases used with an underscore.
  • Remove the commen= ted code from all the files.
  • Take all the screenshots again with a = width of 681.
Resolved all review co= mments.=C2=A0
Note: I haven't tested it thoroughly with all combi= nations.

On Wed, Nov 10, 2021 at 2:50 PM Nikhil Mohite <nikhil.mohite@= enterprisedb.com> wrote:
Hi Hackers,

Please find= the attached patch for=C2=A0RM-6884:=C2=A0 Port Backup Global, Backup Se= rver, and Backup object dialog in React



--
Thank= s & Regards
Akshay Joshi
pgAdmin Hacker | Principal Softw= are Architect
EDB Po= stgres
Mobile: +91 976-788-8246=C2=A0


--
Thanks & Regards,
Se= nior Software Engineer.
Mob.No: +9= 1-7798364578.


--
Thank= s & Regards
Akshay Joshi
pgAdmin Hacker | Principal Softw= are Architect
EDB Po= stgres
Mobile: +91 976-788-8246

--00000000000054fb2105d1874fd2-- --00000000000054fb2305d1874fd4 Content-Type: application/octet-stream; name="RM-6984_v3.patch" Content-Disposition: attachment; filename="RM-6984_v3.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kwdgejq10 ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL3Rvb2xzL2JhY2t1cC9zdGF0aWMvanMvYmFja3VwLmpz IGIvd2ViL3BnYWRtaW4vdG9vbHMvYmFja3VwL3N0YXRpYy9qcy9iYWNrdXAuanMKaW5kZXggZmZl NGVjMjguLjZhMDFlYWI0IDEwMDY0NAotLS0gYS93ZWIvcGdhZG1pbi90b29scy9iYWNrdXAvc3Rh dGljL2pzL2JhY2t1cC5qcworKysgYi93ZWIvcGdhZG1pbi90b29scy9iYWNrdXAvc3RhdGljL2pz L2JhY2t1cC5qcwpAQCAtMTc0LDcgKzE3NCwxNCBAQCBkZWZpbmUoWwogICAgICAgdGhpcy5zaG93 QmFja3VwRGlhbG9nKHNjaGVtYSwgdHJlZUl0ZW0sIGosIGRhdGEsIHBhbmVsLCB0eXBlT2ZEaWFs b2csIHNlcnZlcklkZW50aWZpZXIsIGV4dHJhRGF0YSk7CiAgICAgfSwKICAgICBzYXZlQ2FsbEJh Y2s6IGZ1bmN0aW9uKGRhdGEsIGRpYWxvZykgewotICAgICAgcGdCcm93c2VyLkV2ZW50cy50cmln Z2VyKCdwZ2FkbWluLWJncHJvY2VzczpjcmVhdGVkJywgZGlhbG9nKTsKKyAgICAgIGlmKGRhdGEu ZXJyb3Jtc2cpIHsKKyAgICAgICAgYWxlcnRpZnkuYWxlcnQoCisgICAgICAgICAgZ2V0dGV4dCgn VXRpbGl0eSBub3QgZm91bmQnKSwKKyAgICAgICAgICBnZXR0ZXh0KGRhdGEuZXJyb3Jtc2cpCisg ICAgICAgICk7CisgICAgICB9IGVsc2UgeworICAgICAgICBwZ0Jyb3dzZXIuRXZlbnRzLnRyaWdn ZXIoJ3BnYWRtaW4tYmdwcm9jZXNzOmNyZWF0ZWQnLCBkaWFsb2cpOworICAgICAgfQogICAgIH0s CiAgICAgc2hvd0JhY2t1cERpYWxvZzogZnVuY3Rpb24oc2NoZW1hLCBpdGVtLCBqLCBkYXRhLCBw YW5lbCwgdHlwZU9mRGlhbG9nLCBzZXJ2ZXJJZGVudGlmaWVyLCBleHRyYURhdGEpIHsKICAgICAg IGlmKHNjaGVtYSkgewo= --00000000000054fb2305d1874fd4--