public inbox for [email protected]  
help / color / mirror / Atom feed
From: Nikhil Mohite <[email protected]>
To: Akshay Joshi <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin][RM-5343]: [Code Coverage] Improve API test cases for Debugger
Date: Wed, 9 Dec 2020 13:24:21 +0530
Message-ID: <CAOBg0APyUYU=J1=pOXYkz_sHt4Wgjbk8iR5m_XCWSi8WoJkx6w@mail.gmail.com> (raw)
In-Reply-To: <CAOBg0APOhPo3+VFM4-LH5CZE=Yu5Y-Zmw8RhnfkVGQPkxLYPXA@mail.gmail.com>
References: <CAOBg0AOQhDiS5VQjG6ErGp=tmNj=_4T9rkL6cJeAmnGuWWtCCA@mail.gmail.com>
	<CANxoLDec48OnPneYTFdGHBzy_bDiPSWYtB8m0uh3SJEqpaSyOg@mail.gmail.com>
	<CAOBg0AMfXZgZLDRr6Vqv7BXf1+VxJDDB1J_qWqjbxYaMQD2HFw@mail.gmail.com>
	<CANxoLDeq+ZRmkOkW9rxss+vLe+3j3fTZ0VwmuQbdVh7o4Rds4Q@mail.gmail.com>
	<CAOBg0APOhPo3+VFM4-LH5CZE=Yu5Y-Zmw8RhnfkVGQPkxLYPXA@mail.gmail.com>

Hi Akshay/Team,

Please find the small patch for debugger test cases.
Added random function name generation for the debugger.


Regards,
Nikhil Mohite.


On Mon, Dec 7, 2020 at 3:32 PM Nikhil Mohite <[email protected]>
wrote:

> Hi Akshay/Team,
>
> Please find the updated patch for debugger test cases.
> 1. Resolved the issues related to the database connection.
> 2. Updated the create "pldbgapi" extension for the debugger.
>
>
> Regards,
> Nikhil Mohite.
>
> On Thu, Dec 3, 2020 at 10:47 AM Akshay Joshi <
> [email protected]> wrote:
>
>> Thanks, patch applied.
>>
>> On Wed, Dec 2, 2020 at 11:25 AM Nikhil Mohite <
>> [email protected]> wrote:
>>
>>> Hi Akshay,
>>>
>>> please find the updated patch, sorry for the inconvenience.
>>>
>>>
>>> Regards,
>>> Nikhil Mohite.
>>>
>>> On Wed, Dec 2, 2020 at 11:03 AM Akshay Joshi <
>>> [email protected]> wrote:
>>>
>>>> Hi Nikhil
>>>>
>>>> The patch is not applied, please rebase and send the patch again.
>>>>
>>>> On Tue, Dec 1, 2020 at 2:48 PM Nikhil Mohite <
>>>> [email protected]> wrote:
>>>>
>>>>> Hi Team,
>>>>>
>>>>> Please find the attached patch for RM-5343
>>>>> <https://redmine.postgresql.org/issues/5343;: [Code Coverage] Improve
>>>>> API test cases for Debugger.
>>>>> also updated implementation to remove dead code and unhandled
>>>>> exceptions.
>>>>>
>>>>>
>>>>> --
>>>>> *Thanks & Regards,*
>>>>> *Nikhil Mohite*
>>>>> *Software Engineer.*
>>>>> *EDB Postgres* <https://www.enterprisedb.com/;
>>>>> *Mob.No: +91-7798364578.*
>>>>>
>>>>
>>>>
>>>> --
>>>> *Thanks & Regards*
>>>> *Akshay Joshi*
>>>> *pgAdmin Hacker | Principal Software Architect*
>>>> *EDB Postgres <http://edbpostgres.com>*
>>>>
>>>> *Mobile: +91 976-788-8246*
>>>>
>>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>> *pgAdmin Hacker | Principal Software Architect*
>> *EDB Postgres <http://edbpostgres.com>*
>>
>> *Mobile: +91 976-788-8246*
>>
>


Attachments:

  [application/octet-stream] RM_5343_v4.patch (734B, 3-RM_5343_v4.patch)
  download | inline diff:
diff --git a/web/pgadmin/tools/debugger/tests/utils.py b/web/pgadmin/tools/debugger/tests/utils.py
index 0d508c1..75280a3 100644
--- a/web/pgadmin/tools/debugger/tests/utils.py
+++ b/web/pgadmin/tools/debugger/tests/utils.py
@@ -1,5 +1,6 @@
 import os
 import json
+import uuid
 
 
 CURRENT_PATH = os.path.dirname(os.path.realpath(__file__))
@@ -21,6 +22,8 @@ def delete_function(self, utils):
 
 def create_function(self, utils):
     self.test_data['pronamespace'] = self.schema_id
+    self.test_data['name'] = self.test_data['name'] + str(uuid.uuid4())[1:8]
+
     function_url = 'browser/function/obj/{0}/{1}/{2}/{3}/'.format(
         str(utils.SERVER_GROUP), str(self.server_id), str(self.db_id),
         str(self.schema_id))


view thread (15+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: [pgAdmin][RM-5343]: [Code Coverage] Improve API test cases for Debugger
  In-Reply-To: <CAOBg0APyUYU=J1=pOXYkz_sHt4Wgjbk8iR5m_XCWSi8WoJkx6w@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox