Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hb599-0006qZ-QG for pgadmin-hackers@arkaria.postgresql.org; Wed, 12 Jun 2019 15:26:44 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1hb598-0002yW-Hm for pgadmin-hackers@arkaria.postgresql.org; Wed, 12 Jun 2019 15:26:42 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hb598-0002yP-20 for pgadmin-hackers@lists.postgresql.org; Wed, 12 Jun 2019 15:26:42 +0000 Received: from mx0b-00281601.pphosted.com ([67.231.153.183]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hb594-0001Er-85 for pgadmin-hackers@postgresql.org; Wed, 12 Jun 2019 15:26:40 +0000 Received: from pps.filterd (m0110486.ppops.net [127.0.0.1]) by mx0b-00281601.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x5CFP995010588 for ; Wed, 12 Jun 2019 10:26:36 -0500 Received: from mail-io1-f72.google.com (mail-io1-f72.google.com [209.85.166.72]) by mx0b-00281601.pphosted.com with ESMTP id 2t2mbk0xyd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Wed, 12 Jun 2019 10:26:36 -0500 Received: by mail-io1-f72.google.com with SMTP id f22so12611387ioh.22 for ; Wed, 12 Jun 2019 08:26:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enova.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ATomKgWqmoQSKYCN/Qpvq670vJUU0+2yw2DsqCCzi48=; b=Lf6O7V1J46NXro9sQKiSilLW4dU/CKpC5Odo2VaQr8YhqMbYYkOq6et6dlkS5WcomQ k47EoYaEWwOCC9gf2JSUMRyP73iH8OB7JIq7Os5rJuF+X+ceAMw8U3ks3YsUZtKfoIdQ FF4tvohr4NtagoP5qAeURq8Df2+MWRhy8AGYM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ATomKgWqmoQSKYCN/Qpvq670vJUU0+2yw2DsqCCzi48=; b=hxga0oLOdu62MxP42VVx6OgcpLrAATPYIKNgexbYT5wDZ+jgl1WJWFZYwkBXMCIq2D u1i2f+sY2R+Wxqeh3og9PQXuWjZIjThBuPfaCOnDCNiTimZTv6UVvbvWFGRQlYnc1Imq lnt5IOXn/D+7xtLAio5OanlzuEy/Y9p47Eqt1o9/6W/FCqf1PQ0bxwcClXUbdl12el6y LYb0AqTctFzN2GMwdiaZ2e4bsQ0nR/uuY5tyqT4pLNBINniFuDqBYMToQ601DmFO0zfC AxVgiftL1e6HNS3radQyDZxzUBmqvCbRp+WSc0SGiH/6rlMZqlQjBElVPU8sVnJpXOny D6sQ== X-Gm-Message-State: APjAAAWd8NctFxWfdIpPpfRowwfQN3V1obNbt7DS0KcjSyoDjLgbg8PH mnU09U7z6aoiCoLL/Rt7UBi3OyO+ObLATxlIwjC7bNDxGCVTMA2K3L8RH613iOkxiyke2uKnx0W KZFpnHzntvBVC3nCKyJTiAvdsinNi24GUEs/v2Hcb/Ws= X-Received: by 2002:a24:b8c2:: with SMTP id m185mr22032324ite.0.1560353195113; Wed, 12 Jun 2019 08:26:35 -0700 (PDT) X-Google-Smtp-Source: APXvYqy4D5V/13ihlRqLhwxGgK+XnSt9QGtnHD8FN5ypW15Rr+BXP6JklCWRDN9LBqcqrL88co9Wjl+EI7jbLYo7NBA= X-Received: by 2002:a24:b8c2:: with SMTP id m185mr22032302ite.0.1560353194858; Wed, 12 Jun 2019 08:26:34 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: "Strauch, Sheldon" Date: Wed, 12 Jun 2019 10:26:23 -0500 Message-ID: Subject: Re: [pgAdmin][RM3782] Debugger title should show connection and object details To: Dave Page Cc: Aditya Toshniwal , pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000e77cca058b22097f" X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-06-12_09:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=476 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1906120103 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000e77cca058b22097f Content-Type: text/plain; charset="UTF-8" FWIW: - +1 for INDEPENDENTLY configurable tab title AND tooltip - I agree that in-place edit of tabs cost/benefit isn't there, unless someone wants a personal free-time project On Wed, Jun 12, 2019 at 4:44 AM Dave Page wrote: > Hi > > On Wed, Jun 12, 2019 at 10:02 AM Aditya Toshniwal < > aditya.toshniwal@enterprisedb.com> wrote: > >> Hi, >> >> On Wed, Jun 12, 2019 at 1:54 PM Dave Page wrote: >> >>> Hi >>> >>> On Wed, Jun 12, 2019 at 7:03 AM Aditya Toshniwal < >>> aditya.toshniwal@enterprisedb.com> wrote: >>> >>>> Hi Hackers, >>>> >>>> Attached is the patch to add more information on connection details to >>>> debugger panel title and content title similar to Query Tool and View/Edit >>>> data. >>>> Adding the object name with arguments is not a good idea for the panel >>>> title, so I have kept to connection details similar to query tool. The >>>> content title will have all the details. >>>> >>>> Kindly review. >>>> >>> >>> I think not having the function name in there is a big limitation. >>> >>> With all this hacking going on, I think what we need to do is stop and >>> make this configurable as has been both requested by users and suggested by >>> us. >>> >>> I propose adding 2 preference options for each tab type. Each of these >>> would be a string with placeholders, one for the tab title, and one for the >>> tab tooltip. For example: >>> >>> - Query Tool >>> * Placeholders: %DATABASE%, %SERVER%, %USERNAME%, %PORT%, %HOST% >>> * Tab title default: %DATABASE% on %SERVER% >>> * Tooltip title default: Query Tool: %DATABASE% on %USERNAME%@%SERVER% >>> >>> - View Data >>> * Placeholders: %TABLE%, %SCHEMA%, %DATABASE%, %SERVER%, %USERNAME%, >>> %PORT%, %HOST% >>> * Tab title default: %SCHEMA%.%TABLE% in %DATABASE% on %SERVER% >>> * Tooltip title default: View/Edit Data: %SCHEMA%.%TABLE% >>> in %DATABASE% on %USERNAME%@%SERVER% >>> >>> - Script >>> * Placeholders: %ACTION%, %OBJECT%, %SCHEMA%, %DATABASE%, %SERVER%, >>> %USERNAME%, %PORT%, %HOST% >>> * Tab title default: %ACTION% %SCHEMA%.%OBJECT% in %DATABASE% on >>> %SERVER% >>> * Tooltip title default: %ACTION% Script: %SCHEMA%.%OBJECT% >>> in %DATABASE% on %USERNAME%@%SERVER% >>> >>> - Debugger >>> * Placeholders: %FUNCTION_ARGS%, %FUNCTION_NOARGS%, %SCHEMA%, >>> %DATABASE%, %SERVER%, %USERNAME%, %PORT%, %HOST% >>> * Tab title default: %FUNCTION_NOARGS%.%OBJECT% in %DATABASE% on >>> %SERVER% >>> * Tooltip title default: Debugger: %SCHEMA%.%FUNCTION_ARGS% >>> in %DATABASE% on %USERNAME%@%SERVER% >>> >>> Or something like that. Thoughts? >>> >> Yes, this could be a nice feature. I think tooltip title customisation is >> not needed, we can just set it as prefix + tab title. >> > > I think having it be separate is useful - you can include full information > there, but keep the tab minimal so as not to create huge tabs. For example, > the debugger tab could just be set to %FUNCTION_NOARGS%, whilst the tooltip > has the full string. > > >> Some users asked for in-place rename of tab title. I'm not sure if it is >> feasible to implement, but should we consider it also ? >> > > No - I've only seen one request for that, and it seems like a lot of work > for little gain. > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > > The Enterprise PostgreSQL Company > -- Look after your data, and your database will look after you. -- Simon Riggs Sheldon E. Strauch *Data Architect, Data Services * *O* 312-676-1556 *M* 224-723-3878 *Enova International, Inc.* *This transmission is confidential and may be privileged or proprietary. If you are not the intended recipient, you are not authorized to use the information in this transmission in any way. Please inform the sender immediately if you have received this transmission in error and permanently delete and destroy the original and any copies of the information.* --000000000000e77cca058b22097f Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
FWIW:
  • +1 for INDEPENDENTLY configurable = tab title AND tooltip
  • I agree that in-place edit of tabs cost/benef= it isn't there, unless someone wants a personal free-time project
    • <= /ul>

On Wed, Jun 12, 2019 at 4:44 AM Dave Page <dpage@pgadmin.org> wrote:
Hi

On Wed, Jun 12, 2019= at 10:02 AM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wro= te:
Hi,

On Wed, Jun 12, 2019 at 1:54 PM Dave Page <dpage@pgadmin.org> wrote:
Hi
=
On Wed= , Jun 12, 2019 at 7:03 AM Aditya Toshniwal <aditya.toshniwal@enterprisedb.co= m> wrote:
Hi Hackers,=

Attached is the patch to add more informat= ion on connection details to debugger panel title and content title similar= to Query Tool and View/Edit data.
Adding the object name with arguments is not a good=C2=A0idea fo= r the panel title, so I have kept to connection details similar to query to= ol. The content title will have all the details.

<= div style=3D"font-family:verdana,sans-serif">Kindly review.

I think not having the function na= me in there is a big limitation.

With all this hac= king going on, I think what we need to do is stop and make this configurabl= e as has been both requested by users and suggested by us.

I propose adding 2 preference options for each tab type. Each of t= hese would be a string with placeholders, one for the tab title, and one fo= r the tab tooltip. For example:

- Query Tool
=
=C2=A0 * Placeholders: %DATABASE%, %SERVER%, %USERNAME%, %PORT%, %HOST= %
=C2=A0 * Tab title default: %DATABASE% on %SERVER%
= =C2=A0 * Tooltip title default: Query Tool: %DATABASE% on %USERNAME%@%SERVE= R%

- View Data
=C2=A0 * Placeholder= s: %TABLE%, %SCHEMA%, %DATABASE%, %SERVER%, %USERNAME%, %PORT%, %HOST%
=C2=A0 * Tab title default: %SCHEMA%.%TABLE% in %DATABASE% on %SERVER= %
=C2=A0 * Tooltip title default: View/Edit Data: %SCHEMA%.%TABLE= % in=C2=A0%DATABASE% on %USERNAME%@%SERVER%

= - Script
=C2=A0 * Placeholders: %ACTION%, %OBJECT%, %SCHEMA%= , %DATABASE%, %SERVER%, %USERNAME%, %PORT%, %HOST%
=C2=A0 * Tab t= itle default: %ACTION% %SCHEMA%.%OBJECT% in %DATABASE% on %SERVER%
=C2=A0 * Tooltip title default: %ACTION% Script: %SCHEMA%.%OBJECT% in=C2= =A0%DATABASE% on %USERNAME%@%SERVER%

- Debug= ger
=C2=A0 * Placeholders: %FUNCTION_ARGS%, %FUNCTION_NOARGS= %, %SCHEMA%, %DATABASE%, %SERVER%, %USERNAME%, %PORT%, %HOST%
=C2= =A0 * Tab title default: %FUNCTION_NOARGS%.%OBJECT% in %DATABASE% on %SERVE= R%
=C2=A0 * Tooltip title default: Debugger: %SCHEMA%.%FUNCTION_A= RGS% in=C2=A0%DATABASE% on %USERNAME%@%SERVER%

Or something like that. Thoughts?
Yes, this cou= ld be a nice feature. I think tooltip title customisation is not needed, we= can just set it as=C2=A0 prefix=C2=A0+ tab title.

I think having it be separate is useful -= you can include full information there, but keep the tab minimal so as not= to create huge tabs. For example, the debugger tab could just be set to %F= UNCTION_NOARGS%, whilst the tooltip has the full string.
=C2=A0
Some users asked for in-place rename of tab title. = I'm not sure if it is feasible to implement, but should we consider it = also ?

No - I'= ve only seen one request for that, and it seems like a lot of work for litt= le gain.
=C2=A0
--
Dave Page
Blog: = http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK= : http://www.enterprisedb.com
The Enterprise Postgre= SQL Company


--

Look after your data, and your datab= ase will look after you. -- Simon Riggs

Sheldon E. Stra= uch
Data Architect, Data Services=C2=A0
O=C2=A0312-676-1556
M=C2=A0224-723-3878

<= p><= /span>

= Enova International, Inc.
This transmission is confidential and may be privileged or proprietary. If you a= re not the intended recipient, you are not authorized to use the information i= n this transmission in any way. Please inform the sender immediately if you h= ave received this transmission in error and permanently delete and destroy the original and any copies of the information.=C2=A0 =C2=A0=C2=A0
<= /div>
--000000000000e77cca058b22097f--