Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.80) (envelope-from ) id 1Zkz9R-0005mH-UG for pgadmin-hackers@arkaria.postgresql.org; Sat, 10 Oct 2015 18:45:50 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84) (envelope-from ) id 1Zkz9Q-0006r7-5C for pgadmin-hackers@arkaria.postgresql.org; Sat, 10 Oct 2015 18:45:48 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84) (envelope-from ) id 1Zkz9P-0006q6-J7 for pgadmin-hackers@postgresql.org; Sat, 10 Oct 2015 18:45:47 +0000 Received: from mail-wi0-x22e.google.com ([2a00:1450:400c:c05::22e]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84) (envelope-from ) id 1Zkz9L-0000S1-Tv for pgadmin-hackers@postgresql.org; Sat, 10 Oct 2015 18:45:47 +0000 Received: by wiclk2 with SMTP id lk2so107878903wic.0 for ; Sat, 10 Oct 2015 11:45:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :content-type; bh=nialKoQPjzuDQZYZ4pMBuEwXH2f1A1ZRGkBBoMFi7co=; b=yt6e/we7pHuLyQbUZGJ7P1lzdu9Cp1U7QutmGpg9f53YnsU/wt14g4QsjKl2UPK43f XhNi5HZxdLor+mP/pyPqmulUomAM4UyAlaE00YZwLfVaqfqCVhZpqwdkw0tvaIIaWXe7 2narvfYZJoZz/lRip1jGjyAAzjluBV2KWAwJtV2xn9VN+cJ6f/wJn0qrm0bMoryXGFVz LZOEiE8S0o0OgUsCyUTZZaygrvHfxwJSJxVKChMtdLlNnDPCXcbI1UcAhO2YMOHvzO+D ojsbMpT57q5tLtR59YfVTMT9X1WpkaldqYwqy40YKhZy5bS2Wvgh8TQc0cYfp2hu71ZE F7PA== X-Received: by 10.194.250.40 with SMTP id yz8mr24912931wjc.37.1444502741750; Sat, 10 Oct 2015 11:45:41 -0700 (PDT) MIME-Version: 1.0 Received: by 10.27.204.136 with HTTP; Sat, 10 Oct 2015 11:45:22 -0700 (PDT) In-Reply-To: <4A470437-1E4F-47E1-ACC8-D42491F5BB31@pgadmin.org> References: <561568BC.5070200@yandex.ru> <561905AB.8020801@yandex.ru> <4A470437-1E4F-47E1-ACC8-D42491F5BB31@pgadmin.org> From: Szabolcs Hubai Date: Sat, 10 Oct 2015 20:45:22 +0200 Message-ID: Subject: Re: [PATCH] Beautify line-ends handling yet more. To: pgadmin-hackers@postgresql.org Content-Type: text/plain; charset=UTF-8 X-Pg-Spam-Score: -2.7 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org As an alternative solution you could do it as Notepad++ does: Unix/Mac, DOS/Windows, old Mac. 2015-10-10 15:51 GMT+02:00 Dave Page : > > >> On 10 Oct 2015, at 13:33, Nikolai Zhubr wrote: >> >> Hello Dave, >> 09.10.2015 16:31, Dave Page wrote: >> [...] >>> I committed a modified version of this - Mac OS X uses \n as a >>> line-end, so that makes a better default than the old-style \r used on >>> Mac classic. >> >> Ah, I didn't know that, thanks for explanation. >> >> I suppose it is unlikely someone will use current (and future) releases of pgamin3 on Mac classic, therefore I'd propose to also update the corresponding preferences menu. Right now it shows 3 possibilities: >> >> * Unix (LF) >> * DOS (CRLF) >> * Mac (CR) >> >> Maybe it would make sense to only provide 2 with the following naming: >> >> * Unix/Mac (LF) >> * DOS/Windows (CRLF) >> >> If it is OK then I'll craft a git diff for that (eventually). > > I'm not sure we should - it may be useful for someone working with legacy systems, and it's not like it's a massive amount of code bloating the app or overly complicating the UI. > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers