Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.80) (envelope-from ) id 1Zecm1-0000lQ-Uo for pgadmin-hackers@arkaria.postgresql.org; Wed, 23 Sep 2015 05:39:22 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84) (envelope-from ) id 1Zecm0-0001iF-V3 for pgadmin-hackers@arkaria.postgresql.org; Wed, 23 Sep 2015 05:39:20 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84) (envelope-from ) id 1Zecln-0001Tk-Fm for pgadmin-hackers@postgresql.org; Wed, 23 Sep 2015 05:39:07 +0000 Received: from mail-ig0-x229.google.com ([2607:f8b0:4001:c05::229]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84) (envelope-from ) id 1Zecli-0005nz-Ej for pgadmin-hackers@postgresql.org; Wed, 23 Sep 2015 05:39:06 +0000 Received: by igcrk20 with SMTP id rk20so94228606igc.1 for ; Tue, 22 Sep 2015 22:39:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=3V3qu8msQGQVvRi0IFA/RaAst05D83uLMFWhgVH+gps=; b=WvtBu8Bnq0Kbuch5CcyOOBvV0O+MGsTeQ8/4pnsfe0LLx4A63TV3djOjgKGYb4k6Mb 5LLXB9kLO7/1PBRXjHUKp9rtKWD+PqDLwI8/v6AwGXQ5LKWO9461byWKXZARnxZqeBsX 6NBBHxQou1cB/2y9KQMKtFJLIn7knIu/miOIs2r/tEf0TbkwSxiyKXaim0IeybtChcLa Vj1TFsShGeCZae4bn1lWv30T+zbnRfckV69yKSByTls3MhLOCiFKjxzcTGQoKO8cdky9 ggX+m2PLk0JnEYpURhYbILywgfXcynfkNQzQrLMQ0rO2pCnvp+iT0JUdGA6JPhfAzfro TgAw== MIME-Version: 1.0 X-Received: by 10.50.77.15 with SMTP id o15mr22535271igw.5.1442986740010; Tue, 22 Sep 2015 22:39:00 -0700 (PDT) Received: by 10.36.155.3 with HTTP; Tue, 22 Sep 2015 22:38:59 -0700 (PDT) In-Reply-To: References: Date: Wed, 23 Sep 2015 07:38:59 +0200 Message-ID: Subject: Re: [PATCH] Add Commit/Rollback toolbar action version 2 From: John Obaterspok To: Sanket Mehta Cc: Ashesh Vashi , pgadmin-hackers Content-Type: multipart/alternative; boundary=047d7bdc09e20dd5930520638829 X-Pg-Spam-Score: -2.7 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --047d7bdc09e20dd5930520638829 Content-Type: text/plain; charset=UTF-8 Hi Sanket, Did you give the patch a try? I would really like it to for the next release :) -- john 2015-09-16 20:27 GMT+02:00 John Obaterspok : > Hi Sanket, > > Attached patch is rebased now. > > Regards, > > -- john > > > 2015-09-16 11:20 GMT+02:00 Sanket Mehta : > >> Hi John, >> >> Patch is not proper. >> I got below error when I try to apply the patch: >> >> error: patch failed: pgadmin/frm/frmQuery.cpp:2435 >> error: pgadmin/frm/frmQuery.cpp: patch does not apply >> >> Please do provide the proper patch. >> >> >> Regards, >> Sanket Mehta >> Sr Software engineer >> Enterprisedb >> >> On Mon, Sep 14, 2015 at 10:51 AM, Sanket Mehta < >> sanket.mehta@enterprisedb.com> wrote: >> >>> Sure Ashesh, >>> >>> I will review the patch. >>> >>> Regards, >>> Sanket Mehta >>> Sr Software engineer >>> Enterprisedb >>> >>> On Mon, Sep 14, 2015 at 1:12 PM, Ashesh Vashi < >>> ashesh.vashi@enterprisedb.com> wrote: >>> >>>> Sanket, >>>> >>>> Can you please take a look at it? >>>> >>>> -- >>>> >>>> Thanks & Regards, >>>> >>>> Ashesh Vashi >>>> EnterpriseDB INDIA: Enterprise PostgreSQL Company >>>> >>>> >>>> >>>> *http://www.linkedin.com/in/asheshvashi* >>>> >>>> >>>> On Mon, Sep 14, 2015 at 1:07 AM, John Obaterspok < >>>> john.obaterspok@gmail.com> wrote: >>>> >>>>> Hello, >>>>> >>>>> I'm updated the patch to add commit/rollback actions in the toolbar >>>>> with the following: >>>>> 1) updated icons (based on existing pgadmin icon with arrows drawn by >>>>> me) >>>>> 2) add entry to menu as well >>>>> 3) disable icons when not in a transaction >>>>> 4) Ctrl+Shift C|R shortcut >>>>> >>>>> Hopefully all issues are resolved now! >>>>> >>>>> Regards, >>>>> >>>>> John >>>>> >>>>> >>>>> >>>>> -- >>>>> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) >>>>> To make changes to your subscription: >>>>> http://www.postgresql.org/mailpref/pgadmin-hackers >>>>> >>>>> >>>> >>> >> > --047d7bdc09e20dd5930520638829 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi Sanket,

Did you give the patch a try= ? I would really like it to for the next release :)

-- john

2015-09-16 20:27 GMT+02:00 John Obaterspok <john.obaterspok@gm= ail.com>:
= Hi Sanket,

Attached patch is rebased now.

=
Regards,

-- john
=C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0=C2=A0

2015-09-1= 6 11:20 GMT+02:00 Sanket Mehta <sanket.mehta@enterprisedb.com<= /a>>:
Hi John,

Patch is not proper.
I got below erro= r when I try to apply the patch:

error: patch failed: pgadmin/frm/fr= mQuery.cpp:2435
error: pgadmin/frm/frmQuery.cpp: patch does not apply
Please do provide the proper patch.
=C2=A0

Regard= s,
Sanket Mehta
Sr Software engineer
Enterprisedb

On Mon, Sep 14, 2015 at 10:= 51 AM, Sanket Mehta <sanket.mehta@enterprisedb.com> wrote:
Sure Ashesh,<= div>
I will review the patch.

Regards,
Sanket Meh= ta
Sr Software engineer
Enterprisedb
<= /div>

On Mon, Sep 14, 2015 at 1:12 PM, Ashesh Vash= i <ashesh.vashi@enterprisedb.com> wrote:
Sanket,

Can y= ou please take a look at it?

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company

<= br>

<= a href=3D"http://www.linkedin.com/in/asheshvashi" target=3D"_blank">http= ://www.linkedin.com/in/asheshvashi


On Mon, Sep 14, 2015 at 1:07 AM, J= ohn Obaterspok <john.obaterspok@gmail.com> wrote:
Hell= o,

I'm updated the patch to add commit/rollback acti= ons in the toolbar with the following:
1) updated icons (based on exist= ing pgadmin icon with arrows drawn by me)
2) add entry to menu as= well
3) disable icons when not in a transaction
4)= Ctrl+Shift C|R shortcut

Hopefully all issues are = resolved now!

Regards,

= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 John



--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers=






--047d7bdc09e20dd5930520638829--