MIME-Version: 1.0
In-Reply-To: 
 <CAG7mmoxXB0DsLZyvZ7qevoG17x7bJyw2DWdd0SXEgFg2Uc993A@mail.gmail.com>
References: 
 <CAPCETpsrtBXjssDorG4fc+DZWqcF6U_WWCTtdUFAcMmUFkwkSw@mail.gmail.com>
 <CAG7mmoxXB0DsLZyvZ7qevoG17x7bJyw2DWdd0SXEgFg2Uc993A@mail.gmail.com>
From: Rob Emery <re-pgsql@codeweavers.net>
Date: Mon, 11 Jun 2018 08:20:19 +0100
Message-ID: 
 <CAPCETptE0Ug_qVe6nUOpktQ1MbQSrsR50sRR-ixCW9qa82VMrA@mail.gmail.com>
Subject: Re: PGAgent 4.0 error feedback
To: Ashesh Vashi <ashesh.vashi@enterprisedb.com>
Cc: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/mixed; boundary="0000000000001ef49e056e589552"
Precedence: bulk

--0000000000001ef49e056e589552
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Ashesh,

Log-level wise I was using the same command for both versions:

 ./pgagent -f -l 2 -t 1 -r 1 'hostaddr=3Dserver user=3Dusername
password=3Dpassword dbname=3Dpostgres'

and messing up the connection string in various ways (missing dbname,
incorrect password, incorrect hostaddr)

This was built and tested on  Debian GNU/Linux 9.4 (stretch).

I've attached an example of the differing output when the dbname is missing
from the connectionstring; basically it's the same for all errors.

Many Thanks,
Rob

On 11/06/2018, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
> Hi Rob,
>
> On Sun, Jun 10, 2018 at 2:26 AM, Rob Emery <re-pgsql@codeweavers.net>
> wrote:
>
>> Hi Guys,
>>
>> I've been testing out PGAgent 4 (build today from master at commit
>> 86ca5c5ed1ad572075ba27e05e4680ebdf5b9feb) to check the connection
>> handling on error is still fixed with the boost reimplementation
>> (which it is!)
>> and noticed a few issues compared to PGAgent 3 around feedback to the
>> user if the connection string is incorrect.
>>
>> I've tested with incorrect username and password, user not in the hba,
>> db doesn't exist, postgresql not running on the host (or incorrect
>> hostaddr) and 4 seems to always returns the error :
>> `
>> ERROR: Couldn't find the function 'pgagent_schema_version' - please
>> run pgagent_upgrade.sql.
>> `
>>
>> whereas 3.4.1 tends to output from the pgconnection itself like:
>> `
>> Sat Jun  9 21:32:13 2018 : WARNING: Couldn't create the primary
>> connection (attempt 1): FATAL:  no pg_hba.conf entry for host
>> "172.30.0.16", user "pgagent_login_role", database
>> "pgagent_login_role", SSL on
>> FATAL:  no pg_hba.conf entry for host "172.30.0.16", user
>> "pgagent_login_role", database "pgagent_login_role", SSL off
>> `
>>
>> which at least points the user towards the actual error!
>>
>> Not sure if this is known already, but I thought I'd raise it prior to
>> release.
>>
> Thanks for sharing the information.
>
> Is it possible for you to share the logs with log level set to debug?
> Also - please share the operating system details?
>
> --
>
> Thanks & Regards,
>
> Ashesh Vashi
> EnterpriseDB INDIA: Enterprise PostgreSQL Company
> <http://www.enterprisedb.com/>
>
>
> *http://www.linkedin.com/in/asheshvashi*
> <http://www.linkedin.com/in/asheshvashi>
>
>
>
>>
>> Thanks,
>> Rob
>> --
>>
>> --
>>  <https://codeweavers.net>
>>
>>
>> Codeweavers May Newsletter
>> <https://mailchi.mp/codeweavers/march-edition-336883>  l  Codeweavers
>> April
>> Finance Trends
>> <https://codeweavers.net/company-blog/codeweavers-april-finance-trends>
>>
>>
>> April=E2=80=99s Dealer Highlights
>> <https://codeweavers.net/company-blog/aprils-dealer-highlights>
>> <https://codeweavers.net/company-blog/codeweavers-march-car-finance-tren=
ds
>> >
>>
>> _
>> _
>>
>>
>>
>> *Phone:* 0800 021 0888   Email: contactus@codeweavers.net
>> <mailto:contactus@codeweavers.net>
>> Codeweavers Ltd | Barn 4 | Dunston
>> Business Village | Dunston | ST18 9AB
>> Registered in England and Wales No.
>> 04092394 | VAT registration no. 974 9705 63
>>
>>
>>
>>
>> <https://www.linkedin.com/company/codeweavers-limited>
>> <https://vimeo.com/codeweaversltd>
>> <https://plus.google.com/b/105942302039373248738/+CodeweaversNet>
>> <https://twitter.com/CodeweaversTeam>
>>
>>
>>
>

--=20
 <https://codeweavers.net>


Codeweavers May Newsletter=20
<https://mailchi.mp/codeweavers/march-edition-336883>=C2=A0=C2=A0l=C2=A0 Co=
deweavers April=20
Finance Trends=20
<https://codeweavers.net/company-blog/codeweavers-april-finance-trends>


April=E2=80=99s Dealer Highlights=20
<https://codeweavers.net/company-blog/aprils-dealer-highlights>=20
<https://codeweavers.net/company-blog/codeweavers-march-car-finance-trends>

_
_


*Phone:*=C2=A00800 021 0888=C2=A0=C2=A0=C2=A0Email:=C2=A0contactus@codeweav=
ers.net=20
<mailto:contactus@codeweavers.net>
Codeweavers Ltd=C2=A0| Barn 4 | Dunston=20
Business Village | Dunston | ST18 9AB
Registered in England and Wales No.=20
04092394 | VAT registration no. 974 9705 63=C2=A0


=20
<https://www.linkedin.com/company/codeweavers-limited>=C2=A0=C2=A0=20
<https://vimeo.com/codeweaversltd>=C2=A0=C2=A0=20
<https://plus.google.com/b/105942302039373248738/+CodeweaversNet>=C2=A0=C2=
=A0=20
<https://twitter.com/CodeweaversTeam>


--0000000000001ef49e056e589552
Content-Type: text/plain; charset="US-ASCII";
 name="PGagent-BrokenConnectionString.txt"
Content-Disposition: attachment;
	filename="PGagent-BrokenConnectionString.txt"
Content-Transfer-Encoding: base64
X-Attachment-Id: file0

cm9iQElTSVM6fi9wZ2FnZW50LWdpdC1idWlsZCQgLi9wZ2FnZW50IC1mICdob3N0YWRkcj0xNzIu
MzAuMC4xNiB1c2VyPXBnYWdlbnRfbG9naW5fcm9sZSBwYXNzd29yZD1wYXNzd29yZCcNCk1vbiBK
dW4gMTEgMDg6MTc6NDkgMjAxOCBFUlJPUjogQ291bGRuJ3QgZmluZCB0aGUgZnVuY3Rpb24gJ3Bn
YWdlbnRfc2NoZW1hX3ZlcnNpb24nIC0gcGxlYXNlIHJ1biBwZ2FnZW50X3VwZ3JhZGUuc3FsLg0K
DQpyb2JASVNJUzp+L3BnYWdlbnQtMy40LjEtYnVpbGQkIC4vcGdhZ2VudCAtZiAnaG9zdGFkZHI9
MTcyLjMwLjAuMTYgdXNlcj1wZ2FnZW50X2xvZ2luX3JvbGUgcGFzc3dvcmQ9cGFzc3dvcmQnDQpN
b24gSnVuIDExIDA4OjE4OjAxIDIwMTggOiBXQVJOSU5HOiBDb3VsZG4ndCBjcmVhdGUgdGhlIHBy
aW1hcnkgY29ubmVjdGlvbiAoYXR0ZW1wdCAxKTogY291bGQgbm90IGNvbm5lY3QgdG8gc2VydmVy
OiBDb25uZWN0aW9uIHJlZnVzZWQNCiAgICAgICAgSXMgdGhlIHNlcnZlciBydW5uaW5nIG9uIGhv
c3QgIjE3Mi4zMC4wLjE2IiBhbmQgYWNjZXB0aW5nDQogICAgICAgIFRDUC9JUCBjb25uZWN0aW9u
cyBvbiBwb3J0IDU0MzI/DQo=
--0000000000001ef49e056e589552--