MIME-Version: 1.0
References: 
 <CAPG3WN6-gARPJ_pDGZzzxv=2wRN-GcFa2+9CmruKLgmw8sM1Lg@mail.gmail.com>
 <CA+OCxozO9NuT33X9L2MBju6prBr7ZdoktdivAR6Z=EYERY52bg@mail.gmail.com>
In-Reply-To: 
 <CA+OCxozO9NuT33X9L2MBju6prBr7ZdoktdivAR6Z=EYERY52bg@mail.gmail.com>
From: Shirley Wang <swang@pivotal.io>
Date: Thu, 08 Jun 2017 14:41:57 +0000
Message-ID: 
 <CAPG3WN50HsP81rnPS63m3TcmWtFT0fqufXdK4EHBU=TW-9d11A@mail.gmail.com>
Subject: Re: Style guide live website - looking for feedback
To: Dave Page <dpage@pgadmin.org>
Cc: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary="94eb2c04f46868390a055173dbe3"
Precedence: bulk
Sender: pgadmin-hackers-owner@postgresql.org

--94eb2c04f46868390a055173dbe3
Content-Type: text/plain; charset="UTF-8"

>
>
> Looks good. A couple of thoughts:
>
> - Please use "pgAdmin 4" consistently :-)
>
> Just to clarify - is there always a space between pgAdmin and 4? or is it
pgAdmin4?


> - The neutral message panel has a border that is quite visible, whilst
> the others have much more subtle borders. Seems like something to fix.
>

It is an interesting contrast. I think it should be changed too.

>
> - I think we need some notes on when the different font sizes should be
> used.
>
> Ok. I can start documenting where these fonts are used now, and then we
can think about if that's how we actually want to use them.


> - You've obviously created classes for these styles (e.g. text-14).
> Let's make sure they are all actually defined in the stylesheets for
> the app before we add the style guide :-)
>
> Will do.


> Thanks!
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

--94eb2c04f46868390a055173dbe3
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div class=3D"gmail_quote"><blockquote class=3D"gmail_quot=
e" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">=
<br>
Looks good. A couple of thoughts:<br>
<br>
- Please use &quot;pgAdmin 4&quot; consistently :-)<br>
<br></blockquote><div>Just to clarify - is there always a space between pgA=
dmin and 4? or is it pgAdmin4?=C2=A0</div><div>=C2=A0</div><blockquote clas=
s=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;pad=
ding-left:1ex">
- The neutral message panel has a border that is quite visible, whilst<br>
the others have much more subtle borders. Seems like something to fix.<br><=
/blockquote><div><br></div><div>It is an interesting contrast. I think it s=
hould be changed too.=C2=A0</div><blockquote class=3D"gmail_quote" style=3D=
"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
- I think we need some notes on when the different font sizes should be use=
d.<br>
<br></blockquote><div>Ok. I can start documenting where these fonts are use=
d now, and then we can think about if that&#39;s how we actually want to us=
e them.</div><div>=C2=A0</div><blockquote class=3D"gmail_quote" style=3D"ma=
rgin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
- You&#39;ve obviously created classes for these styles (e.g. text-14).<br>
Let&#39;s make sure they are all actually defined in the stylesheets for<br=
>
the app before we add the style guide :-)<br>
<br></blockquote><div>Will do.=C2=A0</div><div>=C2=A0</div><blockquote clas=
s=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;pad=
ding-left:1ex">
Thanks!<br>
<br>
--<br>
Dave Page<br>
Blog: <a href=3D"http://pgsnake.blogspot.com" rel=3D"noreferrer" target=3D"=
_blank">http://pgsnake.blogspot.com</a><br>
Twitter: @pgsnake<br>
<br>
EnterpriseDB UK: <a href=3D"http://www.enterprisedb.com" rel=3D"noreferrer"=
 target=3D"_blank">http://www.enterprisedb.com</a><br>
The Enterprise PostgreSQL Company<br>
</blockquote></div></div>

--94eb2c04f46868390a055173dbe3--