public inbox for [email protected]
help / color / mirror / Atom feedFrom: Shirley Wang <[email protected]>
To: Ashesh Vashi <[email protected]>
Cc: Robert Eckhardt <[email protected]>
Cc: Akshay Joshi <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Cc: Dave Page <[email protected]>
Subject: Re: Declarative partitioning in pgAdmin4
Date: Wed, 14 Jun 2017 22:20:51 +0000
Message-ID: <CAPG3WN7w4LeN8unYdOP_E_1j6yixsJ88BFOEehyxzqVYuDyOFw@mail.gmail.com> (raw)
In-Reply-To: <CAG7mmozmpra=-WebHe-qWOXp3Tx-W4tLkbXgeSbV5+nuky+Cpw@mail.gmail.com>
References: <CANxoLDcZND0pjXtrDKRip2xjddzjWiMgY2AMmrqqFE_Yu4+tHw@mail.gmail.com>
<CA+OCxowUuaNRX9jHmEVFpqT7JCbjn6vaxw+JJ6yrvVp69FZscg@mail.gmail.com>
<CAPG3WN5NY-Xsa_+6HUQ3NMU_n7jRgJ8L6rjHfyzSLSHS=zZC0Q@mail.gmail.com>
<CA+OCxoy1v+mq2P4ZL2v7mmyHmjwQmL=v8RR8CSRra_SV96nJDQ@mail.gmail.com>
<CANxoLDeBGRmq_kUUNNySXimzJO2Ebj0aQBdjNM+0JvP3_Yr9Dw@mail.gmail.com>
<CAAtBm9Ve2FX4_jY9tv11UqK2BhNoLn118aeT4y=TieSAovL+AA@mail.gmail.com>
<CA+OCxozkEdTmVUtJEBdHT97EbiUK_+cwW+rv21tuHyxSnN3HOg@mail.gmail.com>
<CAAtBm9UHyp+bkxcyYL+1qb9knps_cdh6N0tvwMy5uY-eVjWcPg@mail.gmail.com>
<CANxoLDdgp46uAZzda+cHBn16YibodXgtyH7O1hp39TKT=cv_ig@mail.gmail.com>
<CA+OCxowpGBLT1q2DzL9VpRG5So8zYssP9SAdd=3Mc6dk8_-p7A@mail.gmail.com>
<CANxoLDdP945GEfzeYaPjO41D4VoRN2kDMVhHZCOqCXWKegSEHw@mail.gmail.com>
<CA+OCxowCzLAFybtfnsay9NB0BFORP5yXiitruxh9tvMoADNKRQ@mail.gmail.com>
<CANxoLDcqudMZ5j-30EcFEL9KpQxyvrMWo0mVrWdg0p6_8e7peQ@mail.gmail.com>
<CA+OCxow5pXNkDxrL1dbWbheJjpSseefSdvUs5tiwx7k5o3vB7Q@mail.gmail.com>
<CANxoLDeNovspn8mm0XuYh+F2ShGotwRCAikU5JY9qF1GgFQ9rg@mail.gmail.com>
<CA+OCxowtH1WJpXA1MKSLrzx_qbKAA36GTEk1t5=3VAS8fegBiA@mail.gmail.com>
<CANxoLDeLHGvz0NxH_MM7dCe0muA8Sxe54V65b18iHTAESzt97g@mail.gmail.com>
<CANxoLDeuXKCqrdNwiBut5m7FKQwzRjbPrqR6wHf8qKqgLDnwgQ@mail.gmail.com>
<CAPG3WN4tiMGoFadBZ9KjB8NfNDVfvDnfUHhS=aya5A0o-jZ3Xw@mail.gmail.com>
<CANxoLDfN_RvNc0AsVCtrDC-03L53crHzE8JZjmxna3f08KWVqw@mail.gmail.com>
<CAPG3WN5QA88fNmY4jZZhBY+HUn2FAKecHuvyFjnq2x_vGu4_0w@mail.gmail.com>
<CANxoLDfjy6sWQVHy5m5Rj1R5_=x_XwPzz6Mndj3xXfnEYpU_zg@mail.gmail.com>
<CAPG3WN7haKwrQzrgVh7JSunGcP9_6wj=_q_C9J-yYgsZbhWmEw@mail.gmail.com>
<CANxoLDeZ-izo=RSaHRnFNaAAQjxhd9-x6stx5FyLYU2ZA3A3vA@mail.gmail.com>
<CAPG3WN6sKefWWYfg9A5=f-QOO9HAsg7krsuQ6FZwvojEuvSjCA@mail.gmail.com>
<CAAtBm9Xw0qpvqRUb87AoSDdu56iaS8TaoVym3KkBJGjOgLU8cA@mail.gmail.com>
<CANxoLDegWFzkbUi=8KSL-3cPb0masCjD1HwxaMDhV6fs2uOObw@mail.gmail.com>
<CAAtBm9VpHahO2pbPM_ATowUU-YLT--RwWHmvW1Q+BtUGiCetyA@mail.gmail.com>
<CANxoLDc53XkKDO=8FHG1i7KnvPCCiR2-1DjCTQoV9_K4Z11pRQ@mail.gmail.com>
<CA+OCxoyEAPAra-nkS4qPVYEk3hHyVfRN-FQFPRfjSPrshwhsUg@mail.gmail.com>
<CAPG3WN72DS8gQmrFR_nBObYaeMaxiqVuyjsVqHaZR1BT4LDqHg@mail.gmail.com>
<CA+OCxozRODSQ9mdLnJWq4cbgHthQ9EqE7AE80kLbi6YPHBQMYg@mail.gmail.com>
<CAAtBm9Ua5WMPnXRb87Dr3+FMeuaSWsHSgpYX8AB=TS+PF63pPw@mail.gmail.com>
<CA+OCxozEKKgCNL9ng7KegYYeFdTU6hy+TdQFBp80W=Ew4XDesg@mail.gmail.com>
<CAAtBm9V89ndB8ZqU0MPsAsUQ-RMEzbjaG2nFfMmFr1vtaY=v=g@mail.gmail.com>
<CANxoLDeC9e+=ESBzoCSQeg4zgxwTz5zGG8HwYs9JNr90x4a-tA@mail.gmail.com>
<CAAtBm9WPFZaeLPUAbZYD3e2d1wyQaP6qUjV-tzEc633Jaguh0w@mail.gmail.com>
<CAPG3WN6QkAONq4zTU=3tUFJo2a61HGuFY0YbkWRrTSOT7sYObA@mail.gmail.com>
<CAPG3WN7aOe=Y2R7qNqHmctZLmwE3eWuqen6Rf7iU-Rq6KeLsUA@mail.gmail.com>
<CAG7mmozmpra=-WebHe-qWOXp3Tx-W4tLkbXgeSbV5+nuky+Cpw@mail.gmail.com>
List-Unsubscribe: <mailto:[email protected]?body=unsub%20pgadmin-hackers>
On Wed, Jun 14, 2017 at 3:42 AM Ashesh Vashi <[email protected]>
wrote:
> Hi Shirley,
>
>
> Please see my reply inline..
> On Wed, Jun 14, 2017 at 5:29 AM, Shirley Wang <[email protected]> wrote:
>
>> Some questions/comments/sketches:
>>
>> - The constraints tab as is implemented now enables constraints for the
>> parent table, correct? If so, and if someone wants to apply constraints to
>> partitions, as I understand it they would need to apply that to each child
>> partition. If that is true, then the tab structure along the top would need
>> to change to show constraints only after child partitions are created to
>> avoid confusion. OR perhaps at the menu level, have an option for creating
>> a partitioned table rather than table.
>>
> Couple of observation about the table constraints:
>
> - PostgreSQL allow to create CHECK constraint on both partition (parent)
> table, and its children partitions.
> - Rest of the constraints may not be applicable on the parent table.
>
> So - the question is: whether we should allow to create constraints for
> the child partitions from the parent node, or not.
>
> If yes - then:
> We will need a switch control (flag) in each of the constraints (in the
> subnode control) to distinguish whether the constraint will be applied on
> parent/child table.
>
> It think - we can also implement bulk triggers, constraints, indexes from
> the parent table, which can be applied to all the children partitions.
> We can give these functionality in the
>
I agree with you, potentially, as long as users are only seeing relevant
info on that screen. For example, if only CHECK constraints work, if a user
is creating a partitioned table they shouldn't be able to see non-working
functionality. And if a user is creating a regular table, they should not
see any additional UI elements that only relate to partitioning,
With what we have now, is there a way to do that gracefully? I feel like
it'll be kind of difficult to navigate, especially with constraints. What
are your thoughts on having 'Create -table' and 'Create-partitioned table'
as two separate options?
>
>> - The steps to create a table with partitions seems to have very clear
>> steps. I think it would benefit from a more 'wizard-like' step by step
>> flow.
>>
> Hmm.
> Are you saying - we should switch to use the Wizard for table creation?
> I think - that should be done in as a separate module.
>
> Any way - we will need to properties dialog for editing the properties of
> an existing partition table.
>
yes definitely. I don't think they need to be separate, the properties
dialog could be a part of 'wizard'. Also, what do you mean by done in a
separate module
Attachments:
[image/jpeg] 05_partitions.jpg (118.6K, 3-05_partitions.jpg)
download | view image
[image/png] 07_partitions.png (702.8K, 4-07_partitions.png)
download | view image
[image/jpeg] 02_general.jpg (145.6K, 5-02_general.jpg)
download | view image
[image/jpeg] 06_partitions.jpg (135.7K, 6-06_partitions.jpg)
download | view image
[image/jpeg] 08_partitions.jpg (163.6K, 7-08_partitions.jpg)
download | view image
[image/jpeg] 09_partitions.jpg (190.5K, 8-09_partitions.jpg)
download | view image
[image/jpeg] 04_columns.jpg (194.9K, 9-04_columns.jpg)
download | view image
view thread (77+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: Declarative partitioning in pgAdmin4
In-Reply-To: <CAPG3WN7w4LeN8unYdOP_E_1j6yixsJ88BFOEehyxzqVYuDyOFw@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox