Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hiExN-0008UV-0d for pgadmin-hackers@arkaria.postgresql.org; Tue, 02 Jul 2019 09:20:09 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1hiExL-0007zj-SN for pgadmin-hackers@arkaria.postgresql.org; Tue, 02 Jul 2019 09:20:07 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hiExL-0007zc-5G for pgadmin-hackers@lists.postgresql.org; Tue, 02 Jul 2019 09:20:07 +0000 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hiExI-0008NK-32 for pgadmin-hackers@postgresql.org; Tue, 02 Jul 2019 09:20:06 +0000 Received: by mail-wr1-x442.google.com with SMTP id x4so16901357wrt.6 for ; Tue, 02 Jul 2019 02:20:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pgadmin.org; s=google; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=H2qf5I6+uk5VaBsb55e+wSKv5NsEbgcCu6tMO11dM7U=; b=QIRbs9JdWgraGfIDrAePrjbK9re4NfTslCQBWExrTXuZJYwTq0CKIr3h4CwH/m1m0L SeBjagMlcrDjvYgZ/Fwoo2LJW1DI0B+NvyJQq89U8iiLT2igcm9LIGoqEHr4eicDnp3i nnogxwT6NqBAEm2Ce/saCunnuiH2iuCYejn0zvH4B63C/hl4Kl0mJi4h1g92SBdS0yRl E81J2D6C73xrRT50Zu43jEr2em3WWBmCApjFhb/3AL0m0UKE2oqLlYJAg7vJEAyDXeI6 ot3TQMwKQHeKZQoLmjInx5AXlwR27h0LzDjHBwCZ1Ejn98ze31xnRUebvrah4PQYXMEh W4Fw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=H2qf5I6+uk5VaBsb55e+wSKv5NsEbgcCu6tMO11dM7U=; b=mVuW8yIVL1cRPkAoMd+rbZk9kfeNsYqe3lVsDPuQYNC5Oo2d5p0g07tlNfxzTstHro D/wqjeGg4mEVbSMohtbc525z8EUQrA60jWRw8ipiGdSLY7FC2zo6O+4Wcq/sJk7vEl/t SPugV9dDkP28yyZejhg5Enn83PQFcygSLR+F5HxuZEnPmjT4b2g2XF4M/rlpvnTK1dJb 6XsnBjrHxvlnri5YZSxcQ01p/LG445irAc32Oblzt3w8BMZgmF5o5if227QEtGiU0Z1s OPGtLqC+yWrLZAlPzykoqDfob8qS3VhqXBORMSWn0tkthoahM0pyS+65+wM72t3AOJ53 hjHw== X-Gm-Message-State: APjAAAXoVSvZrgNoVFJylgoxgYK5IE4HYwjF7QEfKSKlC9Ij82sYfud3 UESRBoJ4PUgATB3TiEGaTOEg+w== X-Google-Smtp-Source: APXvYqyXGiHrxoBbKRBbR8bTQu1+l5P5qFVS7/eiuoMv5XtMiTIAeoj+NtfiuxIeUw2Fwb20Wccz0g== X-Received: by 2002:a5d:4a02:: with SMTP id m2mr17370750wrq.193.1562059202394; Tue, 02 Jul 2019 02:20:02 -0700 (PDT) Received: from ?IPv6:2a01:4c8:1038:27fc:e11f:6f02:c5e4:9a38? ([2a01:4c8:1038:27fc:e11f:6f02:c5e4:9a38]) by smtp.gmail.com with ESMTPSA id s3sm2449630wmh.27.2019.07.02.02.20.01 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 02 Jul 2019 02:20:01 -0700 (PDT) Content-Type: multipart/alternative; boundary=Apple-Mail-17A303AF-A931-41EA-AFB2-0FB4F505DD4A Mime-Version: 1.0 (1.0) Subject: Re: RE-SQL tests for Roles & Resource Group nodes From: Dave Page X-Mailer: iPhone Mail (16F203) In-Reply-To: Date: Tue, 2 Jul 2019 10:20:00 +0100 Cc: pgadmin-hackers Content-Transfer-Encoding: 7bit Message-Id: References: To: Murtuza Zabuawala List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --Apple-Mail-17A303AF-A931-41EA-AFB2-0FB4F505DD4A Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable I think you missed attaching the patch! --=20 Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK:http://www.enterprisedb.com The Enterprise PostgreSQL Company > On 2 Jul 2019, at 08:16, Murtuza Zabuawala wrote: >=20 > Hi Dave, >=20 > Please find the updated patch, >=20 > - Added a mechanism to check for supported minimum/maximum version and a s= erver type in the framework. >=20 > Please review. >=20 >=20 > Thanks, > Murtuza >=20 >> On Mon, Jul 1, 2019 at 7:55 PM Dave Page wrote: >> Hi >>=20 >>> On Mon, Jul 1, 2019 at 6:31 AM Murtuza Zabuawala wrote: >>> Hi, >>>=20 >>> PFA patch to add RE-SQL tests for Roles & Resource Group nodes. >>=20 >> Resource Groups don't exist in PG.... >>=20 >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3DRunning the test cases for 'Regres= sion - PG 11'=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >> runTest (regression.re_sql.tests.test_resql.ReverseEngineeredSQLTestCases= ) >> Reverse Engineered SQL Test Cases >>=20 >> Create IMPLICIT Cast >> Alter IMPLICIT Cast >> Drop IMPLICIT Cast >> Create EXPLICIT Cast >> Alter EXPLICIT Cast >> Drop EXPLICIT Cast >>=20 >>=20 >> Create Resource groups >> ... 2019-07-01 15:24:16,930: ERROR flask.app: Failed to execute q= uery (execute_scalar) for the server #2 - DB:postgres (Query-id: 1562639): >> Error Message:ERROR: syntax error at or near "RESOURCE" >> LINE 1: CREATE RESOURCE GROUP test_resql_resource_group; >> ^ >>=20 >> FAIL >>=20 >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >> FAIL: runTest (regression.re_sql.tests.test_resql.ReverseEngineeredSQLTes= tCases) >> Reverse Engineered SQL Test Cases >> ---------------------------------------------------------------------- >> Traceback (most recent call last): >> File "/Users/dpage/git/pgadmin4/web/regression/re_sql/tests/test_resql.= py", line 88, in runTest >> self.execute_test_case(scenarios) >> File "/Users/dpage/git/pgadmin4/web/regression/re_sql/tests/test_resql.= py", line 145, in execute_test_case >> self.assertEquals(response.status_code, 200) >> AssertionError: 500 !=3D 200 >>=20 >> ---------------------------------------------------------------------- >> Ran 1 test in 0.767s >>=20 >> FAILED (failures=3D1) >>=20 >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >> Test Result Summary >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >>=20 >> Regression - PG 11: >>=20 >> 0 tests passed >> 1 test failed: >> ReverseEngineeredSQLTestCases (Reverse Engineered SQL Test Cases) >> 0 tests skipped >>=20 >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >> =20 >> --=20 >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >>=20 >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company --Apple-Mail-17A303AF-A931-41EA-AFB2-0FB4F505DD4A Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable I think you missed attaching the patch!
=
-- 
Dave Page
Blog: http://pgsnake.bl= ogspot.com
Twitter: @pgsnake

EnterpriseDB UK:http://www.enterprised= b.com
The Enterprise PostgreSQL Company
=
On 2 Jul 2019, at 08:16, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrot= e:

=
Hi Dave,

Please find= the updated patch,

- Added a mechanism to= check for supported minimum/maximum version and a server type in the framew= ork.

Please review.


Thanks,
Murtuza
=
On Mon,= Jul 1, 2019 at 7:55 PM Dave Page <d= page@pgadmin.org> wrote:
Hi

On Mon, Jul 1, 2019 at 6:31= AM Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
<= /div>
Hi,

PFA patch to add RE-SQL tests for Roles & Resource Group nodes.

Resource Groups don't exist in PG.= ...

=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3DRunning the t= est cases for 'Regression - PG 11'=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3DrunTest (regression.re_sql.tests.test_resql.ReverseEngineeredSQLTestCases)<= br>Reverse Engineered SQL Test Cases

Create IMPLICIT Cast
Alter IM= PLICIT Cast
Drop IMPLICIT Cast
Create EXPLICIT Cast
Alter EXPLICIT C= ast
Drop EXPLICIT Cast


Create Resource groups
 ... 201= 9-07-01 15:24:16,930: ERROR flask.app: Failed to execute query (ex= ecute_scalar) for the server #2 - DB:postgres (Query-id: 1562639):
Error M= essage:ERROR:  syntax error at or near "RESOURCE"
LINE 1: CREATE RES= OURCE GROUP test_resql_resource_group;
         =      ^

FAIL

=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D
FAIL: runTest (regression.re_sql.tests.test_resql.Reve= rseEngineeredSQLTestCases)
Reverse Engineered SQL Test Cases
---------= -------------------------------------------------------------
Traceback (= most recent call last):
  File "/Users/dpage/git/pgadmin4/web/regres= sion/re_sql/tests/test_resql.py", line 88, in runTest
    self.= execute_test_case(scenarios)
  File "/Users/dpage/git/pgadmin4/web/r= egression/re_sql/tests/test_resql.py", line 145, in execute_test_case
&nb= sp;   self.assertEquals(response.status_code, 200)
AssertionError: 5= 00 !=3D 200

---------------------------------------------------------= -------------
Ran 1 test in 0.767s

FAILED (failures=3D1)

=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
Test Result Summary=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D

Regression -= PG 11:

0 tests passed
1 test failed:
Rev= erseEngineeredSQLTestCases (Reverse Engineered SQL Test Cases)
0 t= ests skipped

=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D
 
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitte= r: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQ= L Company
= --Apple-Mail-17A303AF-A931-41EA-AFB2-0FB4F505DD4A--