public inbox for [email protected]
help / color / mirror / Atom feedFrom: Akshay Joshi <[email protected]>
To: [email protected]
Subject: pgAdmin 4 commit: Fixed below review comments for QueryTool
Date: Fri, 06 May 2016 12:41:17 +0000
Message-ID: <[email protected]> (raw)
List-Unsubscribe: <mailto:[email protected]?body=unsub%20pgadmin-hackers>
Fixed below review comments for QueryTool
- The button bar be moved out into an HTML template
- create.sql should perhaps be renamed to insert.sql
- The "Add Row" button only works if you're on the last page of the resultset.
- Use one wcDocker instead of two
- Added support of code folding
Branch
------
master
Details
-------
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=894002b06df53d84c735eb8969e98ec4c6b4a...
Modified Files
--------------
.../tools/datagrid/templates/datagrid/index.html | 114 ++++++++-
web/pgadmin/tools/sqleditor/command.py | 2 +-
.../tools/sqleditor/static/css/sqleditor.css | 39 +++-
.../sqleditor/templates/sqleditor/js/sqleditor.js | 254 ++++++---------------
.../templates/sqleditor/sql/9.1_plus/create.sql | 8 -
.../templates/sqleditor/sql/9.1_plus/insert.sql | 8 +
6 files changed, 219 insertions(+), 206 deletions(-)
--
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
view thread (2+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected]
Subject: Re: pgAdmin 4 commit: Fixed below review comments for QueryTool
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox