public inbox for [email protected]
help / color / mirror / Atom feedFrom: Dave Page <[email protected]>
To: [email protected]
Subject: pgAdmin 4 commit: Fixes for function, procedure and trigger reverse SQL
Date: Fri, 22 Jul 2016 15:38:25 +0000
Message-ID: <[email protected]> (raw)
List-Unsubscribe: <mailto:[email protected]?body=unsub%20pgadmin-hackers>
Fixes for function, procedure and trigger reverse SQL. Fixes #1293. Fixes #1294
1. RM#1293 - SQL pane is not displaying GRANT queries in functions node
2. RM#1294 - Comments are not visible in sql pane for trigger functions and functions
Explanation:
Previously we we using 'get_defintion.sql' template to generate SQL for SQL pane for functions, procedure & trigger functions node.
but GRANT statements and COMMENTS changes were missing. In order to fix that, now we have used both 'create.sql' and 'get_definition.sql' templates to generate full SQL query for SQL pane.
Branch
------
master
Details
-------
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=91559c622bdcbecb8ae9b8c53ba572258d7e3...
Author: Surinder Kumar <[email protected]>
Modified Files
--------------
.../databases/schemas/functions/__init__.py | 49 ++++++++++++++++++++--
.../templates/function/pg/sql/9.1_plus/create.sql | 27 ++++++++----
.../templates/function/pg/sql/9.2_plus/create.sql | 26 ++++++++----
.../templates/function/pg/sql/9.5_plus/create.sql | 25 +++++++----
.../function/ppas/sql/9.1_plus/create.sql | 27 ++++++++----
.../function/ppas/sql/9.2_plus/create.sql | 26 ++++++++----
.../function/ppas/sql/9.5_plus/create.sql | 3 +-
.../procedure/ppas/sql/9.1_plus/create.sql | 11 ++---
.../procedure/ppas/sql/9.2_plus/create.sql | 10 +++--
.../procedure/ppas/sql/9.5_plus/create.sql | 9 ++--
.../trigger_function/pg/sql/9.1_plus/create.sql | 11 +++--
.../trigger_function/pg/sql/9.2_plus/create.sql | 6 ++-
.../trigger_function/pg/sql/9.5_plus/create.sql | 13 +++---
.../trigger_function/ppas/sql/9.1_plus/create.sql | 11 +++--
.../trigger_function/ppas/sql/9.2_plus/create.sql | 11 +++--
.../trigger_function/ppas/sql/9.5_plus/create.sql | 13 +++---
16 files changed, 201 insertions(+), 77 deletions(-)
--
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected]
Subject: Re: pgAdmin 4 commit: Fixes for function, procedure and trigger reverse SQL
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox