public inbox for [email protected]
help / color / mirror / Atom feedFrom: Dave Page <[email protected]>
To: [email protected]
Subject: pgAdmin 4 commit: Allow creation of FDWs if the extension is in a non-d
Date: Mon, 25 Jul 2016 11:48:15 +0000
Message-ID: <[email protected]> (raw)
List-Unsubscribe: <mailto:[email protected]?body=unsub%20pgadmin-hackers>
Allow creation of FDWs if the extension is in a non-default schema. Fixes #1320
Root cause:-
When user change schema of already created fdw extension then while creating the new fdw we should append the <schema_name>.<fdw_handler_name>.
Previously we added only <fdw_handler_name> so while executing the query it will not be able to find fdw handler name without schema name.
e.g. If user changed the fdw handler 'postgres_fdw_handler' under schema 'test' then we should display the handler name under fdw as "test. postgres_fdw_handler".
Solution:-
With this patch, we have added <schema_name>.<fdw_handler_name> so while creating or updating the fdw, proper sql will be generated.
Branch
------
master
Details
-------
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=dbd3c7f4c5dab4aafa81ade9cfe5b309c8b5c...
Author: Neel Patel <[email protected]>
Modified Files
--------------
.../servers/databases/foreign_data_wrappers/__init__.py | 4 ++--
.../templates/foreign_data_wrappers/sql/9.1_plus/create.sql | 4 ++--
.../templates/foreign_data_wrappers/sql/9.1_plus/handlers.sql | 5 ++++-
.../foreign_data_wrappers/sql/9.1_plus/properties.sql | 10 +++++++---
.../templates/foreign_data_wrappers/sql/9.1_plus/update.sql | 4 ++--
.../foreign_data_wrappers/sql/9.1_plus/validators.sql | 5 ++++-
.../templates/foreign_data_wrappers/sql/9.3_plus/create.sql | 4 ++--
.../templates/foreign_data_wrappers/sql/9.3_plus/handlers.sql | 5 ++++-
.../foreign_data_wrappers/sql/9.3_plus/properties.sql | 8 ++++++--
.../templates/foreign_data_wrappers/sql/9.3_plus/update.sql | 4 ++--
.../foreign_data_wrappers/sql/9.3_plus/validators.sql | 5 ++++-
11 files changed, 39 insertions(+), 19 deletions(-)
--
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected]
Subject: Re: pgAdmin 4 commit: Allow creation of FDWs if the extension is in a non-d
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox