public inbox for [email protected]
help / color / mirror / Atom feedFrom: Dave Page <[email protected]>
To: [email protected]
Subject: pgAdmin 4 commit: Property 'URL' (of type string) not quoted in browser
Date: Tue, 26 Jul 2016 11:47:50 +0000
Message-ID: <[email protected]> (raw)
List-Unsubscribe: <mailto:[email protected]?body=unsub%20pgadmin-hackers>
Property 'URL' (of type string) not quoted in browser.js template when extending pgAdmin.Browser. Fixes #1504
Without quotes, the property can be mistakenly treated as a regex:
e.g.: URL: /pgadmin/browser/,
When that happens, JS engine throws "SyntaxError: invalid regular expression flag b" and the whole web interface freezes.
This problem usually occurs when pgadmin is hosted inside a subdirectory (https://host/pgadmin/ instead of https://host/).
Branch
------
master
Details
-------
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=19306934a08f786cba2cd156a14858e666020...
Author: daze <[email protected]>
Modified Files
--------------
web/pgadmin/browser/templates/browser/js/browser.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected]
Subject: Re: pgAdmin 4 commit: Property 'URL' (of type string) not quoted in browser
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox