public inbox for [email protected]  
help / color / mirror / Atom feed
From: Dave Page <[email protected]>
To: [email protected]
Subject: pgAdmin 4 commit: Fix renaming of constraints from the table dialogue.
Date: Wed, 03 Aug 2016 14:39:17 +0000
Message-ID: <[email protected]> (raw)
List-Unsubscribe:  <mailto:[email protected]?body=unsub%20pgadmin-hackers>

Fix renaming of constraints from the table dialogue. Fixes #1500

1] datamodel.js: For collection type added check before adding model into "changed" list instead of adding it blindly.

2] Type casting from str to int of column properties like attlen, attpricision.

3] Added missing data formating when adding new column to existing table (from table edit mode).

4] Added more validation for Foreign key constraint.

5] Column.js: Column grid (in table edit mode) show proper disabled color for disabled cell when grid renders.

6] All constraints and index js added idattribute to distinguish which s/constraint or s/index is updated on server side.

7] Column update.sql: Fixed sql when altering column data type. The issue was when we alter data type from which has length and precision to data type which don't have these properties and vice versa.
For e.g. alter data type numeric(10,12) to real (and vice versa)

8] Renaming constraint (RM1500).

9] simplejson KeyError handing for Python 2.7.

Branch
------
master

Details
-------
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=de568b3021ecff0f2f91fd8941414479dd121...
Author: Harshal Dhumal <[email protected]>

Modified Files
--------------
.../servers/databases/schemas/tables/__init__.py   | 135 +++++++++++++--------
.../databases/schemas/tables/column/__init__.py    |   2 +-
.../tables/column/templates/column/js/column.js    |  84 ++++++++-----
.../constraints/check_constraint/__init__.py       |   2 +-
.../check_constraint/js/check_constraint.js        |   2 +
.../constraints/exclusion_constraint/__init__.py   |   2 +-
.../js/exclusion_constraint.js                     |   2 +
.../tables/constraints/foreign_key/__init__.py     |   2 +-
.../templates/foreign_key/js/foreign_key.js        |   2 +
.../constraints/index_constraint/__init__.py       |   2 +-
.../index_constraint/js/index_constraint.js        |   2 +
.../databases/schemas/tables/indexes/__init__.py   |   2 +-
.../tables/indexes/templates/index/js/index.js     |   3 +
.../templates/column/sql/9.1_plus/update.sql       |  57 +++++++--
.../templates/column/sql/9.2_plus/update.sql       |  66 ++++++++--
.../databases/schemas/tables/triggers/__init__.py  |   2 +-
web/pgadmin/browser/static/js/datamodel.js         |   6 +-
17 files changed, 264 insertions(+), 109 deletions(-)


-- 
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected]
  Subject: Re: pgAdmin 4 commit: Fix renaming of constraints from the table dialogue.
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox