public inbox for [email protected]  
help / color / mirror / Atom feed
From: Dave Page <[email protected]>
To: [email protected]
Subject: pgAdmin 4 commit: Add classid filter to queries on pg_depend. Fixes #17
Date: Fri, 16 Sep 2016 10:24:57 +0000
Message-ID: <[email protected]> (raw)
List-Unsubscribe:  <mailto:[email protected]?body=unsub%20pgadmin-hackers>

Add classid filter to queries on pg_depend. Fixes #1705

There are a number of cases where queries in both pgadmin4 and pgadmin3 are done against pg_depend but falis to constrain the query on classid.

In particular, if for example a constraint and a sequence exists with the same oid (which is perfectly valid, as they are in different tables), a column will suddenly refer sequences that are completely incorrect. When we look up sequences, we have to make sure we only match dependencies against pg_class.

Branch
------
master

Details
-------
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ce20dbc25a393004c5249d946f9a85a691cac...
Author: Magnus Hagander <[email protected]>

Modified Files
--------------
.../columns/templates/catalog_object_column/sql/9.1_plus/properties.sql | 2 +-
.../schemas/tables/templates/column/sql/9.1_plus/is_referenced.sql      | 1 +
.../databases/schemas/tables/templates/column/sql/9.1_plus/nodes.sql    | 2 +-
.../schemas/tables/templates/column/sql/9.1_plus/properties.sql         | 2 +-
.../schemas/tables/templates/column/sql/9.2_plus/is_referenced.sql      | 1 +
.../databases/schemas/tables/templates/column/sql/9.2_plus/nodes.sql    | 2 +-
.../schemas/tables/templates/column/sql/9.2_plus/properties.sql         | 2 +-
7 files changed, 7 insertions(+), 5 deletions(-)


-- 
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


view thread (2+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected]
  Subject: Re: pgAdmin 4 commit: Add classid filter to queries on pg_depend. Fixes #17
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox