public inbox for [email protected]
help / color / mirror / Atom feedFrom: Dave Page <[email protected]>
To: [email protected]
Subject: pgAdmin 4 commit: Don't show Upload File icon unless it is in capabilit
Date: Fri, 07 Oct 2016 11:31:41 +0000
Message-ID: <[email protected]> (raw)
List-Unsubscribe: <mailto:[email protected]?body=unsub%20pgadmin-hackers>
Don't show Upload File icon unless it is in capabilities list [Storage Manager]. Fixes #1739
Issue:
When clicked on upload icon while saving a file prompt user to leave page. It is because the icon is a button and its type is set to submit which makes it to prompt, instead it should be 'button'
Storage Manager's menu items depends on capabilities list set by the module using it. If capabilities doesn't have 'upload' in it, It won't work. Upload button is bound to click event only when it is in capabilities.
Solution:
As upload button is being added only when it is in capabilities, so upload button html is removed from html file. It will not shown on UI untill it is in capabilities list.
Branch
------
master
Details
-------
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3963272523c1061acfbaa78243b77dde5a063...
Author: Surinder Kumar <[email protected]>
Modified Files
--------------
web/pgadmin/misc/file_manager/templates/file_manager/index.html | 2 --
web/pgadmin/misc/file_manager/templates/file_manager/js/utility.js | 2 +-
2 files changed, 1 insertion(+), 3 deletions(-)
--
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected]
Subject: Re: pgAdmin 4 commit: Don't show Upload File icon unless it is in capabilit
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox