public inbox for [email protected]
help / color / mirror / Atom feedFrom: Dave Page <[email protected]>
To: [email protected]
Subject: pgAdmin 4 commit: While building runtime with QtWebEngine, we found 2 c
Date: Mon, 15 May 2017 10:29:17 +0000
Message-ID: <[email protected]> (raw)
List-Unsubscribe: <mailto:[email protected]?body=unsub%20pgadmin-hackers>
While building runtime with QtWebEngine, we found 2 compilation errors which were introduced in a previous commit in runtime:
We set "setNetworkAccessManager" in WebEnginePage which was only required for Webkit so removed that statement.
"triggerAction" on WebPage is only required for Qt > 5 with WebKit only. Not required for WebEngine so added that condition.
Branch
------
master
Details
-------
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=07b06348ab487a54077e6fa3aaa16d25c51f...
Author: Neel Patel <[email protected]>
Modified Files
--------------
runtime/BrowserWindow.cpp | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
--
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected]
Subject: Re: pgAdmin 4 commit: While building runtime with QtWebEngine, we found 2 c
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox