Received: from malur.postgresql.org ([2a02:16a8:dc51::56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fQ9tp-0006sa-5F for pgadmin-hackers@arkaria.postgresql.org; Tue, 05 Jun 2018 11:13:13 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1fQ9tn-00027Q-Mx for pgadmin-hackers@arkaria.postgresql.org; Tue, 05 Jun 2018 11:13:11 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fQ9tn-00027G-EA for pgadmin-hackers@lists.postgresql.org; Tue, 05 Jun 2018 11:13:11 +0000 Received: from mahout.postgresql.org ([2001:4800:1501:1::227]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fQ9ti-0002fN-V5 for pgadmin-hackers@postgresql.org; Tue, 05 Jun 2018 11:13:10 +0000 Received: from gothos.postgresql.org ([204.145.124.243]) by mahout.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1fQ9ti-0008PQ-MR for pgadmin-hackers@postgresql.org; Tue, 05 Jun 2018 11:13:06 +0000 Received: from git by gothos.postgresql.org with local (Exim 4.89) (envelope-from ) id 1fQ9th-0001WJ-VB for pgadmin-hackers@postgresql.org; Tue, 05 Jun 2018 11:13:05 +0000 Content-Type: multipart/mixed; boundary="===============5587835792809483750==" MIME-Version: 1.0 From: Ashesh Vashi To: pgadmin-hackers@postgresql.org Subject: pgAdmin 4 commit: Extract the tests and refactor some of the methods. Message-Id: Date: Tue, 05 Jun 2018 11:13:05 +0000 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --===============5587835792809483750== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 RXh0cmFjdCB0aGUgdGVzdHMgYW5kIHJlZmFjdG9yIHNvbWUgb2YgdGhlIG1ldGhvZHMuCgpFeHRy YWN0IHNvbWUgb2YgdGhlIEFDSSBUcmVlIGZ1bmN0aW9uYWxpdGllcywgYW5kIGRlY291cGxlIGl0 IGZyb20gdGhlCm1haW4gc291cmNlLiBBbHNvIC0gY3JlYXRlIHNvbWUgYWJzdHJhY3Rpb25zIGZy b20gdGhlIHJlcGVhdGVkIGNvZGUKYXJvdW5kIHRoZSBlbmFibGUvZGlzYWJsZSB0aGUgc2NoZW1h IGNoaWxkcmVuIG9iamVjdCBjcmVhdGUvZWRpdC9kZWxldGUKZnVuY3Rpb25hbGl0aWVzLCBhbmQg YWxzbyBjcmVhdGVkIHRoZSBkaWFsb2cgd3JhcHBlcnMgZm9yIGJhY2t1cCBhbmQKcmVzdG9yZSBk aWFsb2dzLgoKUmV2aWV3ZWQgYnk6IEtodXNoYm9vIGFuZCBBc2hlc2gKUmVmYWN0b3JlZCBieTog QXNoZXNoCgpCcmFuY2gKLS0tLS0tCm1hc3RlcgoKRGV0YWlscwotLS0tLS0tCmh0dHBzOi8vZ2l0 LnBvc3RncmVzcWwub3JnL2dpdHdlYj9wPXBnYWRtaW40LmdpdDthPWNvbW1pdGRpZmY7aD03ZGQ2 MzcyZWViM2ZiMmM5NzlmYTc2N2FmYzk1ZDVlZTZlMmU0MWVlCkF1dGhvcjogSm9hbyBEZSBBbG1l aWRhIFBlcmVpcmEgPGpkZWFsbWVpZGFwZXJlaXJhQHBpdm90YWwuaW8+CgpNb2RpZmllZCBGaWxl cwotLS0tLS0tLS0tLS0tLQouLi4vc2NoZW1hcy9jb2xsYXRpb25zL3N0YXRpYy9qcy9jb2xsYXRp b24uanMgICAgICB8ICAzNCArLQouLi4vZGF0YWJhc2VzL3NjaGVtYXMvZG9tYWlucy9zdGF0aWMv anMvZG9tYWluLmpzICB8ICAzOCArLQouLi4vZm9yZWlnbl90YWJsZXMvc3RhdGljL2pzL2ZvcmVp Z25fdGFibGUuanMgICAgICB8ICAzNyArLQouLi4vc3RhdGljL2pzL2Z0c19jb25maWd1cmF0aW9u LmpzICAgICAgICAgICAgICAgICB8ICAzOCArLQouLi4vZnRzX2RpY3Rpb25hcmllcy9zdGF0aWMv anMvZnRzX2RpY3Rpb25hcnkuanMgICB8ICAzOSArLQouLi4vc2NoZW1hcy9mdHNfcGFyc2VyL3N0 YXRpYy9qcy9mdHNfcGFyc2VyLmpzICAgICB8ICAzOCArLQouLi4vZnRzX3RlbXBsYXRlcy9zdGF0 aWMvanMvZnRzX3RlbXBsYXRlLmpzICAgICAgICB8ICAzOCArLQouLi4vc2NoZW1hcy9mdW5jdGlv bnMvc3RhdGljL2pzL2Z1bmN0aW9uLmpzICAgICAgICB8ICA0MSArLQouLi4vZnVuY3Rpb25zL3N0 YXRpYy9qcy90cmlnZ2VyX2Z1bmN0aW9uLmpzICAgICAgICB8ICA0MCArLQouLi4vc2NoZW1hcy9z ZXF1ZW5jZXMvc3RhdGljL2pzL3NlcXVlbmNlLmpzICAgICAgICB8ICAzOSArLQouLi4vc2VydmVy cy9kYXRhYmFzZXMvc2NoZW1hcy9zdGF0aWMvanMvY2hpbGQuanMgICB8ICAyMiArCi4uLi9zZXJ2 ZXJzL2RhdGFiYXNlcy9zY2hlbWFzL3N0YXRpYy9qcy9zY2hlbWEuanMgIHwgIDQ2ICstCi4uLi9z Y2hlbWFzL3N0YXRpYy9qcy9zY2hlbWFfY2hpbGRfdHJlZV9ub2RlLmpzICAgIHwgIDQxICsrCi4u Li9zY2hlbWFzL3RhYmxlcy9jb2x1bW4vc3RhdGljL2pzL2NvbHVtbi5qcyAgICAgIHwgIDM2ICst Ci4uLi9jaGVja19jb25zdHJhaW50L3N0YXRpYy9qcy9jaGVja19jb25zdHJhaW50LmpzIHwgICAx IC0KLi4uL3N0YXRpYy9qcy9leGNsdXNpb25fY29uc3RyYWludC5qcyAgICAgICAgICAgICAgfCAg IDEgLQouLi4vZm9yZWlnbl9rZXkvc3RhdGljL2pzL2ZvcmVpZ25fa2V5LmpzICAgICAgICAgICB8 ICAgMSAtCi4uLi9pbmRleF9jb25zdHJhaW50L3N0YXRpYy9qcy9wcmltYXJ5X2tleS5qcyAgICAg IHwgICAxIC0KLi4uL3N0YXRpYy9qcy91bmlxdWVfY29uc3RyYWludC5qcyAgICAgICAgICAgICAg ICAgfCAgIDEgLQouLi4vdGFibGVzL2NvbnN0cmFpbnRzL3N0YXRpYy9qcy9jb25zdHJhaW50cy5q cyAgICB8ICAgMiAtCi4uLi9zY2hlbWFzL3RhYmxlcy9pbmRleGVzL3N0YXRpYy9qcy9pbmRleC5q cyAgICAgIHwgIDEyICstCi4uLi90YWJsZXMvcGFydGl0aW9ucy9zdGF0aWMvanMvcGFydGl0aW9u LmpzICAgICAgIHwgIDY4ICstLQouLi4vc2NoZW1hcy90YWJsZXMvcnVsZXMvc3RhdGljL2pzL3J1 bGUuanMgICAgICAgICB8ICAgMiAtCi4uLi90YWJsZXMvc3RhdGljL2pzL2VuYWJsZV9kaXNhYmxl X3RyaWdnZXJzLmpzICAgIHwgIDUyICsrCi4uLi9kYXRhYmFzZXMvc2NoZW1hcy90YWJsZXMvc3Rh dGljL2pzL3RhYmxlLmpzICAgIHwgMTEyICstLS0KLi4uL3NjaGVtYXMvdGFibGVzL3RyaWdnZXJz L3N0YXRpYy9qcy90cmlnZ2VyLmpzICAgfCAgNTkgKy0KLi4uL2RhdGFiYXNlcy9zY2hlbWFzL3R5 cGVzL3N0YXRpYy9qcy90eXBlLmpzICAgICAgfCAgNDEgKy0KLi4uL2RhdGFiYXNlcy9zY2hlbWFz L3ZpZXdzL3N0YXRpYy9qcy9tdmlldy5qcyAgICAgfCAgNTIgKy0KLi4uL2RhdGFiYXNlcy9zY2hl bWFzL3ZpZXdzL3N0YXRpYy9qcy92aWV3LmpzICAgICAgfCAgNTkgKy0Kd2ViL3BnYWRtaW4vYnJv d3Nlci9zdGF0aWMvanMvY29sbGVjdGlvbi5qcyAgICAgICAgfCAgIDggKy0Kd2ViL3BnYWRtaW4v YnJvd3Nlci9zdGF0aWMvanMvbm9kZS5qcyAgICAgICAgICAgICAgfCAgMzIgKy0Kd2ViL3BnYWRt aW4vc3RhdGljL2pzL2FsZXJ0aWZ5L2RpYWxvZy5qcyAgICAgICAgICAgfCAxNTAgKysrKysKd2Vi L3BnYWRtaW4vc3RhdGljL2pzL2FsZXJ0aWZ5L2RpYWxvZ19mYWN0b3J5LmpzICAgfCAgNTIgKysK d2ViL3BnYWRtaW4vc3RhdGljL2pzL2FsZXJ0aWZ5L2RpYWxvZ193cmFwcGVyLmpzICAgfCAgNTcg KysKLi4uL3N0YXRpYy9qcy9ub2Rlcy9zdXBwb3J0ZWRfZGF0YWJhc2Vfbm9kZS5qcyAgICAgfCAg MzcgKysKd2ViL3BnYWRtaW4vc3RhdGljL2pzL3RyZWUvcGdhZG1pbl90cmVlX25vZGUuanMgICAg fCAgNzIgKysrCndlYi9wZ2FkbWluL3N0YXRpYy9qcy90cmVlL3RyZWUuanMgICAgICAgICAgICAg ICAgIHwgIDE4ICstCndlYi9wZ2FkbWluL3Rvb2xzL2JhY2t1cC9zdGF0aWMvanMvYmFja3VwLmpz ICAgICAgIHwgNjE2ICstLS0tLS0tLS0tLS0tLS0tLS0KLi4uL3Rvb2xzL2JhY2t1cC9zdGF0aWMv anMvYmFja3VwX2RpYWxvZy5qcyAgICAgICAgfCAgNzIgKysrCi4uLi9iYWNrdXAvc3RhdGljL2pz L2JhY2t1cF9kaWFsb2dfd3JhcHBlci5qcyAgICAgIHwgMjU4ICsrKysrKysrCndlYi9wZ2FkbWlu L3Rvb2xzL2JhY2t1cC9zdGF0aWMvanMvbWVudV91dGlscy5qcyAgIHwgIDIzICsKd2ViL3BnYWRt aW4vdG9vbHMvZGF0YWdyaWQvc3RhdGljL2pzL2RhdGFncmlkLmpzICAgfCAxMTcgKy0tLQouLi4v dG9vbHMvZGF0YWdyaWQvc3RhdGljL2pzL2dldF9wYW5lbF90aXRsZS5qcyAgICB8ICAzMyArCndl Yi9wZ2FkbWluL3Rvb2xzL2RhdGFncmlkL3N0YXRpYy9qcy9zaG93X2RhdGEuanMgIHwgIDkyICsr KwouLi4vdG9vbHMvZGF0YWdyaWQvc3RhdGljL2pzL3Nob3dfcXVlcnlfdG9vbC5qcyAgICB8ICA2 MyArKwouLi4vdG9vbHMvZ3JhbnRfd2l6YXJkL3N0YXRpYy9qcy9ncmFudF93aXphcmQuanMgICB8 ICA1NiArLQouLi4vdG9vbHMvZ3JhbnRfd2l6YXJkL3N0YXRpYy9qcy9tZW51X3V0aWxzLmpzICAg ICB8ICAxNiArCi4uLi90b29scy9pbXBvcnRfZXhwb3J0L3N0YXRpYy9qcy9pbXBvcnRfZXhwb3J0 LmpzIHwgIDI5ICstCi4uLi90b29scy9tYWludGVuYW5jZS9zdGF0aWMvanMvbWFpbnRlbmFuY2Uu anMgICAgIHwgIDQ5ICstCi4uLi90b29scy9tYWludGVuYW5jZS9zdGF0aWMvanMvbWVudV91dGls cy5qcyAgICAgIHwgIDEzICsKd2ViL3BnYWRtaW4vdG9vbHMvcmVzdG9yZS9zdGF0aWMvanMvbWVu dV91dGlscy5qcyAgfCAgMTggKwp3ZWIvcGdhZG1pbi90b29scy9yZXN0b3JlL3N0YXRpYy9qcy9y ZXN0b3JlLmpzICAgICB8IDM4OSArLS0tLS0tLS0tLS0Kd2ViL3BnYWRtaW4vdG9vbHMvcmVzdG9y ZS9zdGF0aWMvanMvcmVzdG9yZS5qcy5yZWogfCAzMjIgKysrKysrKysrKwouLi4vdG9vbHMvcmVz dG9yZS9zdGF0aWMvanMvcmVzdG9yZV9kaWFsb2cuanMgICAgICB8ICA1NyArKwouLi4vcmVzdG9y ZS9zdGF0aWMvanMvcmVzdG9yZV9kaWFsb2dfd3JhcHBlci5qcyAgICB8IDI1NSArKysrKysrKwou Li4vamF2YXNjcmlwdC9iYWNrdXAvYmFja3VwX2RpYWxvZ19zcGVjLmpzICAgICAgICB8IDIwNSAr KysrKysrCi4uLi9iYWNrdXAvYmFja3VwX2RpYWxvZ193cmFwcGVyX3NwZWMuanMgICAgICAgICAg IHwgNjc1ICsrKysrKysrKysrKysrKysrKysrKwouLi4vYmFja3VwL2dsb2JhbF9zZXJ2ZXJfYmFj a3VwX2RpYWxvZ19zcGVjLmpzICAgICB8IDE2OCArKysrKwouLi4vamF2YXNjcmlwdC9iYWNrdXAv bWVudV91dGlsc19zcGVjLmpzICAgICAgICAgICB8ICA1NSArKwouLi4vamF2YXNjcmlwdC9jb21t b25fa2V5Ym9hcmRfc2hvcnRjdXRzX3NwZWMuanMgICB8ICAgNCAtCi4uLi9qYXZhc2NyaXB0L2Rh dGFncmlkL2dldF9wYW5lbF90aXRsZV9zcGVjLmpzICAgIHwgIDgyICsrKwouLi4vamF2YXNjcmlw dC9kYXRhZ3JpZC9zaG93X2RhdGFfc3BlYy5qcyAgICAgICAgICB8IDE3MSArKysrKysKLi4uL2ph dmFzY3JpcHQvZGF0YWdyaWQvc2hvd19xdWVyeV90b29sX3NwZWMuanMgICAgfCAxMjUgKysrKwp3 ZWIvcmVncmVzc2lvbi9qYXZhc2NyaXB0L2Zha2VfYnJvd3Nlci9icm93c2VyLmpzICB8ICAxMiAr CndlYi9yZWdyZXNzaW9uL2phdmFzY3JpcHQvZmFrZV9lbmRwb2ludHMuanMgICAgICAgIHwgICA2 ICsKd2ViL3JlZ3Jlc3Npb24vamF2YXNjcmlwdC9mYWtlX21vZGVsLmpzICAgICAgICAgICAgfCAg MjEgKwouLi4vamF2YXNjcmlwdC9ub2Rlcy9zY2hlbWEvY2hpbGRfbWVudV9zcGVjLmpzICAgICB8 IDI1MyArKysrKysrKwouLi4vamF2YXNjcmlwdC9yZXN0b3JlL3Jlc3RvcmVfZGlhbG9nX3NwZWMu anMgICAgICB8IDIwMyArKysrKysrCi4uLi9yZXN0b3JlL3Jlc3RvcmVfZGlhbG9nX3dyYXBwZXJf c3BlYy5qcyAgICAgICAgIHwgNTkzICsrKysrKysrKysrKysrKysrKwouLi4vamF2YXNjcmlwdC9z cWxlZGl0b3IvZmlsdGVyX2RpYWxvZ19zcGVjcy5qcyAgICB8ICAgMiAtCi4uLi90YWJsZS9lbmFi bGVfZGlzYWJsZV90cmlnZ2Vyc19zcGVjLmpzICAgICAgICAgIHwgMjcxICsrKysrKysrKwouLi4v amF2YXNjcmlwdC90cmVlL3BnYWRtaW5fdHJlZV9ub2RlX3NwZWMuanMgICAgICB8IDM1MyArKysr KysrKysrKwp3ZWIvcmVncmVzc2lvbi9qYXZhc2NyaXB0L3RyZWUvdHJlZV9mYWtlLmpzICAgICAg ICB8ICAyOCArLQp3ZWIvd2VicGFjay5zaGltLmpzICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICB8ICAgMSArCndlYi93ZWJwYWNrLnRlc3QuY29uZmlnLmpzICAgICAgICAgICAgICAgICAg ICAgICAgIHwgICAyICsKNzUgZmlsZXMgY2hhbmdlZCwgNTE4NiBpbnNlcnRpb25zKCspLCAxOTM5 IGRlbGV0aW9ucygtKQoK --===============5587835792809483750==--