public inbox for [email protected]  
help / color / mirror / Atom feed
From: Dave Page <[email protected]>
To: [email protected]
Subject: pgAgent commit: 1. Connection object was being accessed, which was alre
Date: Mon, 11 Jun 2018 16:14:12 +0000
Message-ID: <[email protected]> (raw)

1. Connection object was being accessed, which was already released.

2. Changed the logic for checking the connection object existence.

We're using "if (!ms_primaryCon)", which should convert the logic as boolean operator explicitly, which we defined for the 'DBconn' class.

I suspect some compilers (specifically windows one) may not behave that way, and instead of using the boolean operator, it checks for the pointer is NULL or not.

Branch
------
master

Details
-------
https://git.postgresql.org/gitweb?p=pgagent.git;a=commitdiff;h=1c583df4bbf0a3f15a5f919096057cca70da1...
Author: Ashesh Vashi <[email protected]>

Modified Files
--------------
connection.cpp | 2 +-
pgAgent.cpp    | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)



reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected]
  Subject: Re: pgAgent commit: 1. Connection object was being accessed, which was alre
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox