public inbox for [email protected]
help / color / mirror / Atom feedpgAdmin 4 commit: Fixed following issues for feature test:
4+ messages / 1 participants
[nested] [flat]
* pgAdmin 4 commit: Fixed following issues for feature test:
@ 2019-12-03 14:08 Akshay Joshi <[email protected]>
0 siblings, 0 replies; 4+ messages in thread
From: Akshay Joshi @ 2019-12-03 14:08 UTC (permalink / raw)
To: [email protected]
Fixed following issues for feature test:
1. Modified the get_chromedriver utility for supporting python version below 3.5.
2. Handled some exceptions getting intermittently on some databases.
3. Generalized some functions with additional parameters.
4. Disabled the auto-expansion of the children nodes for maintaining the synchronization.
Branch
------
master
Details
-------
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5093e6db5e7a36f27229dd480a92ec2f2707...
Author: Shubham Agarwal <[email protected]>
Modified Files
--------------
tools/get_chromedriver.py | 23 ++++++-----
.../feature_tests/pg_datatype_validation_test.py | 6 +--
.../pg_utilities_backup_restore_test.py | 9 +++--
.../query_tool_auto_complete_tests.py | 8 ++--
web/pgadmin/feature_tests/query_tool_tests.py | 11 +++--
web/regression/feature_utils/pgadmin_page.py | 34 +++++++++-------
.../python_test_utils/test_gui_helper.py | 17 ++++----
web/regression/python_test_utils/test_utils.py | 47 +++++++++++++++++-----
8 files changed, 94 insertions(+), 61 deletions(-)
^ permalink raw reply [nested|flat] 4+ messages in thread
* pgAdmin 4 commit: Fixed following issues in the function module:
@ 2020-10-12 08:39 Akshay Joshi <[email protected]>
0 siblings, 0 replies; 4+ messages in thread
From: Akshay Joshi @ 2020-10-12 08:39 UTC (permalink / raw)
To: [email protected]
Fixed following issues in the function module:
1) The volatility option is not reflecting. It stays volatile always when creating the function.
2) Set "Returns as set" to true and enter estimated rows like 12. Now set returns as set to false and save.
It gives ERROR: ROWS is not applicable when the function does not return a set.
Need to clear estimated rows when returns as set is false.
3) If estimated rows are added and support function is selected then SQL looks ugly.
Fixes #5843
Branch
------
master
Details
-------
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1bb510cdd4114163a40682d3f48d758d5407...
Author: Pradip Parkale <[email protected]>
Modified Files
--------------
.../databases/schemas/functions/__init__.py | 7 +++--
.../schemas/functions/static/js/function.js | 5 +++-
.../templates/functions/pg/sql/12_plus/create.sql | 1 -
.../functions/ppas/sql/9.5_plus/create.sql | 2 +-
.../procedures/ppas/sql/9.6_plus/create.sql | 2 +-
.../procedures/ppas/sql/9.6_plus/update.sql | 2 +-
.../tests/pg/11_plus/test_trigger_functions.json | 4 +--
.../tests/pg/12_plus/create_event_trigger_full.sql | 2 +-
.../tests/pg/12_plus/create_plain_trigger_full.sql | 2 +-
.../tests/pg/9.5_plus/test_trigger_functions.json | 4 +--
.../tests/pg/9.6_plus/test_trigger_functions.json | 4 +--
.../tests/pg/default/test_trigger_functions.json | 4 +--
.../tests/ppas/11_plus/test_trigger_functions.json | 4 +--
.../tests/ppas/12_plus/test_trigger_functions.json | 4 +--
.../tests/ppas/9.6_plus/alter_proc_opt.sql | 2 +-
.../tests/ppas/9.6_plus/alter_proc_opt_msql.sql | 2 +-
.../ppas/9.6_plus/create_plain_trigger_full.sql | 2 +-
.../tests/ppas/9.6_plus/test_procedures.json | 31 +++++++++++++++++-----
.../ppas/9.6_plus/test_trigger_functions.json | 2 +-
.../tests/ppas/default/test_procedures.json | 2 +-
.../tests/ppas/default/test_trigger_functions.json | 4 +--
21 files changed, 55 insertions(+), 37 deletions(-)
^ permalink raw reply [nested|flat] 4+ messages in thread
* pgAdmin 4 commit: Fixed following issues for query tool after react por
@ 2022-04-18 07:24 Akshay Joshi <[email protected]>
0 siblings, 0 replies; 4+ messages in thread
From: Akshay Joshi @ 2022-04-18 07:24 UTC (permalink / raw)
To: [email protected]
Fixed following issues for query tool after react porting:
1) Add New Server Connection > Server options keep loading(For empty Server group).
2) After clicking indent/Unindent(for all operations) for large query option left as it is till operation completes
3) Check sign beside options in Execute Option/Copy Header is little bit big
4) In explain > Analysis tab does not show ROWS column
5) In explain > Explain > analysis previous explain output is NOT cleared. New rows are appended. Same applies to the statistics tab.
6) Update new query tool connection tool tip. Fixes #7289
7) Explain-Analyze > Loops column is empty.
8) Explain-Analyze with Verbose & Costs > in ROW X columns upward arrows are missing.
9) Explain-Analyze with all option checked > background colors are missing for timing.
10) Explain-Analyze > Additional bullet is added before Hash Cond.
11) Browser Tree > Filtered rows icon is not working.
12) Create table with timestamp and default value as function now() > Add new row > Enter mandatory columns except column where default value is function(now()) > Click Save > New row added but column with default value has value [default]. not updated to actual value. / Default values are not considered for any column while adding a new entry.
13) Disable execute options in View/Edit data.
14) The Boolean column always shows null.
15) In Query history Remove & Remove all buttons are stuck to each other.
16) On Remove all, the right panel is empty.
17) Create a column with boolean[]/ text[], Try to add a new entry from data grid, enter “” quotes > Click Ok > Now try edit cell > You can not change value.
18) In query history - Select queries are suffixed by ’Save Data’ icon
19) Edit any table with PK > Try to insert duplicate PK > Error thrown > Correct pK value > Still old error shown > Not able to add new entry (This works when focus is moved from edited cell)
20) Clicking arrows after opening dropdown options, does not collapse dropdown.
refs #6131
Branch
------
master
Details
-------
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9c30d983bdc7ca4cb27b2dd76e168085cc9f...
Author: Aditya Toshniwal <[email protected]>
Modified Files
--------------
web/pgadmin/browser/static/js/toolbar.js | 2 +-
web/pgadmin/static/js/Explain/Analysis.jsx | 57 +++++++-------
web/pgadmin/static/js/Explain/Graphical.jsx | 1 +
web/pgadmin/static/js/Explain/index.jsx | 90 +++++++++++++++-------
web/pgadmin/static/js/Theme/index.jsx | 16 ++++
web/pgadmin/static/js/Theme/standard.js | 14 ++++
web/pgadmin/static/js/components/CodeMirror.jsx | 16 ++++
web/pgadmin/static/js/components/ExternalIcon.jsx | 55 +++++++++----
web/pgadmin/static/js/components/Menu.jsx | 36 ++++++++-
web/pgadmin/static/js/helpers/EventBus.js | 2 +-
.../static/js/components/QueryToolComponent.jsx | 13 ++--
.../js/components/QueryToolDataGrid/Editors.jsx | 31 +++++---
.../js/components/dialogs/NewConnectionDialog.jsx | 3 +
.../js/components/sections/ConnectionBar.jsx | 6 +-
.../js/components/sections/GeometryViewer.jsx | 16 ++--
.../static/js/components/sections/MainToolBar.jsx | 48 +++++-------
.../static/js/components/sections/QueryHistory.jsx | 83 +++++++++++---------
.../static/js/components/sections/ResultSet.jsx | 12 +--
.../js/components/sections/ResultSetToolbar.jsx | 2 +-
.../static/js/components/sections/StatusBar.jsx | 15 ++--
.../javascript/components/Buttons.spec.js | 6 +-
.../javascript/components/TabPanel.spec.js | 4 +-
22 files changed, 343 insertions(+), 185 deletions(-)
^ permalink raw reply [nested|flat] 4+ messages in thread
* pgAdmin 4 commit: Fixed following issues for Query Tool (after React Po
@ 2022-04-20 13:32 Akshay Joshi <[email protected]>
0 siblings, 0 replies; 4+ messages in thread
From: Akshay Joshi @ 2022-04-20 13:32 UTC (permalink / raw)
To: [email protected]
Fixed following issues for Query Tool (after React Porting):
1) Find/Replace both opens the same dialogue box.(by clicking menu option)
2) Add New Server Connection > Server options keep loading(For multiple Server groups & should have some server)
3) Fixed CSS issues of slickgrid at various places.
4) C should be captial in ’<New connection…>'
5) In pop title for New Connection, all words should be capital.(Add new connection)
6) Explain > Analaysis tab > Column heading missing ROWS PLAN with cost & In explain only.
7) Explain > Analaysis tab > with cost enabled > Upward arrow size does not match with font of number. Arrow is little bigger than number.
8) Boolean default is not considered while ading new row.(try table from feature test defaults)
9) In query history , when not query history present, warning icon size big. Match it to warning message - No history found
10) Select table/db object > Open query tool from Tools menu > NOT FOUND error is shown. Existing issue, fixed.
11) Any cell just open by clicking it > Do NOT change any thing > Click Ok > Cell is shown as edited.
refs #6131
Branch
------
master
Details
-------
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e5ef6a7b21f73db08c38a2d816a3c17a18e4...
Author: Aditya Toshniwal <[email protected]>
Modified Files
--------------
web/package.json | 2 +-
web/pgadmin/static/js/Explain/Analysis.jsx | 19 +--
.../static/js/Explain/ExplainStatistics.jsx | 2 +-
web/pgadmin/static/js/Explain/Graphical.jsx | 2 +-
web/pgadmin/static/js/Explain/index.jsx | 11 +-
web/pgadmin/static/js/Theme/index.jsx | 20 +++
web/pgadmin/static/js/components/CodeMirror.jsx | 6 +-
.../static/js/components/EmptyPanelMessage.jsx | 8 +-
web/pgadmin/static/js/helpers/Layout.jsx | 45 ++++++
web/pgadmin/static/scss/_slickgrid.overrides.scss | 83 +++++++++++
web/pgadmin/static/scss/pgadmin.scss | 1 +
.../static/scss/_search_objects.scss | 7 +
.../tools/sqleditor/static/js/SQLEditorModule.js | 2 +-
.../static/js/components/QueryToolComponent.jsx | 2 +-
.../js/components/QueryToolDataGrid/Editors.jsx | 8 +
.../js/components/QueryToolDataGrid/index.jsx | 2 +-
.../js/components/dialogs/NewConnectionDialog.jsx | 3 +-
.../js/components/sections/ConnectionBar.jsx | 2 +-
.../js/components/sections/GeometryViewer.jsx | 166 ++++++++++++---------
.../static/js/components/sections/MainToolBar.jsx | 29 ++++
.../static/js/components/sections/Query.jsx | 2 +-
.../static/js/components/sections/QueryHistory.jsx | 4 +-
.../static/js/components/sections/ResultSet.jsx | 6 +-
.../js/components/sections/ResultSetToolbar.jsx | 2 +-
web/yarn.lock | 8 +-
25 files changed, 336 insertions(+), 106 deletions(-)
^ permalink raw reply [nested|flat] 4+ messages in thread
end of thread, other threads:[~2022-04-20 13:32 UTC | newest]
Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2019-12-03 14:08 pgAdmin 4 commit: Fixed following issues for feature test: Akshay Joshi <[email protected]>
2020-10-12 08:39 pgAdmin 4 commit: Fixed following issues in the function module: Akshay Joshi <[email protected]>
2022-04-18 07:24 pgAdmin 4 commit: Fixed following issues for query tool after react por Akshay Joshi <[email protected]>
2022-04-20 13:32 pgAdmin 4 commit: Fixed following issues for Query Tool (after React Po Akshay Joshi <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox