public inbox for [email protected]  
help / color / mirror / Atom feed
From: Akshay Joshi <[email protected]>
To: [email protected]
Subject: pgAdmin 4 commit: Fixed the following issues for the new query tool:
Date: Tue, 26 Apr 2022 10:59:31 +0000
Message-ID: <[email protected]> (raw)

Fixed the following issues for the new query tool:
 1) In Dark mode > Replace/Find dialogue forward & reverse buttons are stuck to each other.
 2) In Dark/High contrast mode > Checkbox is not visible for false value.
 3) Wrap toolbar when size goes very small.
 4) Replace functionality does not work when tried in sequence 2 times. Codemirror search is not cyclic. So, changes are made to always search from the start.
 5) Replace all does not work when tried in sequence 2 times. Same reason as above.
 6) Fix broken macros $SELECTION$ feature.
 7) Make query history SQL readonly.
 8) The Filter dialog save button should be disabled when opened.

Branch
------
master

Details
-------
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0795b22ae6fd63a6d5bd130497d3f8eebf27...
Author: Aditya Toshniwal <[email protected]>

Modified Files
--------------
web/pgadmin/static/js/components/CodeMirror.jsx        | 13 +++++++++----
.../static/js/components/QueryToolComponent.jsx        | 18 +++++++++++-------
.../static/js/components/QueryToolDataGrid/Editors.jsx |  2 +-
.../static/js/components/dialogs/FilterDialog.jsx      |  2 +-
.../static/js/components/sections/MainToolBar.jsx      |  3 ++-
.../sqleditor/static/js/components/sections/Query.jsx  | 17 +++++++++++++----
6 files changed, 37 insertions(+), 18 deletions(-)



view thread (4+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: pgAdmin 4 commit: Fixed the following issues for the new query tool:
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox