Feedback-ID: i0fe9450f:Fastmail
Date: Tue, 20 Jan 2026 15:45:12 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Dharin Shah <dharinshah95@gmail.com>
Cc: Robert Treat <rob@xzilla.net>, Peter Eisentraut <peter@eisentraut.org>,
	pgsql-hackers@lists.postgresql.org
Subject: Re: Fwd: [PATCH] Add zstd compression for TOAST using extended
 header format
Message-ID: <aW8keI6WZxywRQIt@paquier.xyz>
References: <4c70b0f6-5aba-464c-b145-464a620c1222@eisentraut.org>
 <aUOgmypuun0rc2xO@paquier.xyz>
 <CAOj6k6fxs0Bwjr34W4aURzFPta0DTGLN-1ic-U+-M_EqJ+Wd8A@mail.gmail.com>
 <aUSDs7SaEcOa65gD@paquier.xyz>
 <CABV9wwOdeFHHNnw+rUsVnFek-oqwsJnJX9KFG6AT5Yqz5RA_vg@mail.gmail.com>
 <aUyEWfBXYBLKGkKQ@paquier.xyz>
 <CAOj6k6dG0M-G0gs_Htray5y_pfvacXSjKYw0uJaaYJvOeqk7xw@mail.gmail.com>
 <CAOj6k6dEVi0NvLjMLDhyrJS_n_NZO5D_OU89AO1u53u6NCDDwQ@mail.gmail.com>
 <aVMSqzx7dGSDu4uG@paquier.xyz>
 <CAOj6k6eSVoz8Z-i6u2vGgofid6yXenb1a2AhbBkfi-N11jorHA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="XB7Az5dvfReirtgS"
Content-Disposition: inline
In-Reply-To: 
 <CAOj6k6eSVoz8Z-i6u2vGgofid6yXenb1a2AhbBkfi-N11jorHA@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/aW8keI6WZxywRQIt%40paquier.xyz>
Precedence: bulk


--XB7Az5dvfReirtgS
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Dec 31, 2025 at 04:02:24PM +0100, Dharin Shah wrote:
> Let me know what you=E2=80=99d prefer for next steps: keep this patch as a
> detoast-local refactor, or respin it to align more directly with a shared
> decoded external-pointer interface in the direction of the 8=E2=80=91byte=
 work.

My apologies for the rather long silence on this thread.  As the next
step of this project, I am going to put my hands of what you are
suggesting here, and see how I can align it with the 64-bit toast
value patch:
https://www.postgresql.org/message-id/CAOj6k6dEVi0NvLjMLDhyrJS_n_NZO5D_OU89=
AO1u53u6NCDDwQ@mail.gmail.com

What I am pretty sure about at this stage is that there is little love
for the patch set I have sent on the other thread where I have been
using pointer redirections for the TOAST function calls with
callbacks (perhaps I'll be able to apply some of the renaming patches
anyway, nobody would scream at me for that), at least nobody has put a
+1 on it or just ignored it, so this approach feels dead to me.  What
you are suggesting upthread, though, is a direction I'd like to dig
into and this comes down to how I can unify what you want to do for
zstd and what I want to do with Oid8.  Perhaps that you are right and
that it is just simpler to invest on an interface in the detoast code,
but I still see that there is nothing done for the logical decoding or
amcheck code paths, which is something my other patch is able to deal
with transparently.
--
Michael

--XB7Az5dvfReirtgS
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmlvJHgACgkQnvQgOdby
QH2JJQ//SVytlF6cVgsBgFU2LHvYQsGZRx+Iug9NzXvL60SqbI53uGHALxfVBuTR
OgZMHoBZX6ycmNy8thPktqitpQtts7J3QC4roCQJD6B/o4hDCL3HPPYmCfAjVypW
zI8dGzcsO4BYs6lWLt+npKFpY5J7h+f53i59UGhIZ+fjE8jbLofJOFYaaba5fUY0
bAff60hPZNR0P6Yy5gqn3x6vYCj1Whi5PmpjwwP4IAXDtPnXlNITOi0wdRLyd3VF
A0NQ6oRX623ee42bUAU7pYSd2LuCbAYStu8bGy9la9vvDQKsOW47JdjzruMMbvlz
E4HpZ1+ifgaztJNS5RyGgNLjUXdZe7APwHpK55Mt6GA66sFcknTCRzl9nSVFyCWC
wMkhto8BOBqaxu0du2aHBP9PkXtwTAwVH+jagL5sovSuYm++JO8qNcIiz2ZYwFF3
75b2VJ4ONiXn3rU7Qz4rldIDzp9tfrwxj1HdWYwlC+gwnlf2ynnIgyJPFRuQBg2j
8Hy3sj5IKvmQlJ95Utqw85jKcg+nSWCR6n8eZN7zdWj6I1NY1w0yN86SgDyBNCAq
NB8S9LAhRf75qIzW6br9Fpwzz9vWXFM6AedTtne/THvyH8Y8yIphHF5tnnOUptgr
1gNP5ACfydvHIJ10/FHm+6juPFfxVpTE07N2vTRAfbDIiv7X7KU=
=bkjt
-----END PGP SIGNATURE-----

--XB7Az5dvfReirtgS--