Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.80) (envelope-from ) id 1a8O1O-0002o3-Cc for pgadmin-hackers@arkaria.postgresql.org; Mon, 14 Dec 2015 07:58:14 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84) (envelope-from ) id 1a8O1N-00077g-SK for pgadmin-hackers@arkaria.postgresql.org; Mon, 14 Dec 2015 07:58:13 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84) (envelope-from ) id 1a8Nuk-0004DC-CI for pgadmin-hackers@postgresql.org; Mon, 14 Dec 2015 07:51:22 +0000 Received: from imp-m.ru ([93.174.79.86]) by makus.postgresql.org with esmtp (Exim 4.84) (envelope-from ) id 1a8Nug-0004zI-Lh for pgadmin-hackers@postgresql.org; Mon, 14 Dec 2015 07:51:20 +0000 Received: by imp-m.ru (Postfix, from userid 80) id 5868673F4890; Mon, 14 Dec 2015 10:51:15 +0300 (MSK) To: Dmitriy Olshevskiy Subject: Re: patch: fix to use =?UTF-8?Q?=60=60pg=5Fget?= =?UTF-8?Q?=5Ffunctiondef=28=29=60=60?= X-PHP-Originating-Script: 0:rcube.php MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Mon, 14 Dec 2015 10:51:15 +0300 From: Andrej Antonov Cc: pgadmin-hackers@postgresql.org In-Reply-To: <566D8914.2070507@bk.ru> References: <8214ef66e4cf3dc04bd99a0af601e5ab@imp-m.ru> <566D8914.2070507@bk.ru> Message-ID: X-Sender: antonov@imp-m.ru User-Agent: Roundcube Webmail/1.0.3 X-Pg-Spam-Score: -1.9 (-) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org thank you, Dmitriy. I agree -- this-fix should works better. I applyed this-fix to my local-git-branches ("REL-1_20_0-impulsm" and "fix-to-use-pg_get_functiondef"). works good. Dmitriy Olshevskiy писал 2015-12-13 18:04: > Hi, Andrej! > Here is small fix of your patch - can you check it please? > I think there must be wxwidgets function IsEmpty() instead of double > negation, > because type of the variable is wxstring. Also I added the Trim() > function before > check if function definition is empty or not. > > On 08.12.2015 11:50, Andrej Antonov wrote: > >> patch: fix to use ``pg_get_functiondef()`` [see attachment file] >> >> it is copy of pull-request >> https://github.com/postgres/pgadmin3/pull/12 [1] >> >> thank you! > > -- > Dmitriy Olshevskiy > > > Links: > ------ > [1] https://github.com/postgres/pgadmin3/pull/12 -- Андрей Антонов, инженер-программист отдела информационных технологий и программирования, компания «Импульс М» -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers