public inbox for [email protected]  
help / color / mirror / Atom feed
From: Andrej Antonov <[email protected]>
To: Akshay Joshi <[email protected]>
Cc: Dave Page <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: patch: fixing dublicates foreign-tables
Date: Tue, 08 Dec 2015 13:53:42 +0300
Message-ID: <[email protected]> (raw)
In-Reply-To: <CANxoLDe=xsFLwxEhP5XvEym2jsOHEanyPUW9JgRnwJ7Oy0LaJg@mail.gmail.com>
References: <[email protected]>
	<CA+OCxowu1E6ObUsYea+uxYa5rx+2HQg0Z7byOGX5hwpa0r-Crg@mail.gmail.com>
	<CANxoLDc2mVbjvE3gz6-+NzyBcq0CdmM2_hNNinT2hhGa_E0=9w@mail.gmail.com>
	<CANxoLDe=xsFLwxEhP5XvEym2jsOHEanyPUW9JgRnwJ7Oy0LaJg@mail.gmail.com>
List-Unsubscribe:  <mailto:[email protected]?body=unsub%20pgadmin-hackers>

hello, Akshay!

screenshot:

"Screenshot from 2015-12-08 13-43-54 with-labels.png" (as attachment 
file).

script to reproduce:



         CREATE FOREIGN DATA WRAPPER postgresql
           VALIDATOR postgresql_fdw_validator;

         CREATE SERVER film_server FOREIGN DATA WRAPPER postgresql 
OPTIONS (host 'foo', dbname 'foodb', port '5432');

         CREATE FOREIGN TABLE films1 (
             code        char(5) NOT NULL,
             title       varchar(40) NOT NULL,
             did         integer NOT NULL,
             date_prod   date,
             kind        varchar(10),
             len         interval hour to minute
         )
         SERVER film_server;

         CREATE FOREIGN TABLE films2 (
             code        char(5) NOT NULL,
             title       varchar(40) NOT NULL,
             did         integer NOT NULL,
             date_prod   date,
             kind        varchar(10),
             len         interval hour to minute
         )
         SERVER film_server;

         COMMENT ON FOREIGN TABLE films1 IS 'description A';
         COMMENT ON FOREIGN TABLE films2 IS 'description B';

         COMMENT ON COLUMN films1.code IS 'descr code A';
         COMMENT ON COLUMN films1.title IS 'descr title A';
         COMMENT ON COLUMN films1.did IS 'descr did A';
         COMMENT ON COLUMN films2.code IS 'descr code B';
         COMMENT ON COLUMN films2.title IS 'descr title B';
         COMMENT ON COLUMN films2.did IS 'descr did B';



Akshay Joshi писал 2015-12-08 13:21:
> Hi Andrej
> 
> Can you please share the reproduction step of the issue that you have
> fixed.
> 
> On Tue, Dec 8, 2015 at 11:15 AM, Akshay Joshi
> <[email protected]> wrote:
> 
>> On Tue, Dec 8, 2015 at 11:09 AM, Dave Page <[email protected]>
>> wrote:
>> 
>>> Akshay, can you review this please?
>> 
>> Sure, Dave.
>> 
>>> 2015-12-07 19:47 GMT+05:30 Andrej Antonov <[email protected]>:
>>>> fixing dublicates foreign-tables (see attachment file).
>>>> 
>>>> this email -- it is just copy of pull-request
>>>> https://github.com/postgres/pgadmin3/pull/11 [1] .
>>>> 
>>>> thanks in advance.
>>>> 
>>>> --
>>>> Андрей Антонов,
>>>> инженер-программист отдела
>>> информационных технологий и
>>> программирования,
>>>> компания «Импульс М»
>>>> 
>>>> --
>>>> Sent via pgadmin-hackers mailing list
>>> ([email protected])
>>>> To make changes to your subscription:
>>>> http://www.postgresql.org/mailpref/pgadmin-hackers [2]
>>>> 
>>> 
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com [3]
>>> Twitter: @pgsnake
>>> 
>>> EnterpriseDB UK: http://www.enterprisedb.com [4]
>>> The Enterprise PostgreSQL Company
>> 
>> --
>> 
>> AKSHAY JOSHI
>> PRINCIPAL SOFTWARE ENGINEER
>> 
>> Phone: +91 20-3058-9517
>> Mobile: +91 976-788-8246
> 
> --
> 
> AKSHAY JOSHI
> PRINCIPAL SOFTWARE ENGINEER
> 
> Phone: +91 20-3058-9517
> Mobile: +91 976-788-8246
> 
> Links:
> ------
> [1] https://github.com/postgres/pgadmin3/pull/11
> [2] http://www.postgresql.org/mailpref/pgadmin-hackers
> [3] http://pgsnake.blogspot.com
> [4] http://www.enterprisedb.com

-- 
Андрей Антонов,
инженер-программист отдела информационных технологий и программирования,
компания «Импульс М»

-- 
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Attachments:

  [image/png] Screenshot from 2015-12-08 13-43-54 with-labels.png (202.3K, 2-Screenshot%20from%202015-12-08%2013-43-54%20with-labels.png)
  download | view image

view thread (6+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: patch: fixing dublicates foreign-tables
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox