Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qyqUE-00BVko-5T for pgadmin-hackers@arkaria.postgresql.org; Fri, 03 Nov 2023 09:29:06 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1qyqUC-00HPMp-LY for pgadmin-hackers@arkaria.postgresql.org; Fri, 03 Nov 2023 09:29:04 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qyqUC-00HPMh-Di for pgadmin-hackers@lists.postgresql.org; Fri, 03 Nov 2023 09:29:04 +0000 Received: from out-24.smtp.github.com ([192.30.252.207]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qyqU9-003k3S-Sx for pgadmin-hackers@lists.postgresql.org; Fri, 03 Nov 2023 09:29:03 +0000 Received: from github.com (hubbernetes-node-c4c0bdc.ac4-iad.github.net [10.52.125.80]) by smtp.github.com (Postfix) with ESMTPA id 9C5311E057B for ; Fri, 3 Nov 2023 02:29:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2023; t=1699003740; bh=KFMAxhOHuuVnQiCXZnp9M/HUFgCdHo9P1skQr9oPEsw=; h=Date:From:To:Subject:From; b=JssZuqcroNI4kQyxTeVte6K6l6EmPdffQnEX0B2JfNl0HFIHoCyXeB9XUmVqjkIS9 tKq+KaoVZpEXHAHulid3dRRdTtl4MbW12ObwcBkmqaJuv6/WbB3JU8wZH2nDWpjNYS EVMiwdVtD4K3dvcezpmDnYDmMafq4EQUgLsRv/0E= Date: Fri, 03 Nov 2023 02:29:00 -0700 From: Anil Sahoo To: pgadmin-hackers@lists.postgresql.org Message-ID: Subject: [pgadmin-org/pgadmin4] 606208: Fixed the query generated when creating subscripti... Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-GitHub-Recipient-Address: pgadmin-hackers@lists.postgresql.org X-Auto-Response-Suppress: All List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Branch: refs/heads/master Home: https://github.com/pgadmin-org/pgadmin4 Commit: 6062084128a69991cee6cf927dfed94935e878f0 https://github.com/pgadmin-org/pgadmin4/commit/6062084128a69991cee6cf927dfed94935e878f0 Author: Anil Sahoo Date: 2023-11-03 (Fri, 03 Nov 2023) Changed paths: M web/pgadmin/browser/server_groups/servers/databases/publications/__init__.py M web/pgadmin/browser/server_groups/servers/databases/publications/static/js/publication.ui.js M web/pgadmin/browser/server_groups/servers/databases/subscriptions/__init__.py M web/pgadmin/browser/server_groups/servers/databases/subscriptions/static/js/subscription.ui.js M web/pgadmin/browser/server_groups/servers/databases/subscriptions/templates/subscriptions/sql/14_plus/create.sql M web/pgadmin/browser/server_groups/servers/databases/subscriptions/templates/subscriptions/sql/15_plus/create.sql M web/pgadmin/browser/server_groups/servers/databases/subscriptions/templates/subscriptions/sql/16_plus/create.sql M web/pgadmin/browser/server_groups/servers/databases/subscriptions/templates/subscriptions/sql/default/create.sql M web/pgadmin/browser/server_groups/servers/databases/subscriptions/templates/subscriptions/sql/default/get_position.sql M web/pgadmin/browser/server_groups/servers/databases/subscriptions/tests/14_plus/create_subscription_msql.sql M web/pgadmin/browser/server_groups/servers/databases/subscriptions/tests/14_plus/test.json M web/pgadmin/browser/server_groups/servers/databases/subscriptions/tests/15_plus/alter_parameters.sql M web/pgadmin/browser/server_groups/servers/databases/subscriptions/tests/15_plus/create_subscription.sql M web/pgadmin/browser/server_groups/servers/databases/subscriptions/tests/15_plus/create_subscription_msql.sql M web/pgadmin/browser/server_groups/servers/databases/subscriptions/tests/15_plus/test.json M web/pgadmin/browser/server_groups/servers/databases/subscriptions/tests/16_plus/alter_parameters.sql M web/pgadmin/browser/server_groups/servers/databases/subscriptions/tests/16_plus/create_subscription.sql M web/pgadmin/browser/server_groups/servers/databases/subscriptions/tests/16_plus/create_subscription_msql.sql M web/pgadmin/browser/server_groups/servers/databases/subscriptions/tests/16_plus/test.json M web/pgadmin/browser/server_groups/servers/databases/subscriptions/tests/default/alter_maintenance_db.sql M web/pgadmin/browser/server_groups/servers/databases/subscriptions/tests/default/alter_maintenance_db_msql.sql M web/pgadmin/browser/server_groups/servers/databases/subscriptions/tests/default/alter_subscription.sql M web/pgadmin/browser/server_groups/servers/databases/subscriptions/tests/default/alter_sync.sql M web/pgadmin/browser/server_groups/servers/databases/subscriptions/tests/default/create_subscription.sql M web/pgadmin/browser/server_groups/servers/databases/subscriptions/tests/default/create_subscription_msql.sql M web/pgadmin/browser/server_groups/servers/databases/subscriptions/tests/default/test.json Log Message: ----------- Fixed the query generated when creating subscription where copy_data parameter was missing. #6817