MIME-Version: 1.0
References: 
 <CAJRqHcJpf2thrFTw_092nGWAvU3Du9_eXbOOG62U9oBZOUpLgg@mail.gmail.com>
In-Reply-To: 
 <CAJRqHcJpf2thrFTw_092nGWAvU3Du9_eXbOOG62U9oBZOUpLgg@mail.gmail.com>
From: Dave Page <dpage@pgadmin.org>
Date: Mon, 28 Jul 2025 14:57:53 +0100
Message-ID: 
 <CA+OCxox8fKAwNObF=LeW7b1oA+nLyg3g8MmJ1ftMe-yyqeXNvQ@mail.gmail.com>
Subject: Re: Request to Remove Unused xmin Column from Function Properties
 Queries
To: Abhinav Patni <abhinavpatni602@gmail.com>
Cc: pgadmin-support@lists.postgresql.org
Content-Type: multipart/alternative; boundary="000000000000619df1063afdae9e"
Archived-At: 
 <https://www.postgresql.org/message-id/CA%2BOCxox8fKAwNObF%3DLeW7b1oA%2BnLyg3g8MmJ1ftMe-yyqeXNvQ%40mail.gmail.com>
Precedence: bulk

--000000000000619df1063afdae9e
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi

On Mon, 28 Jul 2025 at 14:46, Abhinav Patni <abhinavpatni602@gmail.com>
wrote:

> Dear pgAdmin Team,
>
> Queries for the xmin system column are causing errors and breaking
> function/property dialogs.


What errors or breakage do you see, and in what circumstances? Querying for
xmin shouldn't cause any issues on any supported PostgreSQL version, even
if it's not used.


> I see xmin is fetched in property queries
> (e.g.,=E2=80=AFfunctions/templates/*/properties.sql) but is always ignore=
d in
> processing, as in:
>
>
> web/pgadmin/browser/server_groups/servers/databases/schemas/functions/ini=
t.py:
> keys_to_ignore =3D ['oid', 'proowner', 'typnsp', 'xmin', =E2=80=A6]
>
> Can we drop xmin from these queries? Are there reasons to keep it? If
> not, would you accept a patch to remove it?
>
> Thanks,
> Abhinav Patni
>
>
>

--=20
Dave Page
pgAdmin: https://www.pgadmin.org
PostgreSQL: https://www.postgresql.org
pgEdge: https://www.pgedge.com

--000000000000619df1063afdae9e
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div>Hi</div><br><div class=3D"gmail_quote gmail_quote_con=
tainer"><div dir=3D"ltr" class=3D"gmail_attr">On Mon, 28 Jul 2025 at 14:46,=
 Abhinav Patni &lt;<a href=3D"mailto:abhinavpatni602@gmail.com">abhinavpatn=
i602@gmail.com</a>&gt; wrote:<br></div><blockquote class=3D"gmail_quote" st=
yle=3D"margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:sol=
id;border-left-color:rgb(204,204,204);padding-left:1ex">Dear pgAdmin Team,<=
br>
<br>
Queries for the xmin system column are causing errors and breaking<br>
function/property dialogs. </blockquote><div><br></div><div>What errors or =
breakage do you see, and in what circumstances? Querying for xmin shouldn&#=
39;t cause any issues on any supported PostgreSQL version, even if it&#39;s=
 not used.</div><div>=C2=A0</div><blockquote class=3D"gmail_quote" style=3D=
"margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;bor=
der-left-color:rgb(204,204,204);padding-left:1ex">I see xmin is fetched in =
property queries<br>
(e.g.,=E2=80=AFfunctions/templates/*/properties.sql) but is always ignored =
in<br>
processing, as in:<br>
<br>
web/pgadmin/browser/server_groups/servers/databases/schemas/functions/init.=
py:<br>
keys_to_ignore =3D [&#39;oid&#39;, &#39;proowner&#39;, &#39;typnsp&#39;, &#=
39;xmin&#39;, =E2=80=A6]<br>
<br>
Can we drop xmin from these queries? Are there reasons to keep it? If<br>
not, would you accept a patch to remove it?<br>
<br>
Thanks,<br>
Abhinav Patni<br>
<br>
<br>
</blockquote></div><div><br clear=3D"all"></div><div><br></div><span class=
=3D"gmail_signature_prefix">-- </span><br><div dir=3D"ltr" class=3D"gmail_s=
ignature"><div dir=3D"ltr">Dave Page<div>pgAdmin: <a href=3D"https://www.pg=
admin.org" target=3D"_blank">https://www.pgadmin.org</a></div><div>PostgreS=
QL: <a href=3D"https://www.postgresql.org" target=3D"_blank">https://www.po=
stgresql.org</a></div><div>pgEdge: <a href=3D"https://www.pgedge.com" targe=
t=3D"_blank">https://www.pgedge.com</a><br><div></div><div><br></div></div>=
</div></div></div>

--000000000000619df1063afdae9e--