pg.ddx.io pgbackrest/pgbackrest GitHub issues and pull requests
help / color / mirror / Atom feed[pgbackrest/pgbackrest] PR #2922: Require the zstd library.
10+ messages / 2 participants
[nested] [flat]
* [pgbackrest/pgbackrest] PR #2922: Require the zstd library.
@ 2026-11-16 15:46 "dwsteele (@dwsteele)" <noreply+dwsteele@github.com>
0 siblings, 0 replies; 10+ messages in thread
From: dwsteele (@dwsteele) @ 2026-11-16 15:46 UTC (permalink / raw)
To: pgbackrest/pgbackrest <noreply+pgbackrest-pgbackrest@github.com>
zstd will be the default compression type in format 6 so it must be present in every build.
Make zstd required in meson, remove the libzstd option, and remove conditional compilation for zstd.
lz4 and zstd are now both required so remove the compress-type help caveat that they are not available on all platforms and allow all compression types in the storage harness.
I checked with @df7cb and @devrimgunduz and they were in favor of it.
^ permalink raw [nested|flat] 10+ messages in thread
* Re: [pgbackrest/pgbackrest] PR #2922: Require the zstd library.
@ 2026-11-16 15:46 ` "dwsteele (@dwsteele)" <noreply+dwsteele@github.com>
8 siblings, 0 replies; 10+ messages in thread
From: dwsteele (@dwsteele) @ 2026-11-16 15:46 UTC (permalink / raw)
To: pgbackrest/pgbackrest <noreply+pgbackrest-pgbackrest@github.com>
@dwsteele assigned @dwsteele.
^ permalink raw [nested|flat] 10+ messages in thread
* Re: [pgbackrest/pgbackrest] PR #2922: Require the zstd library.
@ 2026-11-16 15:47 ` "dwsteele (@dwsteele)" <noreply+dwsteele@github.com>
8 siblings, 0 replies; 10+ messages in thread
From: dwsteele (@dwsteele) @ 2026-11-16 15:47 UTC (permalink / raw)
To: pgbackrest/pgbackrest <noreply+pgbackrest-pgbackrest@github.com>
@dwsteele applied label "enhancement".
^ permalink raw [nested|flat] 10+ messages in thread
* Re: [pgbackrest/pgbackrest] PR #2922: Require the zstd library.
@ 2026-11-16 15:47 ` "dwsteele (@dwsteele)" <noreply+dwsteele@github.com>
8 siblings, 0 replies; 10+ messages in thread
From: dwsteele (@dwsteele) @ 2026-11-16 15:47 UTC (permalink / raw)
To: pgbackrest/pgbackrest <noreply+pgbackrest-pgbackrest@github.com>
@dwsteele applied label "module [core]".
^ permalink raw [nested|flat] 10+ messages in thread
* Re: [pgbackrest/pgbackrest] PR #2922: Require the zstd library.
@ 2026-11-16 15:47 ` "dwsteele (@dwsteele)" <noreply+dwsteele@github.com>
8 siblings, 0 replies; 10+ messages in thread
From: dwsteele (@dwsteele) @ 2026-11-16 15:47 UTC (permalink / raw)
To: pgbackrest/pgbackrest <noreply+pgbackrest-pgbackrest@github.com>
@dwsteele set milestone to "2.61.0".
^ permalink raw [nested|flat] 10+ messages in thread
* Re: [pgbackrest/pgbackrest] PR #2922 (approved): Require the zstd library.
@ 2026-11-17 09:34 ` "pgstef (@pgstef)" <noreply+pgstef@github.com>
8 siblings, 0 replies; 10+ messages in thread
From: pgstef (@pgstef) @ 2026-11-17 09:34 UTC (permalink / raw)
To: pgbackrest/pgbackrest <noreply+pgbackrest-pgbackrest@github.com>
The PR looks good to me 👍
One small nitpick: perhaps we should also update the `compress-type` help text in `doc/xml/reference.xml`, which still describes `zst` as "not available on all platforms".
We could remove that caveat for both `zst` and `lz4` (which is already required), then regenerate the help text.
The comment in `test/src/harness/storage.h` stating that "lz4 and zstd are not always available" could also be updated while we're at it.
^ permalink raw [nested|flat] 10+ messages in thread
* Re: [pgbackrest/pgbackrest] PR #2922: Require the zstd library.
@ 2026-11-17 14:08 ` "dwsteele (@dwsteele)" <noreply+dwsteele@github.com>
8 siblings, 0 replies; 10+ messages in thread
From: dwsteele (@dwsteele) @ 2026-11-17 14:08 UTC (permalink / raw)
To: pgbackrest/pgbackrest <noreply+pgbackrest-pgbackrest@github.com>
> We could remove that caveat for both zst and lz4 (which is already required), then regenerate the help text.
Done in 8311df33a9d01.
> The comment in test/src/harness/storage.h stating that "lz4 and zstd are not always available" could also be updated while we're at it.
Also done in 8311df33a9d01 and removed asserts that prevented lz4/zstd from being used in unit tests.
^ permalink raw [nested|flat] 10+ messages in thread
* Re: [pgbackrest/pgbackrest] PR #2922: Require the zstd library.
@ 2026-11-17 14:17 ` "pgstef (@pgstef)" <noreply+pgstef@github.com>
8 siblings, 0 replies; 10+ messages in thread
From: pgstef (@pgstef) @ 2026-11-17 14:17 UTC (permalink / raw)
To: pgbackrest/pgbackrest <noreply+pgbackrest-pgbackrest@github.com>
> Also done in [8311df3](https://github.com/pgbackrest/pgbackrest/commit/8311df33a9d018d132aea77691fa74f256c36e4a) and removed asserts that prevented lz4/zstd from being used in unit tests.
Looks good to me :+1: Thanks :-)
^ permalink raw [nested|flat] 10+ messages in thread
* Re: [pgbackrest/pgbackrest] PR #2922: Require the zstd library.
@ 2026-11-17 14:47 ` "dwsteele (@dwsteele)" <noreply+dwsteele@github.com>
8 siblings, 0 replies; 10+ messages in thread
From: dwsteele (@dwsteele) @ 2026-11-17 14:47 UTC (permalink / raw)
To: pgbackrest/pgbackrest <noreply+pgbackrest-pgbackrest@github.com>
@dwsteele closed this.
^ permalink raw [nested|flat] 10+ messages in thread
* Re: [pgbackrest/pgbackrest] PR #2922: Require the zstd library.
@ 2026-11-17 14:47 ` "dwsteele (@dwsteele)" <noreply+dwsteele@github.com>
8 siblings, 0 replies; 10+ messages in thread
From: dwsteele (@dwsteele) @ 2026-11-17 14:47 UTC (permalink / raw)
To: pgbackrest/pgbackrest <noreply+pgbackrest-pgbackrest@github.com>
@dwsteele merged this (commit 0f643491029a).
^ permalink raw [nested|flat] 10+ messages in thread
end of thread, other threads:[~2026-11-17 14:47 UTC | newest]
Thread overview: 10+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2026-11-16 15:46 [pgbackrest/pgbackrest] PR #2922: Require the zstd library. "dwsteele (@dwsteele)" <noreply+dwsteele@github.com>
2026-11-16 15:46 ` "dwsteele (@dwsteele)" <noreply+dwsteele@github.com>
2026-11-16 15:47 ` "dwsteele (@dwsteele)" <noreply+dwsteele@github.com>
2026-11-16 15:47 ` "dwsteele (@dwsteele)" <noreply+dwsteele@github.com>
2026-11-16 15:47 ` "dwsteele (@dwsteele)" <noreply+dwsteele@github.com>
2026-11-17 09:34 ` Re: [pgbackrest/pgbackrest] PR #2922 (approved): Require the zstd library. "pgstef (@pgstef)" <noreply+pgstef@github.com>
2026-11-17 14:08 ` "dwsteele (@dwsteele)" <noreply+dwsteele@github.com>
2026-11-17 14:17 ` "pgstef (@pgstef)" <noreply+pgstef@github.com>
2026-11-17 14:47 ` "dwsteele (@dwsteele)" <noreply+dwsteele@github.com>
2026-11-17 14:47 ` "dwsteele (@dwsteele)" <noreply+dwsteele@github.com>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox