pg.ddx.io  pgdogdev/pgdog GitHub issues and pull requests  
help / color / mirror / Atom feed
[pgdogdev/pgdog] PR #2069: refactor(frontend): carry comment spans on ClientRequest
6+ messages / 3 participants
[nested] [flat]

* [pgdogdev/pgdog] PR #2069: refactor(frontend): carry comment spans on ClientRequest
@ 2026-11-19 11:08  "murex971 (@murex971)" <noreply+murex971@github.com>
  0 siblings, 0 replies; 6+ messages in thread

From: murex971 (@murex971) @ 2026-11-19 11:08 UTC (permalink / raw)
  To: pgdogdev/pgdog <noreply+pgdogdev-pgdog@github.com>


`parse_request` now copies the comment spans from the parsed `ClientQuery`
onto `ClientRequest` (`comment_spans`), alongside `routing_comment`.

### Why

The spans were recorded on `ClientQuery`
but dropped in `parse_request`, so nothing downstream could use them.
Enterprise QoS reads them from the request to avoid scanning the query for
comments a second time when the query parser is on.

^ permalink  raw  [nested|flat] 6+ messages in thread

* Re: [pgdogdev/pgdog] PR #2069: refactor(frontend): carry comment spans on ClientRequest
@ 2026-11-19 11:11  "codecov[bot] (bot) (@codecov[bot])" <noreply+codecov[bot]@github.com>
  4 siblings, 0 replies; 6+ messages in thread

From: codecov[bot] (bot) (@codecov[bot]) @ 2026-11-19 11:11 UTC (permalink / raw)
  To: pgdogdev/pgdog <noreply+pgdogdev-pgdog@github.com>

## [Codecov](https://app.codecov.io/gh/pgdogdev/pgdog/pull/2069?dropdown=coverage&src=pr&el=h1&utm_me...) Report
:white_check_mark: All modified and coverable lines are covered by tests.

:loudspeaker: Thoughts on this report? [Let us know!](https://github.com/codecov/feedback/issues/255)

^ permalink  raw  [nested|flat] 6+ messages in thread

* Re: [pgdogdev/pgdog] PR #2069: refactor(frontend): carry comment spans on ClientRequest
@ 2026-11-19 11:30  "murex971 (@murex971)" <noreply+murex971@github.com>
  4 siblings, 0 replies; 6+ messages in thread

From: murex971 (@murex971) @ 2026-11-19 11:30 UTC (permalink / raw)
  To: pgdogdev/pgdog <noreply+pgdogdev-pgdog@github.com>

@murex971 closed this.

^ permalink  raw  [nested|flat] 6+ messages in thread

* Re: [pgdogdev/pgdog] PR #2069: refactor(frontend): carry comment spans on ClientRequest
@ 2026-11-19 11:30  "murex971 (@murex971)" <noreply+murex971@github.com>
  4 siblings, 0 replies; 6+ messages in thread

From: murex971 (@murex971) @ 2026-11-19 11:30 UTC (permalink / raw)
  To: pgdogdev/pgdog <noreply+pgdogdev-pgdog@github.com>

@murex971 merged this (commit 14160e088e7d).

^ permalink  raw  [nested|flat] 6+ messages in thread

* Re: [pgdogdev/pgdog] PR #2069: refactor(frontend): carry comment spans on ClientRequest
@ 2026-11-19 11:45  "github-actions[bot] (bot) (@github-actions[bot])" <noreply+github-actions[bot]@github.com>
  4 siblings, 0 replies; 6+ messages in thread

From: github-actions[bot] (bot) (@github-actions[bot]) @ 2026-11-19 11:45 UTC (permalink / raw)
  To: pgdogdev/pgdog <noreply+pgdogdev-pgdog@github.com>

<!-- metal-bench -->

**Metal bench (arm64) failed.** 48 of 520 measures outside bounds.

| suite | throughput | cpu/txn | user cycles/txn | user instr/txn | kernel cycles/txn | kernel instr/txn | ctx/txn |
|---|---|---|---|---|---|---|---|
| pooler |  | 18.94 (+0.2% ± 1.7%) | 17,871 (-0.7% ± 1.1%) | 31,448 (+0.1% ± 0.1%) | 30,615 (+1.0% ± 2.6%) | 51,158 (+0.3% ± 0.4%) |  |
| lb |  | 19.48 (-0.2% ± 1.3%) | 18,604 (+0.1% ± 0.7%) | 32,362 (+0.1% ± 0.03%) | 31,022 (-0.3% ± 2.1%) | 52,216 (+0.0% ± 0.4%) |  |
| sharding-w2 |  | 33.8 (+2.0% ± 1.0%) | 45,537 (+1.6% ± 1.0%) | 94,918 (+0.0% ± 0.01%) | 42,459 (+2.0% ± 2.0%) | 53,756 (-0.0% ± 0.08%) | 1.54 (-0.1% ± 0.6%) |
| sharding-w8 | 234,538 (-1.4% ± 0.8%) | 30.71 (+1.3% ± 0.8%) | 45,708 (+0.6% ± 1.6%) | 50,541 (+0.1% ± 0.2%) | 39,190 (+2.0% ± 0.7%) | 42,397 (+0.1% ± 0.09%) | 0.1595 (+0.4% ± 3.0%) |

<details><summary>Counters per txn</summary>

| suite | frontend stall | l1i refill | backend stall |
|---|---|---|---|
| pooler | 7,520 (-1.9% ± 3.1%) | 2,669 (-1.2% ± 1.4%) |  |
| lb | 8,023 (+0.3% ± 1.6%) | 2,743 (-0.2% ± 0.7%) |  |
| sharding-w2 | 20,584 (+3.4% ± 3.1%) | 4,529 (+2.6% ± 1.6%) |  |
| sharding-w8 | 22,986 (+3.3% ± 2.9%) | 4,532 (+3.0% ± 1.8%) |  |
</details>

| benchmark | measure | result | baseline | change | bound |
|---|---|---|---|---|---|
| extended_cached::aggregate | instructions | 17,601 | 17,395 | **+1.18% ± 0.00%** | +1% |
| extended_cached::insert_split | alloc_bytes | 7,026 | 6,834 | **+2.81% ± 0.00%** | +1% |
| extended_cold::insert_split | alloc_bytes | 9,362 | 9,170 | **+2.09% ± 0.00%** | +1% |
| extended_evicting::insert_split | alloc_bytes | 9,242 | 9,050 | **+2.12% ± 0.00%** | +1% |
| full_extended_cached::cte | alloc_bytes | 7,447 | 7,351 | **+1.31% ± 0.00%** | +1% |
| full_extended_cached::delete_all_shards | alloc_bytes | 12,960 | 12,820 | **+1.09% ± 0.00%** | +1% |
| full_extended_cached::delete_by_key | alloc_bytes | 6,374 | 6,278 | **+1.53% ± 0.00%** | +1% |
| full_extended_cached::insert | alloc_bytes | 6,328 | 6,232 | **+1.54% ± 0.00%** | +1% |
| full_extended_cached::insert_returning | alloc_bytes | 6,394 | 6,298 | **+1.52% ± 0.00%** | +1% |
| full_extended_cached::insert_split | alloc_bytes | 15,610 | 15,270 | **+2.23% ± 0.00%** | +1% |
| full_extended_cached::insert_split | instructions | 97,028 | 94,408 | **+2.78% ± 0.00%** | +1% |
| full_extended_cached::join | alloc_bytes | 7,853 | 7,757 | **+1.24% ± 0.00%** | +1% |
| full_extended_cached::lookup | alloc_bytes | 7,155 | 7,059 | **+1.36% ± 0.00%** | +1% |
| full_extended_cached::select_by_key | alloc_bytes | 7,123 | 7,027 | **+1.37% ± 0.00%** | +1% |
| full_extended_cached::select_omni | alloc_bytes | 6,603 | 6,507 | **+1.48% ± 0.00%** | +1% |
| full_extended_cached::update_all_shards | alloc_bytes | 13,000 | 12,860 | **+1.09% ± 0.00%** | +1% |
| full_extended_cached::update_by_key | alloc_bytes | 6,396 | 6,300 | **+1.52% ± 0.00%** | +1% |
| full_named_cached::aggregate | instructions | 136,185 | 134,369 | **+1.35% ± 0.00%** | +1% |
| full_named_cached::cte | alloc_bytes | 7,324 | 7,228 | **+1.33% ± 0.00%** | +1% |
| full_named_cached::delete_all_shards | alloc_bytes | 12,840 | 12,700 | **+1.10% ± 0.00%** | +1% |
| full_named_cached::delete_by_key | alloc_bytes | 6,281 | 6,185 | **+1.55% ± 0.00%** | +1% |
| full_named_cached::insert | alloc_bytes | 6,221 | 6,125 | **+1.57% ± 0.00%** | +1% |
| full_named_cached::insert_returning | alloc_bytes | 6,274 | 6,178 | **+1.55% ± 0.00%** | +1% |
| full_named_cached::insert_split | alloc_bytes | 14,980 | 14,650 | **+2.25% ± 0.00%** | +1% |
| full_named_cached::join | alloc_bytes | 7,720 | 7,624 | **+1.26% ± 0.00%** | +1% |
| full_named_cached::lookup | alloc_bytes | 7,045 | 6,949 | **+1.38% ± 0.00%** | +1% |
| full_named_cached::select_all_shards | alloc_bytes | 14,220 | 14,070 | **+1.07% ± 0.00%** | +1% |
| full_named_cached::select_by_key | alloc_bytes | 7,029 | 6,933 | **+1.38% ± 0.00%** | +1% |
| full_named_cached::select_omni | alloc_bytes | 6,517 | 6,421 | **+1.50% ± 0.00%** | +1% |
| full_named_cached::update_all_shards | alloc_bytes | 12,860 | 12,720 | **+1.10% ± 0.00%** | +1% |
| full_named_cached::update_by_key | alloc_bytes | 6,293 | 6,197 | **+1.55% ± 0.00%** | +1% |
| full_simple::cte | alloc_bytes | 7,486 | 7,390 | **+1.30% ± 0.00%** | +1% |
| full_simple::delete_all_shards | alloc_bytes | 12,010 | 11,870 | **+1.18% ± 0.00%** | +1% |
| full_simple::delete_by_key | alloc_bytes | 6,361 | 6,265 | **+1.53% ± 0.00%** | +1% |
| full_simple::insert | alloc_bytes | 6,747 | 6,651 | **+1.44% ± 0.00%** | +1% |
| full_simple::insert_returning | alloc_bytes | 6,879 | 6,783 | **+1.42% ± 0.00%** | +1% |
| full_simple::insert_split | alloc_bytes | 15,770 | 15,430 | **+2.20% ± 0.00%** | +1% |
| full_simple::join | alloc_bytes | 7,897 | 7,801 | **+1.23% ± 0.00%** | +1% |
| full_simple::select_all_shards | alloc_bytes | 13,440 | 13,300 | **+1.05% ± 0.00%** | +1% |
| full_simple::select_by_key | alloc_bytes | 7,166 | 7,070 | **+1.36% ± 0.00%** | +1% |

Microbench: 459 of 507 measures within bounds. See verdict.json for the rest.

<details><summary>Microbench latency: 2 benches changed more than 3%</summary>

| benchmark | latency | baseline | change | instructions change |
|---|---|---|---|---|
| extended_cached::select_by_key | 2,202 ns | 2,122 ns | +3.77% ± 0.35% | +0.19% ± 0.00% |
| extended_cached::subquery | 2,326 ns | 2,248 ns | +3.50% ± 0.36% | +0.16% ± 0.00% |
</details>

<details><summary>Hot code per txn</summary>

| path | base | head | change |
|---|---|---|---|
| pooler | 113.4 KB | 113.8 KB | **+0.4 KB** |
| sharding-w2 | 169.2 KB | 168.7 KB | **-0.6 KB** |

pooler:

| crate | base | head | change |
|---|---|---|---|
| pgdog::frontend::client::query_engine | 20.1 KB | 20.6 KB | +0.4 KB |
| tokio | 18.5 KB | 18.3 KB | -0.2 KB |
| pgdog::backend::pool | 17.8 KB | 17.6 KB | -0.2 KB |
| aws-lc (TLS crypto) | 10.2 KB | 10.3 KB | +0.1 KB |
| rustls (TLS) | 8.3 KB | 8.3 KB | +0.0 KB |
| pgdog::frontend (other) | 7.9 KB | 7.9 KB | +0.0 KB |
| pgdog::backend::server | 7.8 KB | 7.6 KB | -0.1 KB |
| other | 5.9 KB | 6.1 KB | +0.2 KB |
| everything else | 16.9 KB | 17.1 KB | +0.2 KB |

| function | head | change |
|---|---|---|
| `pgdog::frontend::client::Client::run::{{closure}}` | 5.5 KB | -0.1 KB |
| `pgdog::frontend::client::query_engine::query::<impl pgdog::frontend::client::query_engine:` | 5.4 KB | +0.1 KB |
| `pgdog::frontend::client::query_engine::QueryEngine::handle::{{closure}}` | 4.4 KB | +0.4 KB |
| `pgdog::frontend::client::query_engine::query::<impl pgdog::frontend::client::query_engine:` | 3.4 KB | +0.1 KB |
| `tokio::runtime::task::raw::poll` | 3.2 KB | +0.0 KB |

sharding-w2:

| crate | base | head | change |
|---|---|---|---|
| pgdog::frontend::router | 29.4 KB | 29.4 KB | +0.0 KB |
| pgdog::frontend::client::query_engine | 21.6 KB | 21.8 KB | +0.2 KB |
| tokio | 18.4 KB | 18.8 KB | +0.4 KB |
| pgdog::backend::pool | 18.5 KB | 18.3 KB | -0.2 KB |
| aws-lc (TLS crypto) | 13.1 KB | 13.1 KB | +0.0 KB |
| other | 10.4 KB | 10.1 KB | -0.3 KB |
| pgdog::frontend (other) | 9.0 KB | 8.9 KB | -0.1 KB |
| rustls (TLS) | 8.3 KB | 8.3 KB | +0.0 KB |
| everything else | 40.6 KB | 40.1 KB | -0.6 KB |

| function | head | change |
|---|---|---|
| `pgdog::frontend::client::Client::run::{{closure}}` | 6.3 KB | -0.1 KB |
| `pgdog::frontend::client::query_engine::query::<impl pgdog::frontend::client::query_engine:` | 5.2 KB | +0.1 KB |
| `pgdog::frontend::client::query_engine::QueryEngine::handle::{{closure}}` | 4.1 KB | +0.1 KB |
| `pgdog::frontend::client::query_engine::query::<impl pgdog::frontend::client::query_engine:` | 3.4 KB | +0.0 KB |
| `tokio::runtime::task::raw::poll` | 3.3 KB | +0.2 KB |

</details>

<details><summary>lb flamegraph vs 73a9197f</summary>

![lb](https://pgdog-metal-bench.s3.amazonaws.com/results/murex-request-comment-spans/44f1616133f192301e66d...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/murex-request-comment-spans/44f1616133f192301e66d...) for hover, zoom and search.

![lb removed](https://pgdog-metal-bench.s3.amazonaws.com/results/murex-request-comment-spans/44f1616133f192301e66d...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/murex-request-comment-spans/44f1616133f192301e66d...).
</details>
<details><summary>microbench flamegraph vs 73a9197f</summary>

![microbench](https://pgdog-metal-bench.s3.amazonaws.com/results/murex-request-comment-spans/44f1616133f192301e66d...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/murex-request-comment-spans/44f1616133f192301e66d...) for hover, zoom and search.

![microbench removed](https://pgdog-metal-bench.s3.amazonaws.com/results/murex-request-comment-spans/44f1616133f192301e66d...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/murex-request-comment-spans/44f1616133f192301e66d...).
</details>
<details><summary>pooler flamegraph vs 73a9197f</summary>

![pooler](https://pgdog-metal-bench.s3.amazonaws.com/results/murex-request-comment-spans/44f1616133f192301e66d...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/murex-request-comment-spans/44f1616133f192301e66d...) for hover, zoom and search.

![pooler removed](https://pgdog-metal-bench.s3.amazonaws.com/results/murex-request-comment-spans/44f1616133f192301e66d...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/murex-request-comment-spans/44f1616133f192301e66d...).
</details>
<details><summary>sharding-w2 flamegraph vs 73a9197f</summary>

![sharding-w2](https://pgdog-metal-bench.s3.amazonaws.com/results/murex-request-comment-spans/44f1616133f192301e66d...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/murex-request-comment-spans/44f1616133f192301e66d...) for hover, zoom and search.

![sharding-w2 removed](https://pgdog-metal-bench.s3.amazonaws.com/results/murex-request-comment-spans/44f1616133f192301e66d...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/murex-request-comment-spans/44f1616133f192301e66d...).
</details>
<details><summary>sharding-w8 flamegraph vs 73a9197f</summary>

![sharding-w8](https://pgdog-metal-bench.s3.amazonaws.com/results/murex-request-comment-spans/44f1616133f192301e66d...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/murex-request-comment-spans/44f1616133f192301e66d...) for hover, zoom and search.

![sharding-w8 removed](https://pgdog-metal-bench.s3.amazonaws.com/results/murex-request-comment-spans/44f1616133f192301e66d...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results/murex-request-comment-spans/44f1616133f192301e66d...).
</details>

<details><summary>Logs</summary>

[lb](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results/murex-request-comment-s...), [microbench](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results/murex-request-comment-s...), [pooler](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results/murex-request-comment-s...), [sharding-w2](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results/murex-request-comment-s...), [sharding-w8](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results/murex-request-comment-s...), [verdict.json](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results/murex-request-comment-s...)
</details>

Compared 44f16161 with 73a9197f on m8g.metal-24xl (spot).


^ permalink  raw  [nested|flat] 6+ messages in thread

* Re: [pgdogdev/pgdog] PR #2069: refactor(frontend): carry comment spans on ClientRequest
@ 2026-11-19 11:45  "github-actions[bot] (bot) (@github-actions[bot])" <noreply+github-actions[bot]@github.com>
  4 siblings, 0 replies; 6+ messages in thread

From: github-actions[bot] (bot) (@github-actions[bot]) @ 2026-11-19 11:45 UTC (permalink / raw)
  To: pgdogdev/pgdog <noreply+pgdogdev-pgdog@github.com>

<!-- metal-bench-x86 -->

**Metal bench (x86) failed.** 48 of 520 measures outside bounds.

| suite | throughput | cpu/txn | user cycles/txn | user instr/txn | kernel cycles/txn | kernel instr/txn | ctx/txn |
|---|---|---|---|---|---|---|---|
| pooler |  | 34.67 (-0.0% ± 0.3%) | 22,783 (+0.1% ± 0.8%) | 32,782 (+0.1% ± 0.02%) | 57,897 (-0.1% ± 0.4%) | 38,625 (+0.0% ± 0.4%) |  |
| lb |  | 35.59 (-0.0% ± 0.4%) | 23,747 (+0.1% ± 1.0%) | 33,741 (+0.1% ± 0.02%) | 58,768 (-0.1% ± 0.3%) | 39,254 (-0.0% ± 0.3%) |  |
| sharding-w2 |  | 56.37 (+0.1% ± 0.6%) | 52,806 (+0.3% ± 1.7%) | 98,668 (+0.1% ± 0.01%) | 73,339 (-0.1% ± 0.6%) | 43,110 (-0.0% ± 0.8%) | 1.391 (-0.1% ± 0.08%) |
| sharding-w8 | 146,692 (-0.7% ± 5.7%) | 48.46 (+0.1% ± 3.1%) | 57,282 (-1.2% ± 0.5%) | 54,193 (+0.3% ± 0.3%) | 65,742 (+1.1% ± 5.4%) | 34,308 (+0.2% ± 0.6%) | 0.1735 (+2.6% ± 1.0%) |

<details><summary>Counters per txn</summary>

| suite | frontend stall | l1i refill | backend stall |
|---|---|---|---|
| pooler | 72,922 (+0.5% ± 1.1%) | 3,622 (+0.7% ± 0.1%) |  |
| lb | 75,675 (+0.9% ± 0.6%) | 3,733 (+0.9% ± 0.1%) |  |
| sharding-w2 | 161,078 (-0.1% ± 2.2%) | 6,076 (+0.7% ± 1.2%) |  |
| sharding-w8 | 123,918 (-0.0% ± 3.2%) | 4,934 (+0.7% ± 0.8%) |  |
</details>

| benchmark | measure | result | baseline | change | bound |
|---|---|---|---|---|---|
| extended_cached::insert_split | alloc_bytes | 7,026 | 6,834 | **+2.81% ± 0.00%** | +1% |
| extended_cold::insert_split | alloc_bytes | 9,362 | 9,170 | **+2.09% ± 0.00%** | +1% |
| extended_evicting::insert_split | alloc_bytes | 9,242 | 9,050 | **+2.12% ± 0.00%** | +1% |
| full_extended_cached::cte | alloc_bytes | 7,471 | 7,375 | **+1.30% ± 0.00%** | +1% |
| full_extended_cached::delete_all_shards | alloc_bytes | 12,960 | 12,820 | **+1.09% ± 0.00%** | +1% |
| full_extended_cached::delete_by_key | alloc_bytes | 6,382 | 6,286 | **+1.53% ± 0.00%** | +1% |
| full_extended_cached::insert | alloc_bytes | 6,328 | 6,232 | **+1.54% ± 0.00%** | +1% |
| full_extended_cached::insert_returning | alloc_bytes | 6,394 | 6,298 | **+1.52% ± 0.00%** | +1% |
| full_extended_cached::insert_split | alloc_bytes | 15,610 | 15,270 | **+2.23% ± 0.00%** | +1% |
| full_extended_cached::join | alloc_bytes | 7,877 | 7,781 | **+1.23% ± 0.00%** | +1% |
| full_extended_cached::lookup | alloc_bytes | 7,171 | 7,075 | **+1.36% ± 0.00%** | +1% |
| full_extended_cached::select_by_key | alloc_bytes | 7,139 | 7,043 | **+1.36% ± 0.00%** | +1% |
| full_extended_cached::select_in_list | alloc_bytes | 15,000 | 14,850 | **+1.01% ± 0.00%** | +1% |
| full_extended_cached::select_omni | alloc_bytes | 6,603 | 6,507 | **+1.48% ± 0.00%** | +1% |
| full_extended_cached::update_all_shards | alloc_bytes | 13,000 | 12,860 | **+1.09% ± 0.00%** | +1% |
| full_extended_cached::update_by_key | alloc_bytes | 6,404 | 6,308 | **+1.52% ± 0.00%** | +1% |
| full_named_cached::aggregate | instructions | 143,222 | 140,688 | **+1.80% ± 0.00%** | +1% |
| full_named_cached::cte | alloc_bytes | 7,348 | 7,252 | **+1.32% ± 0.00%** | +1% |
| full_named_cached::delete_all_shards | alloc_bytes | 12,840 | 12,700 | **+1.10% ± 0.00%** | +1% |
| full_named_cached::delete_by_key | alloc_bytes | 6,289 | 6,193 | **+1.55% ± 0.00%** | +1% |
| full_named_cached::insert | alloc_bytes | 6,221 | 6,125 | **+1.57% ± 0.00%** | +1% |
| full_named_cached::insert | instructions | 64,157 | 62,912 | **+1.98% ± 0.00%** | +1% |
| full_named_cached::insert_returning | alloc_bytes | 6,274 | 6,178 | **+1.55% ± 0.00%** | +1% |
| full_named_cached::insert_split | alloc_bytes | 14,980 | 14,650 | **+2.25% ± 0.00%** | +1% |
| full_named_cached::join | alloc_bytes | 7,744 | 7,648 | **+1.26% ± 0.00%** | +1% |
| full_named_cached::lookup | alloc_bytes | 7,061 | 6,965 | **+1.38% ± 0.00%** | +1% |
| full_named_cached::select_all_shards | alloc_bytes | 14,220 | 14,070 | **+1.07% ± 0.00%** | +1% |
| full_named_cached::select_by_key | alloc_bytes | 7,045 | 6,949 | **+1.38% ± 0.00%** | +1% |
| full_named_cached::select_omni | alloc_bytes | 6,517 | 6,421 | **+1.50% ± 0.00%** | +1% |
| full_named_cached::update_all_shards | alloc_bytes | 12,860 | 12,720 | **+1.10% ± 0.00%** | +1% |
| full_named_cached::update_by_key | alloc_bytes | 6,301 | 6,205 | **+1.55% ± 0.00%** | +1% |
| full_simple::cte | alloc_bytes | 7,510 | 7,414 | **+1.29% ± 0.00%** | +1% |
| full_simple::delete_all_shards | alloc_bytes | 12,010 | 11,870 | **+1.18% ± 0.00%** | +1% |
| full_simple::delete_by_key | alloc_bytes | 6,369 | 6,273 | **+1.53% ± 0.00%** | +1% |
| full_simple::insert | alloc_bytes | 6,747 | 6,651 | **+1.44% ± 0.00%** | +1% |
| full_simple::insert_returning | alloc_bytes | 6,879 | 6,783 | **+1.42% ± 0.00%** | +1% |
| full_simple::insert_split | alloc_bytes | 15,770 | 15,430 | **+2.20% ± 0.00%** | +1% |
| full_simple::join | alloc_bytes | 7,921 | 7,825 | **+1.23% ± 0.00%** | +1% |
| full_simple::select_all_shards | alloc_bytes | 13,440 | 13,300 | **+1.05% ± 0.00%** | +1% |
| full_simple::select_by_key | alloc_bytes | 7,182 | 7,086 | **+1.35% ± 0.00%** | +1% |

Microbench: 459 of 507 measures within bounds. See verdict.json for the rest.

<details><summary>Microbench latency: 5 benches changed more than 3%</summary>

| benchmark | latency | baseline | change | instructions change |
|---|---|---|---|---|
| simple_cold::select_all_shards | 3,961 ns | 3,811 ns | +3.94% ± 0.46% | +0.09% ± 0.00% |
| extended_cold::select_all_shards | 4,100 ns | 3,966 ns | +3.38% ± 0.73% | +0.09% ± 0.00% |
| simple_cold::select_omni | 3,547 ns | 3,435 ns | +3.26% ± 0.70% | +1.05% ± 0.00% |
| extended_cold::update_by_key | 4,564 ns | 4,426 ns | +3.12% ± 1.37% | +0.08% ± 0.00% |
| simple_cold::distinct | 4,229 ns | 4,105 ns | +3.02% ± 0.82% | +0.08% ± 0.00% |
</details>

<details><summary>Hot code per txn</summary>

| path | base | head | change |
|---|---|---|---|
| pooler | 106.6 KB | 108.9 KB | **+2.3 KB** |
| sharding-w2 | 163.9 KB | 168.6 KB | **+4.8 KB** |

pooler:

| crate | base | head | change |
|---|---|---|---|
| pgdog::frontend::client::query_engine | 20.4 KB | 21.2 KB | +0.9 KB |
| tokio | 17.6 KB | 18.0 KB | +0.4 KB |
| pgdog::backend::pool | 16.4 KB | 16.2 KB | -0.2 KB |
| pgdog::frontend (other) | 8.6 KB | 9.3 KB | +0.7 KB |
| aws-lc (TLS crypto) | 7.9 KB | 7.2 KB | -0.8 KB |
| pgdog::backend::server | 7.0 KB | 7.1 KB | +0.1 KB |
| rustls (TLS) | 6.8 KB | 6.8 KB | -0.1 KB |
| jemalloc | 5.1 KB | 5.9 KB | +0.8 KB |
| everything else | 16.8 KB | 17.2 KB | +0.4 KB |

| function | head | change |
|---|---|---|
| `pgdog::frontend::client::Client::run::{{closure}}` | 7.2 KB | +0.6 KB |
| `pgdog::frontend::client::query_engine::query::<impl pgdog::frontend::client::query_engine:` | 6.3 KB | +0.1 KB |
| `pgdog::frontend::client::query_engine::QueryEngine::handle::{{closure}}` | 4.4 KB | +0.3 KB |
| `tokio::runtime::task::raw::poll` | 3.8 KB | +0.1 KB |
| `pgdog::frontend::client::query_engine::query::<impl pgdog::frontend::client::query_engine:` | 3.8 KB | +0.1 KB |

sharding-w2:

| crate | base | head | change |
|---|---|---|---|
| pgdog::frontend::router | 26.6 KB | 27.4 KB | +0.9 KB |
| pgdog::frontend::client::query_engine | 22.8 KB | 23.3 KB | +0.5 KB |
| tokio | 17.9 KB | 18.2 KB | +0.4 KB |
| pgdog::backend::pool | 17.8 KB | 18.1 KB | +0.3 KB |
| other | 10.2 KB | 10.9 KB | +0.7 KB |
| jemalloc | 9.0 KB | 10.5 KB | +1.5 KB |
| pgdog::frontend (other) | 9.8 KB | 10.1 KB | +0.4 KB |
| aws-lc (TLS crypto) | 10.3 KB | 10.0 KB | -0.3 KB |
| everything else | 39.5 KB | 39.9 KB | +0.4 KB |

| function | head | change |
|---|---|---|
| `pgdog::frontend::client::Client::run::{{closure}}` | 7.6 KB | +0.2 KB |
| `pgdog::frontend::client::query_engine::query::<impl pgdog::frontend::client::query_engine:` | 6.1 KB | +0.1 KB |
| `pgdog::frontend::client::query_engine::QueryEngine::handle::{{closure}}` | 4.9 KB | +0.5 KB |
| `pgdog::frontend::router::parser::query::select::<impl pgdog::frontend::router::parser::que` | 4.1 KB | +0.1 KB |
| `pgdog::frontend::client::query_engine::query::<impl pgdog::frontend::client::query_engine:` | 3.7 KB | +0.1 KB |

</details>

<details><summary>lb flamegraph vs 73a9197f</summary>

![lb](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/murex-request-comment-spans/44f1616133f192301...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/murex-request-comment-spans/44f1616133f192301...) for hover, zoom and search.

![lb removed](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/murex-request-comment-spans/44f1616133f192301...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/murex-request-comment-spans/44f1616133f192301...).
</details>
<details><summary>microbench flamegraph vs 73a9197f</summary>

![microbench](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/murex-request-comment-spans/44f1616133f192301...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/murex-request-comment-spans/44f1616133f192301...) for hover, zoom and search.

![microbench removed](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/murex-request-comment-spans/44f1616133f192301...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/murex-request-comment-spans/44f1616133f192301...).
</details>
<details><summary>pooler flamegraph vs 73a9197f</summary>

![pooler](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/murex-request-comment-spans/44f1616133f192301...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/murex-request-comment-spans/44f1616133f192301...) for hover, zoom and search.

![pooler removed](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/murex-request-comment-spans/44f1616133f192301...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/murex-request-comment-spans/44f1616133f192301...).
</details>
<details><summary>sharding-w2 flamegraph vs 73a9197f</summary>

![sharding-w2](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/murex-request-comment-spans/44f1616133f192301...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/murex-request-comment-spans/44f1616133f192301...) for hover, zoom and search.

![sharding-w2 removed](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/murex-request-comment-spans/44f1616133f192301...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/murex-request-comment-spans/44f1616133f192301...).
</details>
<details><summary>sharding-w8 flamegraph vs 73a9197f</summary>

![sharding-w8](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/murex-request-comment-spans/44f1616133f192301...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/murex-request-comment-spans/44f1616133f192301...) for hover, zoom and search.

![sharding-w8 removed](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/murex-request-comment-spans/44f1616133f192301...)

[Open interactive](https://pgdog-metal-bench.s3.amazonaws.com/results-x86/murex-request-comment-spans/44f1616133f192301...).
</details>

<details><summary>Logs</summary>

[lb](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results-x86/murex-request-comme...), [microbench](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results-x86/murex-request-comme...), [pooler](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results-x86/murex-request-comme...), [sharding-w2](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results-x86/murex-request-comme...), [sharding-w8](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results-x86/murex-request-comme...), [verdict.json](https://s3.console.aws.amazon.com/s3/object/pgdog-metal-bench?prefix=results-x86/murex-request-comme...)
</details>

Compared 44f16161 with 73a9197f on c7a.metal-48xl (spot).


^ permalink  raw  [nested|flat] 6+ messages in thread


end of thread, other threads:[~2026-11-19 11:45 UTC | newest]

Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2026-11-19 11:08 [pgdogdev/pgdog] PR #2069: refactor(frontend): carry comment spans on ClientRequest "murex971 (@murex971)" <noreply+murex971@github.com>
2026-11-19 11:11 ` "codecov[bot] (bot) (@codecov[bot])" <noreply+codecov[bot]@github.com>
2026-11-19 11:30 ` "murex971 (@murex971)" <noreply+murex971@github.com>
2026-11-19 11:30 ` "murex971 (@murex971)" <noreply+murex971@github.com>
2026-11-19 11:45 ` "github-actions[bot] (bot) (@github-actions[bot])" <noreply+github-actions[bot]@github.com>
2026-11-19 11:45 ` "github-actions[bot] (bot) (@github-actions[bot])" <noreply+github-actions[bot]@github.com>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox