pgjdbc/pgjdbc GitHub issues and pull requests (mirror)
help / color / mirror / Atom feedFrom: davecramer (@davecramer) <[email protected]>
To: pgjdbc/pgjdbc <[email protected]>
Subject: Re: [pgjdbc/pgjdbc] issue #1225: Java 8 Time Support for Postgres Arrays
Date: Wed, 31 Jul 2019 15:42:21 +0000
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
Brett,
What do we have to do to get that merged?
Dave Cramer
On Tue, 30 Jul 2019 at 13:12, Brett Okken <[email protected]> wrote:
> I think we could relatively easily allow consumer to override default array
> type handling once the PR for reworking array decoding is merged.
>
> On Tue, Jul 30, 2019 at 9:16 AM Dave Cramer <[email protected]>
> wrote:
>
> > you'd probably be surprised to know that timestamp with timezone doesn't
> > store the timezone either then.
> >
> > In PostgreSQL -- yes, I know.
> >
> > Right, I missed the fact the issue is broader than just timestamp[].
> > I was not as much concerned about timestamptz[] being mapped to
> > java.sql.Timestamp[] because in timestamptz case all I need is point in
> > time. So this mapping at least does not lose information.
> >
> https://github.com/prestosql/presto/blob/c39358eee752eac13959fd05dc5427502cf03b33/presto-postgresql/...
> >
> > (Or course java.time.Instant would be more appropriate)
> >
> > For date[], mapping to java.sql.Date[] loses information in one edge case
> > only (DATE '2011-12-30' and Pacific/Apia zone). Of course, it's still
> > desirable to get the date[] data as java.time.LocalDate[].
> > Can you elaborate on why this one edge case fails
> >
> > (Let me explain my point of view. I am concerned mostly about losing
> > information and not about convenience, because in Presto use-cases, not
> > losing information is all we need. Even accessing String would be enough.
> > Others, are probably more interested in getting java.time. classes
> because
> > in application code there is usually more code that interacts with JDBC
> in
> > some way.)
> >
> > Sadly the whole date/time/timestamp thing with java and JDBC is beyond
> > repair. We have to chose to be opinionated here. At the moment I'm not
> sure
> > of the "best" opinion. I'm going to confer with the npgsql guys to see
> what
> > their driver does to get some level of consistency
> >
> > —
> > You are receiving this because you commented.
> > Reply to this email directly, view it on GitHub
> > <
> https://github.com/pgjdbc/pgjdbc/issues/1225?email_source=notifications&email_token=AAW3U3LOBA5R...
> >,
> > or mute the thread
> > <
> https://github.com/notifications/unsubscribe-auth/AAW3U3PVECBLJ6JNV2QTEP3QCBEKHANCNFSM4FG5ZJFA
> >
> > .
> >
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/pgjdbc/pgjdbc/issues/1225?email_source=notifications&email_token=AADDH5SDDDIU...;,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AADDH5XU7HNBJCIQKDCHXT3QCBY6DANCNFSM4FG5ZJFA;
> .
>
view thread (16+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: github://pgjdbc/pgjdbc
Cc: [email protected], [email protected]
Subject: Re: [pgjdbc/pgjdbc] issue #1225: Java 8 Time Support for Postgres Arrays
In-Reply-To: <<[email protected]>>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox