Message-ID: <gh-pgjdbc-pgjdbc-2097-c798510059@github.com>
From: "sehrope (@sehrope)" <noreply+sehrope@github.com>
To: "pgjdbc/pgjdbc" <noreply+pgjdbc-pgjdbc@github.com>
Date: Sat, 13 Mar 2021 15:27:15 +0000
Subject: Re: [pgjdbc/pgjdbc] PR #2097: report precise version of postgres on appveyor
In-Reply-To: <gh-pgjdbc-pgjdbc-2097@github.com>
References: <gh-pgjdbc-pgjdbc-2097@github.com>
List-Id: <gh-pgjdbc-pgjdbc.github.com>
X-GitHub-Author-Login: sehrope
X-GitHub-Comment-Id: 798510059
X-GitHub-Comment-Type: issue_comment
X-GitHub-Issue: 2097
X-GitHub-Repo: pgjdbc/pgjdbc
X-GitHub-Type: comment
X-GitHub-Url: https://github.com/pgjdbc/pgjdbc/pull/2097#issuecomment-798510059
Content-Type: text/plain; charset=utf-8

I'm reworking this a bit to do it via a separate JDBC test that executes `SELECT version()` on the default test JDBC connection. That way it'll be the same thing that runs on all platforms and should match the actual server being tested regardless of platform (ex: connecting over SSL vs non-SSL).

I'm thinking of printing the results of `SHOW ALL` as well. Any security implications on doing so? I wouldn't expect anything sensitive to be in there so I think it's fine.