Message-ID: <gh-pgjdbc-pgjdbc-2148-c840688502@github.com>
From: "sehrope (@sehrope)" <noreply+sehrope@github.com>
To: "pgjdbc/pgjdbc" <noreply+pgjdbc-pgjdbc@github.com>
Date: Thu, 13 May 2021 16:48:47 +0000
Subject: Re: [pgjdbc/pgjdbc] PR #2148: Avoid leaking server error details through BatchUpdateException when logServerErrorDetail=false
In-Reply-To: <gh-pgjdbc-pgjdbc-2148@github.com>
References: <gh-pgjdbc-pgjdbc-2148@github.com>
List-Id: <gh-pgjdbc-pgjdbc.github.com>
X-GitHub-Author-Login: sehrope
X-GitHub-Comment-Id: 840688502
X-GitHub-Comment-Type: issue_comment
X-GitHub-Issue: 2148
X-GitHub-Repo: pgjdbc/pgjdbc
X-GitHub-Type: comment
X-GitHub-Url: https://github.com/pgjdbc/pgjdbc/pull/2148#issuecomment-840688502
Content-Type: text/plain; charset=utf-8

Nice looks like the push worked. Let's see it run through CI and then we'll merge it.

I split out your original fix into two commits. The first updates the docs. The second is the fix for the property handling with batches. The fix itself worked but was missing an update to the one other test class that also implements BaseConnection and there were a couple style issues.

Third commit adds some new tests with batching.