Message-ID: <gh-pgjdbc-pgjdbc-2525-rc885575171@github.com>
From: "davecramer (@davecramer)" <noreply+davecramer@github.com>
To: "pgjdbc/pgjdbc" <noreply+pgjdbc-pgjdbc@github.com>
Date: Tue, 31 May 2022 12:27:22 +0000
Subject: Re: [pgjdbc/pgjdbc] PR #2525: fix: support queries with up to 65535 (inclusive) parameters
In-Reply-To: <gh-pgjdbc-pgjdbc-2525@github.com>
References: <gh-pgjdbc-pgjdbc-2525@github.com>
List-Id: <gh-pgjdbc-pgjdbc.github.com>
X-GitHub-Author-Login: davecramer
X-GitHub-Comment-Id: 885575171
X-GitHub-Comment-Type: review_comment
X-GitHub-Commit: 6c0c5da4075960e1dffa91480fb8b3a4932f8e1b
X-GitHub-Issue: 2525
X-GitHub-Path: pgjdbc/src/main/java/org/postgresql/core/PGStream.java
X-GitHub-Repo: pgjdbc/pgjdbc
X-GitHub-Type: review_comment
X-GitHub-Url: https://github.com/pgjdbc/pgjdbc/pull/2525#discussion_r885575171
Content-Type: text/plain; charset=utf-8

(on pgjdbc/src/main/java/org/postgresql/core/PGStream.java)

are we allowed negative values here ? Should this be < 0 || > 65535 ?