Re: [pgjdbc/pgjdbc] PR #2646: feat: improve libpq compatibility for URL parsing, environment variables, passfile, and property naming - gitguardian[bot] (bot) (@gitguardian[bot])

pgjdbc/pgjdbc GitHub issues and pull requests (mirror)  
help / color / mirror / Atom feed

From: gitguardian[bot] (bot) (@gitguardian[bot]) <noreply+gitguardian[bot]@github.com>
To: pgjdbc/pgjdbc <[email protected]>
Subject: Re: [pgjdbc/pgjdbc] PR #2646: feat: improve libpq compatibility for URL parsing, environment variables, passfile, and property naming
Date: Thu, 20 Oct 2022 19:13:38 +0000
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>

#### ⚠️ GitGuardian has uncovered 9 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

<details>
<summary>🔎 Detected hardcoded secrets in your pull request</summary>
<br>

| GitGuardian id | GitGuardian status | Secret                         | Commit           | Filename        |                      |
| -------------- | ------------------ | ------------------------------ | ---------------- | --------------- | -------------------- |
| [-](https://dashboard.gitguardian.com/workspace/59849/incidents/secrets) | - | PostgreSQL Credentials | 0626960921d42633e07ec5bb6ddd47d97a6f7a16 | pgjdbc/src/test/java/org/postgresql/jdbcurlresolver/JdbcUrlResolverTest.java | [View secret](https://github.com/pgjdbc/pgjdbc/commit/0626960921d42633e07ec5bb6ddd47d97a6f7a16#diff-4531a18c3790df...) |
| [-](https://dashboard.gitguardian.com/workspace/59849/incidents/secrets) | - | Generic Password | 0626960921d42633e07ec5bb6ddd47d97a6f7a16 | pgjdbc/src/test/java/org/postgresql/jdbcurlresolver/JdbcUrlResolverTest.java | [View secret](https://github.com/pgjdbc/pgjdbc/commit/0626960921d42633e07ec5bb6ddd47d97a6f7a16#diff-4531a18c3790df...) |
| [-](https://dashboard.gitguardian.com/workspace/59849/incidents/secrets) | - | Generic Password | 0626960921d42633e07ec5bb6ddd47d97a6f7a16 | pgjdbc/src/test/java/org/postgresql/jdbcurlresolver/JdbcUrlResolverTest.java | [View secret](https://github.com/pgjdbc/pgjdbc/commit/0626960921d42633e07ec5bb6ddd47d97a6f7a16#diff-4531a18c3790df...) |
| [-](https://dashboard.gitguardian.com/workspace/59849/incidents/secrets) | - | PostgreSQL Credentials | 0626960921d42633e07ec5bb6ddd47d97a6f7a16 | pgjdbc/src/test/java/org/postgresql/jdbcurlresolver/JdbcUrlResolverTest.java | [View secret](https://github.com/pgjdbc/pgjdbc/commit/0626960921d42633e07ec5bb6ddd47d97a6f7a16#diff-4531a18c3790df...) |
| [-](https://dashboard.gitguardian.com/workspace/59849/incidents/secrets) | - | Generic Password | 0626960921d42633e07ec5bb6ddd47d97a6f7a16 | pgjdbc/src/test/resources/pg_service/pgservicefileProps.conf | [View secret](https://github.com/pgjdbc/pgjdbc/commit/0626960921d42633e07ec5bb6ddd47d97a6f7a16#diff-383f6df5ed2e09...) |
| [-](https://dashboard.gitguardian.com/workspace/59849/incidents/secrets) | - | Generic Password | 0626960921d42633e07ec5bb6ddd47d97a6f7a16 | pgjdbc/src/test/java/org/postgresql/jdbcurlresolver/JdbcUrlResolverTest.java | [View secret](https://github.com/pgjdbc/pgjdbc/commit/0626960921d42633e07ec5bb6ddd47d97a6f7a16#diff-4531a18c3790df...) |
| [-](https://dashboard.gitguardian.com/workspace/59849/incidents/secrets) | - | Generic Database Assignment | 0626960921d42633e07ec5bb6ddd47d97a6f7a16 | pgjdbc/src/test/java/org/postgresql/jdbcurlresolver/JdbcUrlResolverTest.java | [View secret](https://github.com/pgjdbc/pgjdbc/commit/0626960921d42633e07ec5bb6ddd47d97a6f7a16#diff-4531a18c3790df...) |
| [-](https://dashboard.gitguardian.com/workspace/59849/incidents/secrets) | - | Generic Password | 0626960921d42633e07ec5bb6ddd47d97a6f7a16 | pgjdbc/src/test/resources/pg_service/pgservicefileProps.conf | [View secret](https://github.com/pgjdbc/pgjdbc/commit/0626960921d42633e07ec5bb6ddd47d97a6f7a16#diff-383f6df5ed2e09...) |
| [-](https://dashboard.gitguardian.com/workspace/59849/incidents/secrets) | - | Generic Password | 0626960921d42633e07ec5bb6ddd47d97a6f7a16 | pgjdbc/src/test/java/org/postgresql/jdbcurlresolver/JdbcUrlResolverTest.java | [View secret](https://github.com/pgjdbc/pgjdbc/commit/0626960921d42633e07ec5bb6ddd47d97a6f7a16#diff-4531a18c3790df...) |



</details>

<details>
<summary>🛠 Guidelines to remediate hardcoded secrets</summary>
<br>

1. Understand the implications of revoking this secret by investigating where it is used in your code.
2. Replace and store your secrets safely. [Learn here](https://blog.gitguardian.com/secrets-api-management?utm_source=product&amp;utm_medium=GitHub_che...) the best practices.
3. Revoke and [rotate these secrets](https://docs.gitguardian.com/secrets-detection/secrets-detection-engine/detectors/specifics/postgres...).
4. If possible, [rewrite git history](https://blog.gitguardian.com/rewriting-git-history-cheatsheet?utm_source=product&amp;utm_medium=...). Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

-   following these [best practices](https://blog.gitguardian.com/secrets-api-management/?utm_source=product&amp;utm_medium=GitHub_ch...) for managing and storing secrets including API keys and other credentials
-   install [secret detection on pre-commit](https://docs.gitguardian.com/ggshield-docs/integrations/git-hooks/pre-commit?utm_source=product&...) to catch secret before it leaves your machine and ease remediation.


</details>

---

<sup>🦉 [GitGuardian](https://dashboard.gitguardian.com/auth/login/?utm_medium=checkruns&amp;utm_source=github&amp...) detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.<br/></sup>

view thread (55+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: github://pgjdbc/pgjdbc
  Cc: noreply+gitguardian[bot]@github.com, [email protected]
  Subject: Re: [pgjdbc/pgjdbc] PR #2646: feat: improve libpq compatibility for URL parsing, environment variables, passfile, and property naming
  In-Reply-To: <<[email protected]>>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox