Message-ID: <gh-pgjdbc-pgjdbc-2646-rc1570757720@github.com>
From: "sehrope (@sehrope)" <noreply+sehrope@github.com>
To: "pgjdbc/pgjdbc" <noreply+pgjdbc-pgjdbc@github.com>
Date: Thu, 18 Apr 2024 13:29:33 +0000
Subject: Re: [pgjdbc/pgjdbc] PR #2646: feat: improve libpq compatibility for URL parsing, environment variables, passfile, and property naming
In-Reply-To: <gh-pgjdbc-pgjdbc-2646@github.com>
References: <gh-pgjdbc-pgjdbc-2646@github.com>
List-Id: <gh-pgjdbc-pgjdbc.github.com>
X-GitHub-Author-Login: sehrope
X-GitHub-Comment-Id: 1570757720
X-GitHub-Comment-Type: review_comment
X-GitHub-Commit: 7db00b9839b123548eefdf3a1a72235505f23264
X-GitHub-Issue: 2646
X-GitHub-Path: pgjdbc/src/test/java/org/postgresql/test/jdbc2/DriverTest.java
X-GitHub-Repo: pgjdbc/pgjdbc
X-GitHub-Type: review_comment
X-GitHub-Url: https://github.com/pgjdbc/pgjdbc/pull/2646#discussion_r1570757720
Content-Type: text/plain; charset=utf-8

(on pgjdbc/src/test/java/org/postgresql/test/jdbc2/DriverTest.java)

How about adding an overload for the old private `verifyUrl(...)` to call the new one?

```java
private void verifyUrl(Driver drv, String url, String hosts, String ports, String dbName) {
    verifyUrl(drv, url, hosts, ports, dbName, "osUser", null);
}
```

That way the majority of the above test cases would not duplicate that info and it would better showcase that none of the expected behavior for those tests have changed.