Message-ID: <gh-pgjdbc-pgjdbc-2646-rc1598038288@github.com>
From: "vlsi (@vlsi)" <noreply+vlsi@github.com>
To: "pgjdbc/pgjdbc" <noreply+pgjdbc-pgjdbc@github.com>
Date: Mon, 13 May 2024 08:00:01 +0000
Subject: Re: [pgjdbc/pgjdbc] PR #2646: feat: improve libpq compatibility for URL parsing, environment variables, passfile, and property naming
In-Reply-To: <gh-pgjdbc-pgjdbc-2646@github.com>
References: <gh-pgjdbc-pgjdbc-2646@github.com>
List-Id: <gh-pgjdbc-pgjdbc.github.com>
X-GitHub-Author-Login: vlsi
X-GitHub-Comment-Id: 1598038288
X-GitHub-Comment-Type: review_comment
X-GitHub-Commit: 0626960921d42633e07ec5bb6ddd47d97a6f7a16
X-GitHub-Issue: 2646
X-GitHub-Line: 1568
X-GitHub-Path: pgjdbc/src/main/java/org/postgresql/ds/common/BaseDataSource.java
X-GitHub-Repo: pgjdbc/pgjdbc
X-GitHub-Type: review_comment
X-GitHub-Url: https://github.com/pgjdbc/pgjdbc/pull/2646#discussion_r1598038288
Content-Type: text/plain; charset=utf-8

(on pgjdbc/src/main/java/org/postgresql/ds/common/BaseDataSource.java:1568)

This is a backward incompatible change. Old code might still call `setProperty(PGProperty.PG_HOST, ...)` and it should continue to work as expected.